Add sql managed instance #9164
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg", | ||
| "dataControllerName": "testdataController", | ||
| "api-version": "2017-07-24", | ||
| "parameters": { | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "properties": {} | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/dataControllers/testdataController", | ||
| "name": "testdataController", | ||
| "type": "Microsoft.AzureData/dataControllers" | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/dataControllers/testdataController", | ||
| "name": "testdataController", | ||
| "type": "Microsoft.AzureData/dataControllers" | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg", | ||
| "sqlManagedInstanceName": "testsqlManagedInstance", | ||
| "api-version": "2017-07-24", | ||
| "parameters": { | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "properties": {} | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": {}, | ||
|
There was a problem hiding this comment. Same as above no required parameters? Not sure how clients would be able to use this or build any applications based on such definition? There was a problem hiding this comment. This is just a copy of sqlInstances which is being renamed to sqlManagedInstances. We are working on what properties will be there and we'll add those once the work progresses. For now this is just a "shadow" resource that maps to some objects on premise. |
||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/sqlManagedInstances/testsqlManagedInstance", | ||
| "name": "testsqlManagedInstance", | ||
| "type": "Microsoft.AzureData/sqlManagedInstances" | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/sqlManagedInstances/testsqlManagedInstance", | ||
| "name": "testsqlManagedInstance", | ||
| "type": "Microsoft.AzureData/sqlManagedInstances" | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg", | ||
| "dataControllerName": "testdataController", | ||
| "api-version": "2017-07-24" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg", | ||
| "sqlManagedInstanceName": "testsqlManagedInstance", | ||
| "api-version": "2017-07-24" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg", | ||
| "dataControllerName": "testdataController", | ||
| "api-version": "2017-07-24" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": {}, | ||
|
There was a problem hiding this comment. Please provide real world examples. There was a problem hiding this comment. Same here. Will update the examples as the work on the premise side progresses. |
||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/dataControllers/testdataController", | ||
| "name": "testdataController", | ||
| "type": "Microsoft.AzureData/dataControllers" | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg", | ||
| "sqlManagedInstanceName": "testsqlManagedInstance", | ||
| "api-version": "2017-07-24" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/sqlManagedInstances/testsqlManagedInstance", | ||
| "name": "testsqlManagedInstance", | ||
| "type": "Microsoft.AzureData/sqlManagedInstance" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg", | ||
| "api-version": "2017-07-24" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/dataControllers/testdataController1", | ||
| "name": "testdataController1", | ||
| "type": "Microsoft.AzureData/dataControllers" | ||
| }, | ||
| { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/dataControllers/testdataController2", | ||
| "name": "testdataController2", | ||
| "type": "Microsoft.AzureData/dataControllers" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg", | ||
| "api-version": "2017-07-24" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/sqlManagedInstances/sqlManagedInstance1", | ||
| "name": "sqlManagedInstances1", | ||
| "type": "Microsoft.AzureData/sqlManagedInstances" | ||
| }, | ||
| { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/sqlManagedInstances/sqlManagedInstance2", | ||
| "name": "sqlManagedInstances2", | ||
| "type": "Microsoft.AzureData/sqlManagedInstances" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "api-version": "2017-07-24" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
chiragg4u marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/dataControllers/testdataController1", | ||
| "name": "testdataController1", | ||
| "type": "Microsoft.AzureData/dataControllers" | ||
| }, | ||
| { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/dataControllers/testdataController2", | ||
| "name": "testdataController2", | ||
| "type": "Microsoft.AzureData/dataControllers" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "api-version": "2017-07-24" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/SqlManagedInstances/sqlManagedInstance1", | ||
| "name": "sqlManagedInstances1", | ||
| "type": "Microsoft.AzureData/sqlManagedInstances" | ||
| }, | ||
| { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/SqlManagedInstances/sqlManagedInstance2", | ||
| "name": "sqlManagedInstances2", | ||
| "type": "Microsoft.AzureData/sqlManagedInstances" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg", | ||
| "dataControllerName": "testdataController1", | ||
| "api-version": "2019-07-24", | ||
| "parameters": { | ||
| "tags": { | ||
| "mytag": "myval" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "tags": { | ||
| "mytag": "myval" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/dataControllers/testdataController1", | ||
| "name": "testdataController1", | ||
| "type": "Microsoft.AzureData/dataControllers" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "testrg", | ||
| "sqlManagedInstanceName": "testsqlManagedInstance", | ||
| "api-version": "2017-07-24", | ||
| "parameters": { | ||
| "tags": { | ||
| "mytag": "myval" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": {}, | ||
| "location": "northeurope", | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.AzureData/sqlManagedInstances/testsqlManagedInstance", | ||
| "name": "testsqlManagedInstance", | ||
| "type": "Microsoft.AzureData/sqlManagedInstances" | ||
| } | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to provide example of how this will be used? It's strange that there are no required parameters for this type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure, this is for now just a copy of "hybridDataControllers" type which is being renamed to dataControllers. These objects are currently just used by a CLI tool that creates these "shadow" resources that map to onpremise objects.
We plan on updating the examples and properties on these "shadow" resources as they work on premises progresses.