Add sql managed instance #9164

jorgbaca · 2020-04-21T21:02:08Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…t.AzureData/hybridDataManagers)

azure-pipelines · 2020-04-21T21:02:25Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-04-21T21:03:47Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 582834e with merge commit 02d54c8. SDK Automation 13.0.17.20200619.4
️✔️preview/azuredata/mgmt/2019-07-24-preview [View full logs] [Release SDK Changes]
- preview.azuredata.mgmt.2019-07-24-preview.zip

openapi-sdkautomation · 2020-04-21T21:03:57Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 582834e with merge commit 02d54c8. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-04-21T21:03:58Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 582834e with merge commit 02d54c8. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-04-21T21:04:07Z

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-21T21:04:11Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 582834e with merge commit 02d54c8. SDK Automation 13.0.17.20200619.4

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/_azure_data_management_client.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_azure_data_management_client_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_data_controllers_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_hybrid_data_managers_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_postgres_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_managed_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_server_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_server_registrations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_servers_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/version.py

openapi-sdkautomation · 2020-04-21T21:10:12Z

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-21T21:13:18Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 582834e with merge commit 02d54c8. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.AzureData [View full logs] [Release SDK Changes]
No Artifact Generated.

azuresdkci · 2020-04-21T21:40:11Z

Can one of the admins verify this patch?

jorgbaca · 2020-04-30T23:26:47Z

Hi @raych1 , have you had a chance to look at this PR?
Let me know if you need something from me. Thanks!

...ion/azuredata/resource-manager/Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json

azure-pipelines · 2020-05-01T16:36:47Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-pipeline-app · 2020-06-11T20:59:45Z

[Staging] Swagger Validation Report

️️✔️~[Staging] BreakingChange [Detail]

_{Posted by Swagger Pipeline}

azure-pipelines · 2020-06-11T20:59:53Z

No commit pushedDate could be found for PR 9164 in repo Azure/azure-rest-api-specs

azure-pipelines · 2020-06-11T21:34:38Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-06-11T22:06:55Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-11T22:07:17Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-11T22:07:42Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

jorgbaca · 2020-06-11T22:24:52Z

@raych1 @anthony-c-martin , I have this PR from some time ago that was never merged, I just solved a conflict from recent changes from master and all checks passed. Can you guys take a look at it? Let me know if you need something from me to get it merged. Thank you for your help.

chiragg4u

Please take a look at the comments.

chiragg4u · 2020-06-16T16:20:25Z

...ion/azuredata/resource-manager/Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json

+        "modelAsString": true
+      }
+    },
+    "HandshakeRequest": {


There are no properties in this object?

Correct. There are some objects that still don't have properties. Most objects are just "shadow" objects that map to some objects on the customer's premises, but many functionality is still not defined/final yet.

If there are changes expected I would recommend you to publish to internal repo as per
https://github.com/Azure/adx-documentation-pr/wiki/The-review-process

chiragg4u · 2020-06-16T16:21:33Z

...er/Microsoft.AzureData/preview/2019-07-24-preview/examples/CreateOrUpdateDataController.json

+  "responses": {
+    "200": {
+      "body": {
+        "properties": {},


Good to provide example of how this will be used? It's strange that there are no required parameters for this type.

For sure, this is for now just a copy of "hybridDataControllers" type which is being renamed to dataControllers. These objects are currently just used by a CLI tool that creates these "shadow" resources that map to onpremise objects.

We plan on updating the examples and properties on these "shadow" resources as they work on premises progresses.

chiragg4u · 2020-06-16T16:23:34Z

...icrosoft.AzureData/preview/2019-07-24-preview/examples/CreateOrUpdateSqlManagedInstance.json

+  "responses": {
+    "200": {
+      "body": {
+        "properties": {},


Same as above no required parameters? Not sure how clients would be able to use this or build any applications based on such definition?

This is just a copy of sqlInstances which is being renamed to sqlManagedInstances. We are working on what properties will be there and we'll add those once the work progresses. For now this is just a "shadow" resource that maps to some objects on premise.

chiragg4u · 2020-06-16T16:24:06Z

...ource-manager/Microsoft.AzureData/preview/2019-07-24-preview/examples/GetDataController.json

+  "responses": {
+    "200": {
+      "body": {
+        "properties": {},


Please provide real world examples.

Same here. Will update the examples as the work on the premise side progresses.

.../Microsoft.AzureData/preview/2019-07-24-preview/examples/ListSubscriptionDataController.json

chiragg4u

Satisfied with the responses, approving.

* Adding Microsoft.AzureData/dataControllers (mostly a copy of Microsoft.AzureData/hybridDataManagers) * Fixing issue. * Fixed response body * Use camelCase style * Updated DataControllerResource * Removed invalid format * Adding sqlManagedInstances * Added simple comment. * Adding default responses

jorgbaca added 7 commits April 14, 2020 11:10

Adding Microsoft.AzureData/dataControllers (mostly a copy of Microsof…

107d645

…t.AzureData/hybridDataManagers)

Fixing issue.

56c9a48

Fixed response body

5e70bc7

Use camelCase style

84a15d6

Updated DataControllerResource

ff77e19

Removed invalid format

d358f84

Adding sqlManagedInstances

d89cea6

openapi-sdkautomation bot mentioned this pull request Apr 21, 2020

[AutoPR Microsoft.Azure.Management.AzureData] Add sql managed instance AzureSDKAutomation/azure-sdk-for-net#952

Closed

ruowan assigned raych1 Apr 22, 2020

raych1 added the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Apr 22, 2020

openapi-assignment-bot bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 24, 2020

jorgbaca marked this pull request as ready for review April 24, 2020 20:32

anthony-c-martin added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR labels Apr 24, 2020

raych1 reviewed May 1, 2020

View reviewed changes

...ion/azuredata/resource-manager/Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json Show resolved Hide resolved

raych1 reviewed May 1, 2020

View reviewed changes

...ion/azuredata/resource-manager/Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json Outdated Show resolved Hide resolved

Added simple comment.

79a6914

openapi-assignment-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 1, 2020

raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 6, 2020

jorgbaca added 2 commits June 11, 2020 13:23

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

c2bdd4b

Merge branch 'master' into add-sqlManagedInstance

f4aaa98

Adding default responses

582834e

chiragg4u suggested changes Jun 16, 2020

View reviewed changes

chiragg4u approved these changes Jun 19, 2020

View reviewed changes

chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 19, 2020

raych1 approved these changes Jun 30, 2020

View reviewed changes

raych1 merged commit 02d54c8 into Azure:master Jun 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sql managed instance #9164

Add sql managed instance #9164

jorgbaca commented Apr 21, 2020 •

edited by ruowan

Loading

azure-pipelines bot commented Apr 21, 2020

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

azuresdkci commented Apr 21, 2020

jorgbaca commented Apr 30, 2020

azure-pipelines bot commented May 1, 2020

openapi-pipeline-app bot commented Jun 11, 2020 •

edited

Loading

azure-pipelines bot commented Jun 11, 2020

azure-pipelines bot commented Jun 11, 2020

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

jorgbaca commented Jun 11, 2020

chiragg4u left a comment

chiragg4u Jun 16, 2020

jorgbaca Jun 16, 2020

chiragg4u Jun 17, 2020

chiragg4u Jun 16, 2020

jorgbaca Jun 16, 2020

chiragg4u Jun 16, 2020

jorgbaca Jun 16, 2020

chiragg4u Jun 16, 2020

jorgbaca Jun 16, 2020

chiragg4u left a comment

Add sql managed instance #9164

Add sql managed instance #9164

Conversation

jorgbaca commented Apr 21, 2020 • edited by ruowan Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Apr 21, 2020

openapi-sdkautomation bot commented Apr 21, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Apr 21, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Apr 21, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Apr 21, 2020 • edited Loading

azure-cli-extensions

openapi-sdkautomation bot commented Apr 21, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Apr 21, 2020 • edited Loading

azure-sdk-for-trenton

openapi-sdkautomation bot commented Apr 21, 2020 • edited Loading

azure-sdk-for-net - Release

azuresdkci commented Apr 21, 2020

jorgbaca commented Apr 30, 2020

azure-pipelines bot commented May 1, 2020

openapi-pipeline-app bot commented Jun 11, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jun 11, 2020

azure-pipelines bot commented Jun 11, 2020

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading

Trenton Generation - Release

jorgbaca commented Jun 11, 2020

chiragg4u left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chiragg4u left a comment

Choose a reason for hiding this comment

jorgbaca commented Apr 21, 2020 •

edited by ruowan

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 21, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading