Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add object replication policy #8864

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Conversation

zfchen95
Copy link
Contributor

@zfchen95 zfchen95 commented Mar 27, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zfchen95
Copy link
Contributor Author

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 27, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 27, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 13aa234 with merge commit 608254a. SDK Automation 13.0.17.20200326.3
  • ⚠️preview/storage/mgmt/2015-05-01-preview [Logs
      No file is changed.
    • ⚠️preview/storage/mgmt/2018-03-01-preview [Logs
        No file is changed.
      • ⚠️storage/mgmt/2015-06-15 [Logs
          No file is changed.
        • ⚠️storage/mgmt/2016-01-01 [Logs
            No file is changed.
          • ⚠️storage/mgmt/2016-05-01 [Logs
              No file is changed.
            • ⚠️storage/mgmt/2016-12-01 [Logs
                No file is changed.
              • ⚠️storage/mgmt/2017-06-01 [Logs
                  No file is changed.
                • ⚠️storage/mgmt/2017-10-01 [Logs
                    No file is changed.
                  • ⚠️storage/mgmt/2018-02-01 [Logs
                      No file is changed.
                    • ⚠️storage/mgmt/2018-07-01 [Logs
                        No file is changed.
                      • ⚠️storage/mgmt/2018-11-01 [Logs
                          No file is changed.
                        • ⚠️storage/mgmt/2019-04-01 [Logs
                            No file is changed.
                          • ️✔️storage/mgmt/2019-06-01 [Logs]  [Release SDK Changes]

                          @openapi-sdkautomation
                          Copy link

                          openapi-sdkautomation bot commented Mar 27, 2020

                          azure-sdk-for-python - Release

                          ️✔️ succeeded [Logs] [Expand Details]
                          • ️✔️ Generate from 13aa234 with merge commit 608254a. SDK Automation 13.0.17.20200326.3
                          • ️✔️azure-mgmt-storage [Logs]  [Release SDK Changes]
                            [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-03-01-preview', '2018-07-01'} in label v2018_07_01
                            [after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
                            [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                            [build_package]   warnings.warn(msg)
                            [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                            [build_package]   warnings.warn(msg)
                            [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
                            [breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
                            [breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
                            [ChangeLog] Size of delta 4.997% size of original (original: 74665 chars, delta: 3731 chars)
                            [ChangeLog] **Features**
                            [ChangeLog] 
                            [ChangeLog]   - Model RestorePolicyProperties has a new parameter last_enabled_time
                            [ChangeLog]   - Added operation group ObjectReplicationPoliciesOperations

                          @openapi-sdkautomation
                          Copy link

                          openapi-sdkautomation bot commented Mar 27, 2020

                          azure-cli-extensions - Release

                          No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

                          @openapi-sdkautomation
                          Copy link

                          openapi-sdkautomation bot commented Mar 27, 2020

                          azure-sdk-for-js - Release

                          ️✔️ succeeded [Logs] [Expand Details]

                          @openapi-sdkautomation
                          Copy link

                          openapi-sdkautomation bot commented Mar 27, 2020

                          azure-sdk-for-net - Release

                          ️✔️ succeeded [Logs] [Expand Details]

                          @azuresdkci
                          Copy link
                          Contributor

                          Can one of the admins verify this patch?

                          "description": "Optional. Filters the results to replicate only blobs whose names begin with the specified prefix."
                          },
                          "minCreationTime": {
                          "type": "string",
                          Copy link
                          Member

                          Choose a reason for hiding this comment

                          The reason will be displayed to describe this comment to others. Learn more.

                          This should be datetime format. Using string format will make we need to add a lot of code to handle to format convert in Powershell (and other user of SDK), which easy to take bugs.

                          Copy link
                          Contributor Author

                          Choose a reason for hiding this comment

                          The reason will be displayed to describe this comment to others. Learn more.

                          Using datetime format will break the server side. Server side could support datetime format in the future.

                          Copy link
                          Member

                          Choose a reason for hiding this comment

                          The reason will be displayed to describe this comment to others. Learn more.

                          How would it break server side? It would still be serialized as a string in JSON.


                          In reply to: 401773509 [](ancestors = 401773509)

                          Copy link
                          Member

                          Choose a reason for hiding this comment

                          The reason will be displayed to describe this comment to others. Learn more.

                          It would also be good to get this fixed up front so we generate SDKs correctly from the beginning.


                          In reply to: 403179698 [](ancestors = 403179698,401773509)

                          @blueww
                          Copy link
                          Member

                          blueww commented Mar 28, 2020

                          For the .NET SDK failure, it caused by a before swager change in #8595.

                          I have raised a PR to fix the unit test in .NET SDK Azure/azure-sdk-for-net#10867, We should rerun the .NET SDK test after the PR is in.

                          [Update on 3/30/2020] The .NET SDK PR is in, and the .NET SDK check pass now.

                          @blueww
                          Copy link
                          Member

                          blueww commented Mar 30, 2020

                          /azp run

                          @azure-pipelines
                          Copy link

                          Azure Pipelines successfully started running 3 pipeline(s).

                          @azure-pipelines
                          Copy link

                          Azure Pipelines successfully started running 1 pipeline(s).

                          @zfchen95
                          Copy link
                          Contributor Author

                          Please add ARM team for review if needed. Thanks

                          @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMReview labels Apr 3, 2020
                          Copy link
                          Member

                          @majastrz majastrz left a comment

                          Choose a reason for hiding this comment

                          The reason will be displayed to describe this comment to others. Learn more.

                          Looks identical to the previously approved private PR (except for the one date-time format change). Signed off from ARM side. Please clear up the date-time format issue before merging, though.

                          @qianwens qianwens merged commit 608254a into Azure:master Apr 7, 2020
                          00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                          * [Storage] Add object replication policy
                          
                          * Fix spellcheck and prettier check
                          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                          Labels
                          ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
                          Projects
                          None yet
                          Development

                          Successfully merging this pull request may close these issues.

                          6 participants