Add support for default encryption scope & block encryption scope override for blob container APIs. #8595

tonykjose · 2020-03-04T22:23:27Z

…rride for blob container APIs.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…rride for blob container APIs.

azure-pipelines · 2020-03-04T22:23:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-04T22:23:52Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-04T22:23:54Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-04T22:23:55Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-04T22:23:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-04T22:24:05Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-04T22:25:04Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from f31b309 with merge commit 9fb516a. SDK Automation 13.0.17.20200326.3
️✔️sdk/storage/mgmt-v2016_01_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2017_10_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_02_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_03_01_preview [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_07_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2019_04_01 [Logs] [Release SDK Changes]

⚠️sdk/storage/mgmt-v2019_06_01 [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[78,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storage: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[78,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-03-04T22:25:08Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from f31b309 with merge commit 9fb516a. SDK Automation 13.0.17.20200326.3
⚠️preview/storage/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```
⚠️preview/storage/mgmt/2018-03-01-preview [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-01-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-05-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-12-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
️✔️storage/mgmt/2019-06-01 [Logs] [Release SDK Changes]
- storage.mgmt.2019-06-01.zip

openapi-sdkautomation · 2020-03-04T22:25:12Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from f31b309 with merge commit 9fb516a. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-storage [Logs] [Release SDK Changes]

azure-arm-storage-13.1.0.tgz

[npmPack] npm WARN lifecycle @azure/[email protected]~prepack: cannot run in wd @azure/[email protected] npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/storage/arm-storage)

openapi-sdkautomation · 2020-03-04T22:25:15Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from f31b309 with merge commit 9fb516a. SDK Automation 13.0.17.20200326.3
❌Microsoft.Azure.Management.Storage [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.Storage.4.2.0-preview.nupkg
- Microsoft.Azure.Management.Storage.4.2.0-preview.symbols.nupkg
```
Failed to create the package Microsoft.Azure.Management.Storage.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=storage /v:n /p:SkipTests=true , {} 
```

openapi-sdkautomation · 2020-03-04T22:25:18Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from f31b309 with merge commit 9fb516a. SDK Automation 13.0.17.20200326.3

⚠️azure-mgmt-storage [Logs] [Release SDK Changes] Breaking Change Detected

[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-03-01-preview', '2018-07-01'} in label v2018_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 2.101% size of original (original: 71101 chars, delta: 1494 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model ListContainerItem has a new parameter default_encryption_scope
[ChangeLog]   - Model ListContainerItem has a new parameter deny_encryption_scope_override
[ChangeLog]   - Model KeyVaultProperties has a new parameter last_key_rotation_timestamp
[ChangeLog]   - Model KeyVaultProperties has a new parameter current_versioned_key_identifier
[ChangeLog]   - Model BlobContainer has a new parameter default_encryption_scope
[ChangeLog]   - Model BlobContainer has a new parameter deny_encryption_scope_override
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Operation BlobContainersOperations.update has a new signature
[ChangeLog]   - Operation BlobContainersOperations.create has a new signature
[ChangeLog]   - Operation BlobContainersOperations.update has a new signature
[ChangeLog]   - Operation BlobContainersOperations.create has a new signature

azuresdkci · 2020-03-04T22:40:43Z

Can one of the admins verify this patch?

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/blob.json

qianwens · 2020-03-09T14:39:37Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/blob.json

+          "type": "string",
+          "description": "Default the container to use specified encryption scope for all writes."
+        },
+        "denyEncryptionScopeOverride": {


denyEncryptionScopeOverride [](start = 9, length = 27)

Consider to to use enum or string instead of boolean in case you need other mode which may cause breaking change.

This was intentionally modeled as a boolean to match data plane headers following the same.

qianwens · 2020-03-10T08:07:17Z

Invite ARM review since this PR add properties in the put request.

azure-pipelines · 2020-03-18T00:49:37Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-18T00:50:48Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-03-18T01:17:29Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T01:27:27Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T01:32:27Z

Azure Pipelines successfully started running 1 pipeline(s).

anthony-c-martin · 2020-03-20T06:48:44Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/blob.json

@@ -797,6 +800,14 @@
  "definitions": {
    "ContainerProperties": {
      "properties": {
+        "defaultEncryptionScope": {


Adding new writable properties to a stable API is considered a breaking change. Could this instead be moved into a new API version?

Add these 2 new properties should no be breaking since:

Old sdk still work, as the new properties are optional

Old SDK won't change the properties added with new SDK

PhoenixHe-NV · 2020-03-25T04:02:18Z

/azp run

azure-pipelines · 2020-03-25T04:02:38Z

Azure Pipelines successfully started running 3 pipeline(s).

qianwens · 2020-03-25T06:29:47Z

@tonykjose , the CI failed because the breaking change in the API. Could you please help provide justified information for this breaking change and why not add a new API version?

qianwens · 2020-03-25T12:59:03Z

@akning-ms could you please help force merge this PR since the breaking change is accepted to SDK?

blueww · 2020-03-26T01:32:43Z

Actually, the rest API itself is not breaking (Just add 2 properties), but the SDK generated from the swagger will break.
For .net SDK , this is because with autogenerated code, the new added parameter is added before the original parameter.
This will make the code write with before SDK build fail. But the fix is very easy.

I don’t think this break should block the swagger PR merge.
For .net SDK, I will fix the unit test after the swagger is in.
I think other SDK owner should also fix related Unit test. (They are owned by Dev div.)

Origin：
public static BlobContainer Create(this IBlobContainersOperations operations, string resourceGroupName, string accountName, string containerName, PublicAccess? publicAccess = default(PublicAccess?), IDictionary<string, string> metadata = default(IDictionary<string, string>))

New：
public static BlobContainer Create(this IBlobContainersOperations operations, string resourceGroupName, string accountName, string containerName, string defaultEncryptionScope = default(string), bool? denyEncryptionScopeOverride = default(bool?), PublicAccess? publicAccess = default(PublicAccess?), IDictionary<string, string> metadata = default(IDictionary<string, string>))

…rride for blob container APIs. (Azure#8595) * Add support for default encryption scope & block encryption scope override for blob container APIs. * Add examples. * Fix prettier issues. * Fix prettier errors. * Really fix prettier errors.

Add support for default encryption scope & block encryption scope ove…

1686587

…rride for blob container APIs.

openapi-assignment-bot bot assigned qianwens Mar 4, 2020

blueww reviewed Mar 5, 2020

View reviewed changes

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/blob.json Show resolved Hide resolved

qianwens reviewed Mar 9, 2020

View reviewed changes

qianwens added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 10, 2020

Add examples.

b7946f3

tonykjose requested a review from JasonYang-MSFT as a code owner March 18, 2020 00:49

Fix prettier issues.

b7620f6

Fix prettier errors.

703a690

Really fix prettier errors.

f31b309

mmyyrroonn added the ARM-overdue ARM review has not occurred within the expected timeframe label Mar 19, 2020

anthony-c-martin reviewed Mar 20, 2020

View reviewed changes

qianwens approved these changes Mar 25, 2020

View reviewed changes

qianwens added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 labels Mar 25, 2020

qianwens added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 25, 2020

akning-ms merged commit 9fb516a into Azure:master Mar 26, 2020

blueww mentioned this pull request Mar 28, 2020

[Storage] Add object replication policy #8864

Merged

5 tasks

changlong-liu mentioned this pull request Apr 3, 2020

release 14.1.0 Azure/azure-sdk-for-js#8184

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for default encryption scope & block encryption scope override for blob container APIs. #8595

Add support for default encryption scope & block encryption scope override for blob container APIs. #8595

tonykjose commented Mar 4, 2020 •

edited

Loading

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

azuresdkci commented Mar 4, 2020

qianwens Mar 9, 2020 •

edited

Loading

tonykjose Mar 18, 2020

qianwens commented Mar 10, 2020

azure-pipelines bot commented Mar 18, 2020

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

anthony-c-martin Mar 20, 2020

blueww Mar 26, 2020

PhoenixHe-NV commented Mar 25, 2020

azure-pipelines bot commented Mar 25, 2020

qianwens commented Mar 25, 2020

qianwens commented Mar 25, 2020

blueww commented Mar 26, 2020 •

edited

Loading

Add support for default encryption scope & block encryption scope override for blob container APIs. #8595

Add support for default encryption scope & block encryption scope override for blob container APIs. #8595

Conversation

tonykjose commented Mar 4, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

openapi-sdkautomation bot commented Mar 4, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Mar 4, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 4, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Mar 4, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Mar 4, 2020 • edited Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

azuresdkci commented Mar 4, 2020

qianwens Mar 9, 2020 • edited Loading

Choose a reason for hiding this comment

tonykjose Mar 18, 2020

Choose a reason for hiding this comment

qianwens commented Mar 10, 2020

azure-pipelines bot commented Mar 18, 2020

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-cli-extensions - Release

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

anthony-c-martin Mar 20, 2020

Choose a reason for hiding this comment

blueww Mar 26, 2020

Choose a reason for hiding this comment

PhoenixHe-NV commented Mar 25, 2020

azure-pipelines bot commented Mar 25, 2020

qianwens commented Mar 25, 2020

qianwens commented Mar 25, 2020

blueww commented Mar 26, 2020 • edited Loading

tonykjose commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

qianwens Mar 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

blueww commented Mar 26, 2020 •

edited

Loading