Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flowLog to NetworkWatcher swagger + examples #8025

Merged
merged 3 commits into from
Jan 15, 2020
Merged

Added flowLog to NetworkWatcher swagger + examples #8025

merged 3 commits into from
Jan 15, 2020

Conversation

irrogozh
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azuresdkci azuresdkci requested a review from lirenhe December 24, 2019 01:19
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 25, 2019
@ryansbenson ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 3, 2020
ryansbenson
ryansbenson reviewed Jan 3, 2020
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change.

specification/network/resource-manager/Microsoft.Network/stable/2019-11-01/networkWatcher.json Show resolved Hide resolved
specification/network/resource-manager/Microsoft.Network/stable/2019-11-01/networkWatcher.json Outdated Show resolved Hide resolved
@sanjaiganesh
Copy link
Contributor

@irrogozh please address the comments.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@anton-evseev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 9, 2020
ryansbenson
ryansbenson reviewed Jan 9, 2020
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@lirenhe
Copy link
Member

lirenhe commented Jan 10, 2020

@irrogozh, could you take a look at the network validation issue?
Is it the same root cause of #8042

@irrogozh
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8025 in repo Azure/azure-rest-api-specs

@anton-evseev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@anton-evseev
Copy link
Contributor

@lirenhe this PR is good to go

@MikhailTryakhov
Copy link
Contributor

@lirenhe can you please help to merge this change?

@lirenhe lirenhe merged commit cc922ad into Azure:network-december-release Jan 15, 2020
akning-ms pushed a commit that referenced this pull request Jan 15, 2020
@anton-evseev @solhaile
@v-shhatt @ssripadham @ninweninwe @iatodoro @irrogozh @damendo @amwate @abjai @mancgupta @akning-ms
Network December release (#8163)
5f99752 
* Adds base for updating Microsoft.Network from version stable/2019-09-01 to version 2019-11-01

* Updates readme

* Updates API version in new specs and examples

* Add missing spec reference in readme.md (#7726)

* added username (#7779)

* adding alisas to code owners file (#7786)

* Committing changes to Fix Swagger descriptions to use "Reference to" … (#7787)

* Committing changes to Fix Swagger descriptions to use "Reference to" instead of "Reference of"

* upgrade rest-api-specs-scripts version (#7712)

* bump avocado version to support $(this-folder) (#7743)

* regenerate package-lock.json (#7756)

* Committing changes with formatted descriptions

* Committing changes to remove verbs from Swagger descriptions (#7788)

* Committing changes to remove verbs from Swagger descriptions

* upgrade rest-api-specs-scripts version (#7712)

* bump avocado version to support $(this-folder) (#7743)

* regenerate package-lock.json (#7756)

* Committing changes as per review comments

* committing changes to fix java sdk timeout issue (#7802)

* IpGroups reference in AzureFirewall (#7807)

* IpGroups reference in AzureFirewall

* Fixed examples

* Committing changes to remove verbs from Swagger descriptions (#7788)

* Committing changes to remove verbs from Swagger descriptions

* upgrade rest-api-specs-scripts version (#7712)

* bump avocado version to support $(this-folder) (#7743)

* regenerate package-lock.json (#7756)

* Committing changes as per review comments

* committing changes to fix java sdk timeout issue (#7802)

* IpGroups reference in AzureFirewall

* Fixed examples

* prettier fix

* prettier  --write

* virtual wan/gateway disconnect vpn connections (#7747)

* virtual wan/gateway disconnect vpn connections

* fix the PR comments

* fix the PR

* upgrade rest-api-specs-scripts version (#7712)

* bump avocado version to support $(this-folder) (#7743)

* regenerate package-lock.json (#7756)

* fix build error

* match class name with p2svpnconnectionrequest in nrp

* address the PR comments

* address the PR comments

* Prettify Network examples

* fix format of json

* Adding management IP configuration for Azure Firewall (#7851)

* Adding management IP configuration to firewall

* Changing description wording back

* Adding type property to AzureFirewallIpConfiguration

* Bumping API version in example files

* Fixing style issues

* Missed period at end of description

* Added connection monitor to networkWatcher swagger (#7881)

* Added connection monitor to networkWatcher swagger

* Added tests for connection monitor

* Added NetworkWatcherConnectionMonitorUpdateTags test

* Removed reference on connectionMOnitorV1 in readme.md

* Suppressed DefinitionsPropertiesNamesCamelCase error

* Fixed warnings and added example cor connectionMonitorV2 creation

* Fixed formatting in NetworkWatcherConnectionMonitorV2Create test

* Added connectionMonitorType property to connectionMonitorResult

* Fixed networkWatcher swagger based on CR. Run prettier check

* Minor changes

* Run prettier check for networkWatcher

* Adding note about API (#8104)

being in Preview

* Reverted express route changes brought in by a44f306#diff-2f0aa6e57d2b97956e1fb54558cf4cdeR1714

* Reverted changes made by commit a44f306#diff-2f0aa6e57d2b97956e1fb54558cf4cdeR1714

* Adding the structure of urlConfiguration in rewriteRuleActionSet (#7905)

* Url Configuration swagger changes for Url Rewrite feature of Application Gateway

* prettier fix

* DDOS protected IP flag for public IP (#8042)

* DDOS protected IP flag for public IP

* Protected IP property in ddos setting

* fixing build errors

* Retriggering the build

* Added flowLog to NetworkWatcher swagger + examples (#8025)

* Added flowLog ro NetworkWatcher swagger + examples

* Cleaned up required properties for trafficAnalytics flow log

* Fixes based on CR

Co-authored-by: solhaile <[email protected]>
Co-authored-by: Ranjani Hatti <[email protected]>
Co-authored-by: ssripadham <[email protected]>
Co-authored-by: Ning Wei <[email protected]>
Co-authored-by: iatodoro <[email protected]>
Co-authored-by: irrogozh <[email protected]>
Co-authored-by: Dalan Mendonca <[email protected]>
Co-authored-by: amwate <[email protected]>
Co-authored-by: Abhinav Jain <[email protected]>
Co-authored-by: manchit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansbenson ryansbenson ryansbenson left review comments

@lirenhe lirenhe lirenhe approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

@anton-evseev anton-evseev Awaiting requested review from anton-evseev

@v-shhatt v-shhatt Awaiting requested review from v-shhatt

Assignees

@lirenhe lirenhe

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@irrogozh @azuresdkci @sanjaiganesh @anton-evseev @lirenhe @MikhailTryakhov @ryansbenson