added username #7779
Merged
added username #7779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
anton-evseev
approved these changes
Nov 13, 2019
|
Can one of the admins verify this patch? |
|
@solhaile is going to be working with me on maintaining Network specs so please add him as code owner |
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
ChenTanyi
approved these changes
Nov 14, 2019
akning-ms
pushed a commit
that referenced
this pull request
Jan 15, 2020
* Adds base for updating Microsoft.Network from version stable/2019-09-01 to version 2019-11-01 * Updates readme * Updates API version in new specs and examples * Add missing spec reference in readme.md (#7726) * added username (#7779) * adding alisas to code owners file (#7786) * Committing changes to Fix Swagger descriptions to use "Reference to" … (#7787) * Committing changes to Fix Swagger descriptions to use "Reference to" instead of "Reference of" * upgrade rest-api-specs-scripts version (#7712) * bump avocado version to support $(this-folder) (#7743) * regenerate package-lock.json (#7756) * Committing changes with formatted descriptions * Committing changes to remove verbs from Swagger descriptions (#7788) * Committing changes to remove verbs from Swagger descriptions * upgrade rest-api-specs-scripts version (#7712) * bump avocado version to support $(this-folder) (#7743) * regenerate package-lock.json (#7756) * Committing changes as per review comments * committing changes to fix java sdk timeout issue (#7802) * IpGroups reference in AzureFirewall (#7807) * IpGroups reference in AzureFirewall * Fixed examples * Committing changes to remove verbs from Swagger descriptions (#7788) * Committing changes to remove verbs from Swagger descriptions * upgrade rest-api-specs-scripts version (#7712) * bump avocado version to support $(this-folder) (#7743) * regenerate package-lock.json (#7756) * Committing changes as per review comments * committing changes to fix java sdk timeout issue (#7802) * IpGroups reference in AzureFirewall * Fixed examples * prettier fix * prettier --write * virtual wan/gateway disconnect vpn connections (#7747) * virtual wan/gateway disconnect vpn connections * fix the PR comments * fix the PR * upgrade rest-api-specs-scripts version (#7712) * bump avocado version to support $(this-folder) (#7743) * regenerate package-lock.json (#7756) * fix build error * match class name with p2svpnconnectionrequest in nrp * address the PR comments * address the PR comments * Prettify Network examples * fix format of json * Adding management IP configuration for Azure Firewall (#7851) * Adding management IP configuration to firewall * Changing description wording back * Adding type property to AzureFirewallIpConfiguration * Bumping API version in example files * Fixing style issues * Missed period at end of description * Added connection monitor to networkWatcher swagger (#7881) * Added connection monitor to networkWatcher swagger * Added tests for connection monitor * Added NetworkWatcherConnectionMonitorUpdateTags test * Removed reference on connectionMOnitorV1 in readme.md * Suppressed DefinitionsPropertiesNamesCamelCase error * Fixed warnings and added example cor connectionMonitorV2 creation * Fixed formatting in NetworkWatcherConnectionMonitorV2Create test * Added connectionMonitorType property to connectionMonitorResult * Fixed networkWatcher swagger based on CR. Run prettier check * Minor changes * Run prettier check for networkWatcher * Adding note about API (#8104) being in Preview * Reverted express route changes brought in by a44f306#diff-2f0aa6e57d2b97956e1fb54558cf4cdeR1714 * Reverted changes made by commit a44f306#diff-2f0aa6e57d2b97956e1fb54558cf4cdeR1714 * Adding the structure of urlConfiguration in rewriteRuleActionSet (#7905) * Url Configuration swagger changes for Url Rewrite feature of Application Gateway * prettier fix * DDOS protected IP flag for public IP (#8042) * DDOS protected IP flag for public IP * Protected IP property in ddos setting * fixing build errors * Retriggering the build * Added flowLog to NetworkWatcher swagger + examples (#8025) * Added flowLog ro NetworkWatcher swagger + examples * Cleaned up required properties for trafficAnalytics flow log * Fixes based on CR Co-authored-by: solhaile <[email protected]> Co-authored-by: Ranjani Hatti <[email protected]> Co-authored-by: ssripadham <[email protected]> Co-authored-by: Ning Wei <[email protected]> Co-authored-by: iatodoro <[email protected]> Co-authored-by: irrogozh <[email protected]> Co-authored-by: Dalan Mendonca <[email protected]> Co-authored-by: amwate <[email protected]> Co-authored-by: Abhinav Jain <[email protected]> Co-authored-by: manchit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.