Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Network release branch with master #7764

Closed
wants to merge 31 commits into from

Conversation

anton-evseev
Copy link
Contributor

Need to get fix for CI into Network branch (for #7747 )

tfitzmac and others added 24 commits November 7, 2019 09:25
#7377)

* AdministratorName parameter should take constant value defined in enum

* Code review fixes

* Code review fixes

* Fix tabs and spaces

* Fix example with get

* revert example with get

* Fix examples
* addtdebyokapiswaggers

* add inaccessible database and inaccessible managed database swaggers and examples

* fix ci error

* add all files

* fix MA

* 1

* fix some example error

* update readme.md

* modify readme.md

* fix avacado

* fix avacado 2

* addtdebyokapiswaggers

* add inaccessible database and inaccessible managed database swaggers and examples

* fix ci error

* add all files

* fix MA

* 1

* fix some example error

* update readme.md

* modify readme.md

* fix avacado

* fix avacado 2

* fix prettier
* Update databaseVulnerabilityAssessments.json

Updated storageContainerSasKey explaining that both read and write access is required in the SAS token.

* Fixed documentation for storageAccountAccessKey parameter in SQL templates
* adding base examples and swagger files for undocumented api versions

* update api version in example files to match swagger spec

* update indentation to 2 instead of 4

* add new api versions to readme file

* correct reference to 2014 api version

* ran prettier on all example files
* First commit for new version folder with old files
Please diff later commits with this one for the changes.

* Update version.
Add Jit requests.
Try fix Model validation.

* Update operation Id

* Operations read, refresh permission, PR comments.

* Application definition artifact.

* Fix build

* Fix build

* Jit Patch

* Post async 202

* Fix example model valiation.

* Fix PR comments.
Remove update access since it should be internal only(used by PIM team)

* Capitalization to fix build.

* Read only properties

* Removed application definition artifact, which is internal and don't need a swagger.
* Copy 2018-07-01-preview to 2019-07-01

* Update spec and examples

* Change rg name in examples

* Fix readme path
@AutorestCI
Copy link

AutorestCI commented Nov 12, 2019

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • keyvault/resource-manager
  • cognitiveservices/data-plane/QnAMaker
  • compute/resource-manager
  • storage/resource-manager
  • timeseriesinsights/data-plane
  • network/resource-manager
  • migrate/resource-manager
  • cdn/resource-manager
  • batch/resource-manager
  • azsadmin/resource-manager/storage/Microsoft.Storage.Admin
  • signalr/resource-manager
  • sql/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • azure-kusto/resource-manager
  • hybridcompute/resource-manager
  • hanaonazure/resource-manager
  • serialconsole/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service
  • appconfiguration/resource-manager
  • machinelearning/resource-manager
  • netapp/resource-manager
  • cosmos-db/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Data
  • security/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service/track1
  • resources/resource-manager
  • policyinsights/resource-manager

@AutorestCI
Copy link

AutorestCI commented Nov 12, 2019

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • hanaonazure/resource-manager
  • cdn/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • timeseriesinsights/data-plane
  • network/resource-manager
  • compute/resource-manager
  • migrate/resource-manager
  • sql/resource-manager
  • storage/resource-manager
  • azsadmin/resource-manager/storage/Microsoft.Storage.Admin
  • cosmos-db/resource-manager
  • hybridcompute/resource-manager
  • keyvault/resource-manager
  • netapp/resource-manager
  • resources/resource-manager
  • cognitiveservices/data-plane/QnAMaker
  • security/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Data
  • search/data-plane/Microsoft.Azure.Search.Service/track1
  • machinelearning/resource-manager
  • serialconsole/resource-manager
  • signalr/resource-manager
  • batch/resource-manager
  • policyinsights/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service
  • azure-kusto/resource-manager
  • appconfiguration/resource-manager

…gers (#7734)

* Remove from 'track2' copy the swagger for 2019-05-06-Preview

* Remove from 'track2' copy the swagger for 2019-05-06-Preview for the service swagger
* Remove references to CosmosDB and make data source type a generated enum

* Remove named entity skill and associated models

* Expand the list of EntityRecognitionSkillLanguage

* Trial using opt-in-extensible-enums

* Use extensible enum for language

* Use extensible enum for TokenizerName

* Use extensible enum for TokenFilterName

* Use extensible enum for CharFilterName

* Use extensible enum for RegexFlags

* Fix missing bool setting

* Remove RegexFlags

* Add description for language properties

* Add URL to description

* Apply x-ms-enum fixes to 2019-05-06 'track2' swagger

* Fix model validation spelling errors

* Actually fix model validation spelling errors via custom-words.txt

* Opt-in extensible enums globally

* Model failing validation enums as string (still customized in SDK side)

* Remove the example in swagger specs that cause validation error for data sources

* Remove NamedEntityRecognitionSkill from the yet to ship 'track2' SDK version of swagger

* Fix swapping of name and description
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@brjohnstmsft brjohnstmsft removed their request for review November 12, 2019 19:57
@anton-evseev
Copy link
Contributor Author

@yungezz @lirenhe please take a look
cc: @v-shhatt @solhaile

@anton-evseev
Copy link
Contributor Author

ModelValidation errors are from other RP specs

rokulka and others added 3 commits November 12, 2019 15:11
* [QnA Maker] Update API data fields.

* camel casing
* Added enableCustomerAnalytics Flag to create SapMonitor

* Added the new flag to the correct file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.