New swagger for 2019-08-01 API #7660

leonardbf · 2019-10-29T08:48:29Z

For R6 release of RP with new API 2019-08-01
First commit contains previous 2019-07-01 as 2019-08-01.
Amendments to 08 baseline version

corrections to dates
R6 specific alterations (properties for volume replication)
Improve examples
Address noun-verb comment from previous PR New API version 2019-07-01 for ANF #7020
includes some minor textual corrections and amendments to older APIs.
update for comment on raw tag type here The type of attribute tags for NetApp Account shouldn't be raw type interface{} #7447 (comment)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

For R6. Initial version, identical to 2019-07-01 as baseline.

For R6 Amendments to 08 baseline version - corrections to dates - R6 specific alterations

Improve examples

ANF-327 New swagger for 2019-08-01 API

openapi-sdkautomation · 2019-10-29T08:48:33Z

In Testing, Please Ignore

[Logs] (Generated from 3f16eea, Iteration 11)

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-netapp [Logs] [Instructions] [Generation PR]
- azure-mgmt-netapp-0.6.0.zip
- azure_mgmt_netapp-0.6.0-py2.py3-none-any.whl

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.NetApp [Logs] [Instructions]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-netapp [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

netapp/mgmt/2019-05-01 [Logs] [Instructions] [Generation PR]
- netapp.mgmt.2019-05-01.zip
netapp/mgmt/2019-06-01 [Logs] [Instructions] [Generation PR]
- netapp.mgmt.2019-06-01.zip
netapp/mgmt/2019-07-01 [Logs] [Instructions] [Generation PR]
- netapp.mgmt.2019-07-01.zip
netapp/mgmt/2019-08-01 [Logs] [Instructions] [Generation PR]
- netapp.mgmt.2019-08-01.zip
preview/netapp/mgmt/2017-08-15 [Logs]

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

netapp/resource-manager/v2017_08_15 [Logs]
netapp/resource-manager/v2019_05_01 [Logs]
netapp/resource-manager/v2019_06_01 [Logs]
netapp/resource-manager/v2019_08_01 [Logs]

AutorestCI · 2019-10-29T08:49:38Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6288

azuresdkci · 2019-10-29T09:26:48Z

Can one of the admins verify this patch?

leonardbf · 2019-10-29T11:05:56Z

Assistance required:

It seems prettify checks have been introduced/changed. It's not clear what the format error is. Running npm install as per the instructions here https://dev.azure.com/azure-sdk/public/_build/results?buildId=173322&view=logs&jobId=b56e9678-4dad-5642-289c-5530cc4dad11 gives "npm ERR! [email protected] postinstall: scripts/switch-to-preproduction.sh". Despite this, I can actually run 'prettier' locally, which does perform some reformatting of the jsons, however I suspect it is not seeing a correct config, because it still fails in this pipeline.
The breaking change here https://dev.azure.com/azure-sdk/public/_build/results?buildId=173321&view=logs&j=08b5038d-1e84-5877-88da-859df8312b69 is something that intermittently occurs when we push a new API even when no change has been made. It is always on the same location but does not always occur. It would be great to get some explanation.
Thanks.

jhendrixMSFT · 2019-10-29T17:32:09Z

@NullMDR are you the right person to help with these issues?

AutorestCI · 2019-10-30T09:59:46Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8488

leonardbf · 2019-10-30T10:46:32Z

@NullMDR are you the right person to help with these issues?

I see #7666 (comment) was produced and this resolves the problem I had running 'npm run prettier' locally. However the resulting json still fails the check when run in the pipeline. So while the first part of my first issue above is resolved the last part of the first issue and the second issue are still relevant.

PhoenixHe-NV · 2019-11-01T05:35:04Z

@leonardbf Please rebase on the latest master and run

npm install; npm run prettier -- --write "specification/netapp/**/*.json"

qiaozha · 2019-11-04T02:21:47Z

/azp run

azure-pipelines · 2019-11-04T02:22:06Z

Azure Pipelines successfully started running 2 pipeline(s).

qiaozha · 2019-11-04T06:10:02Z

@leonardbf @raych1 Currently, BreakingChange doesn't support to put "parameters" being parrellel to methods like "get", "put", "post". Because a method should be defined as an json object, but here parameters was defined as an array. which cause json parse error. For example, from line 70 at specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-05-01/netapp.json.
The reason why you don't change this part how this time the error come out was because Previously this file was forcely merged, but you've changed other part this time. The BreakingChange Tool will check the whole file and report it again.
This is an acknowledged bug for BreakingChange Tool and my suggestion is to move the "parameter" block into the methods separately like this example move "parameters" block at line 70 into "post" block at line 91.
Otherwise. you need to merge it forcely like previously. but in this way, before this error being fixed, each time you change this file, it will come out.
This kind of code style can be seen in several places.

leonardbf · 2019-11-04T15:25:44Z

@leonardbf @raych1 Currently, BreakingChange doesn't support to put "parameters" being parrellel to methods like "get", "put", "post". Because a method should be defined as an json object, but here parameters was defined as an array. which cause json parse error. For example, from line 70 at specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-05-01/netapp.json.
The reason why you don't change this part how this time the error come out was because Previously this file was forcely merged, but you've changed other part this time. The BreakingChange Tool will check the whole file and report it again.
This is an acknowledged bug for BreakingChange Tool and my suggestion is to move the "parameter" block into the methods separately like this example move "parameters" block at line 70 into "post" block at line 91.
Otherwise. you need to merge it forcely like previously. but in this way, before this error being fixed, each time you change this file, it will come out.
This kind of code style can be seen in several places.

Ok, thanks for the update. Since this has been pushed before with this present would it be acceptable to do so again? We would address this problem in our API 2019-10-01 which we expect to push at the end of November. The 2019-08-01 is needed for the RP that went to production last week.

specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-08-01/netapp.json

majastrz

I added a couple of questions. Can you take a look?

qiaozha · 2019-11-05T07:13:24Z

@leonardbf @raych1 Currently, BreakingChange doesn't support to put "parameters" being parrellel to methods like "get", "put", "post". Because a method should be defined as an json object, but here parameters was defined as an array. which cause json parse error. For example, from line 70 at specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-05-01/netapp.json.
The reason why you don't change this part how this time the error come out was because Previously this file was forcely merged, but you've changed other part this time. The BreakingChange Tool will check the whole file and report it again.
This is an acknowledged bug for BreakingChange Tool and my suggestion is to move the "parameter" block into the methods separately like this example move "parameters" block at line 70 into "post" block at line 91.
Otherwise. you need to merge it forcely like previously. but in this way, before this error being fixed, each time you change this file, it will come out.
This kind of code style can be seen in several places.

Ok, thanks for the update. Since this has been pushed before with this present would it be acceptable to do so again? We would address this problem in our API 2019-10-01 which we expect to push at the end of November. The 2019-08-01 is needed for the RP that went to production last week.

@yungezz Catherine, this PR BreakingChange error need to be force merged. Could you pls take a look into it? Thanks

yungezz · 2019-11-05T08:17:59Z

@leonardbf @raych1 Currently, BreakingChange doesn't support to put "parameters" being parrellel to methods like "get", "put", "post". Because a method should be defined as an json object, but here parameters was defined as an array. which cause json parse error. For example, from line 70 at specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-05-01/netapp.json.
The reason why you don't change this part how this time the error come out was because Previously this file was forcely merged, but you've changed other part this time. The BreakingChange Tool will check the whole file and report it again.
This is an acknowledged bug for BreakingChange Tool and my suggestion is to move the "parameter" block into the methods separately like this example move "parameters" block at line 70 into "post" block at line 91.
Otherwise. you need to merge it forcely like previously. but in this way, before this error being fixed, each time you change this file, it will come out.
This kind of code style can be seen in several places.
Ok, thanks for the update. Since this has been pushed before with this present would it be acceptable to do so again? We would address this problem in our API 2019-10-01 which we expect to push at the end of November. The 2019-08-01 is needed for the RP that went to production last week.

@yungezz Catherine, this PR BreakingChange error need to be force merged. Could you pls take a look into it? Thanks

got it. once ARM review signed off, I can do merge.

leonardbf · 2019-11-05T14:53:16Z

I added a couple of questions. Can you take a look?

@majastrz I responded to the questions and hope this can be signed off soon. Thanks.

majastrz

Looks good from ARM side.

jhendrixMSFT · 2019-11-06T00:30:34Z

@leonardbf just to confirm, this API version is now live?

leonardbf · 2019-11-06T08:16:12Z

@leonardbf just to confirm, this API version is now live?

Yep, this went live last week.

qiaozha · 2019-11-07T01:41:23Z

/azp run

qiaozha · 2019-11-07T07:18:40Z

/azp run

leonardbf and others added 4 commits October 25, 2019 16:23

ANF-327 New swagger for 2019-08-01 API

cd1b5c9

For R6. Initial version, identical to 2019-07-01 as baseline.

ANF-327 New swagger for 2019-08-01 API

6998394

For R6 Amendments to 08 baseline version - corrections to dates - R6 specific alterations

ANF-327 Update for 2019-08-01 API

ac7fa45

Improve examples

Merge pull request #33 from leonardbf/ANF-327-2019-08-01

ef62b52

ANF-327 New swagger for 2019-08-01 API

azuresdkci assigned jhendrixMSFT Oct 29, 2019

azuresdkci requested a review from jhendrixMSFT October 29, 2019 08:49

This was referenced Oct 29, 2019

[AutoPR azure-mgmt-netapp] New swagger for 2019-08-01 API AzureSDKAutomation/azure-sdk-for-python#52

Open

[AutoPR Microsoft.Azure.Management.NetApp] New swagger for 2019-08-01 API test-repo-billy/azure-sdk-for-net#495

Closed

leonardbf added 2 commits October 29, 2019 09:36

Update netapp.json

b2eb829

Update netapp.json

00499ea

AutorestCI mentioned this pull request Oct 29, 2019

[AutoPR netapp/resource-manager] New swagger for 2019-08-01 API Azure/azure-sdk-for-go#6180

Closed

leonardbf added 5 commits October 29, 2019 10:19

Prettify

0dc1a98

Prettify

907c3f1

Prettify

0a76e2a

Prettify

da4d2e8

Spell Check

ec4f50b

openapi-sdkautomation bot mentioned this pull request Oct 29, 2019

[AutoPR netapp/resource-manager/v2017_08_15] New swagger for 2019-08-01 API test-repo-billy/azure-sdk-for-java#927

Closed

leonardbf added 2 commits October 29, 2019 13:01

Prettier

be252a3

Prettier

3f16eea

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 29, 2019

PhoenixHe-NV mentioned this pull request Oct 30, 2019

Fix scripts/switch-to-preproduction #7666

Merged

5 tasks

Typo correction (re-trigger test)

781dcea

majastrz reviewed Nov 4, 2019

View reviewed changes

specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-08-01/netapp.json Show resolved Hide resolved

majastrz reviewed Nov 4, 2019

View reviewed changes

specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-08-01/netapp.json Show resolved Hide resolved

majastrz reviewed Nov 4, 2019

View reviewed changes

specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-08-01/netapp.json Show resolved Hide resolved

majastrz added the ARMReviewInProgress label Nov 4, 2019

majastrz reviewed Nov 4, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 5, 2019

majastrz approved these changes Nov 5, 2019

View reviewed changes

jhendrixMSFT approved these changes Nov 6, 2019

View reviewed changes

PhoenixHe-NV closed this Nov 7, 2019

PhoenixHe-NV reopened this Nov 7, 2019

This was referenced Nov 7, 2019

[AutoPR netapp/resource-manager] New swagger for 2019-08-01 API Azure/azure-sdk-for-python#8487

Merged

[AutoPR netapp/resource-manager] New swagger for 2019-08-01 API Azure/azure-sdk-for-go#6287

Merged

yungezz merged commit 80a458c into Azure:master Nov 7, 2019

This was referenced Nov 11, 2019

ANF-437 update for new API 2019-08-01 leonardbf/azure-sdk-for-net#17

Merged

Update for new API 2019-08-01 Azure/azure-sdk-for-net#8720

Merged

solhaile pushed a commit to solhaile/azure-rest-api-specs that referenced this pull request Nov 13, 2019

New swagger for 2019-08-01 API (Azure#7660)

6555831

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New swagger for 2019-08-01 API #7660

New swagger for 2019-08-01 API #7660

leonardbf commented Oct 29, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 29, 2019 •

edited

Loading

AutorestCI commented Oct 29, 2019 •

edited

Loading

azuresdkci commented Oct 29, 2019

leonardbf commented Oct 29, 2019 •

edited

Loading

jhendrixMSFT commented Oct 29, 2019

AutorestCI commented Oct 30, 2019 •

edited

Loading

leonardbf commented Oct 30, 2019 •

edited

Loading

PhoenixHe-NV commented Nov 1, 2019 •

edited

Loading

qiaozha commented Nov 4, 2019

azure-pipelines bot commented Nov 4, 2019

qiaozha commented Nov 4, 2019

leonardbf commented Nov 4, 2019

majastrz left a comment

qiaozha commented Nov 5, 2019

yungezz commented Nov 5, 2019

leonardbf commented Nov 5, 2019

majastrz left a comment

jhendrixMSFT commented Nov 6, 2019

leonardbf commented Nov 6, 2019

qiaozha commented Nov 7, 2019

qiaozha commented Nov 7, 2019

New swagger for 2019-08-01 API #7660

New swagger for 2019-08-01 API #7660

Conversation

leonardbf commented Oct 29, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Oct 29, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 3f16eea, Iteration 11)

AutorestCI commented Oct 29, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Oct 29, 2019

leonardbf commented Oct 29, 2019 • edited Loading

jhendrixMSFT commented Oct 29, 2019

AutorestCI commented Oct 30, 2019 • edited Loading

Automation for azure-sdk-for-python

leonardbf commented Oct 30, 2019 • edited Loading

PhoenixHe-NV commented Nov 1, 2019 • edited Loading

qiaozha commented Nov 4, 2019

azure-pipelines bot commented Nov 4, 2019

qiaozha commented Nov 4, 2019

leonardbf commented Nov 4, 2019

majastrz left a comment

Choose a reason for hiding this comment

qiaozha commented Nov 5, 2019

yungezz commented Nov 5, 2019

leonardbf commented Nov 5, 2019

majastrz left a comment

Choose a reason for hiding this comment

jhendrixMSFT commented Nov 6, 2019

leonardbf commented Nov 6, 2019

qiaozha commented Nov 7, 2019

qiaozha commented Nov 7, 2019

leonardbf commented Oct 29, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 29, 2019 •

edited

Loading

AutorestCI commented Oct 29, 2019 •

edited

Loading

leonardbf commented Oct 29, 2019 •

edited

Loading

AutorestCI commented Oct 30, 2019 •

edited

Loading

leonardbf commented Oct 30, 2019 •

edited

Loading

PhoenixHe-NV commented Nov 1, 2019 •

edited

Loading