Fix json format by prettier #7638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoenixHe-NV
requested review from
DavidLiCIG,
hyonholee,
jaredmoo,
kalyanaj,
kjeur,
MikhailTryakhov,
naveedaz,
anton-evseev,
samedder,
Tiano2017 and
yangyuan
as code owners
In Testing, Please Ignore[Logs] (Generated from 771a3b2, Iteration 2)
|
Automation for azure-sdk-for-goThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
|
Can one of the admins verify this patch? |
|
Initialization for #7637 |
This was referenced Oct 25, 2019
yungezz
reviewed
Oct 25, 2019
| "displayText": "alaska airlines", | ||
| "query": "alaska airlines", | ||
| "searchKind": "WebSearch" | ||
| }, | ||
| { | ||
| "_type": "SearchAction", | ||
| "url": "https:\/\/www.bing.com\/search?q=aol&FORM=USBAPI", | ||
| "url": "https://www.bing.com/search?q=aol&FORM=USBAPI", |
There was a problem hiding this comment.
so this will not impact doc generation, right?
There was a problem hiding this comment.
No it won't, as the semantic meaning of the string keeps unchanged.
There was a problem hiding this comment.
But is this what the service is returning, or is it changing what the actual response looks like?
There was a problem hiding this comment.
It will not change the response as it's the same string after parsing.
This was referenced Oct 25, 2019
Merged
Merged
|
hi @NullMDR is this PR ready to merge? |
|
@yungezz I'll generate again from the latest master, then it's ready. |
PhoenixHe-NV
force-pushed
the
tih-fix-prettier
branch
from
a71df15 to
771a3b2
Compare
|
@yungezz It's ready. |
This was referenced Oct 29, 2019
Merged
[AutoPR azure-mgmt-datashare] Fix json format by prettier
AzureSDKAutomation/azure-sdk-for-python#50
Open
yungezz
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.