-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prettier Config, Add Prettier Check to CI #7637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
Can one of the admins verify this patch? |
yungezz
approved these changes
Oct 25, 2019
PhoenixHe-NV
force-pushed
the
tih-prettier-plugin
branch
from
October 25, 2019 08:48
f6edf5e
to
6305f09
Compare
5 tasks
PhoenixHe-NV
force-pushed
the
tih-prettier-plugin
branch
from
October 25, 2019 09:05
6305f09
to
502d777
Compare
@yungezz When could we merge this PR? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
as long as CI pass, it's ok to merge |
@NullMDR Please make sure to add documentation on how to run this locally in the doc pages.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.