Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier Config, Add Prettier Check to CI #7637

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

PhoenixHe-NV
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Oct 25, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 25, 2019

In Testing, Please Ignore

[Logs] (Generated from 502d777, Iteration 4)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@PhoenixHe-NV
Copy link
Contributor Author

@arrownj

@PhoenixHe-NV
Copy link
Contributor Author

@yungezz When could we merge this PR?

@PhoenixHe-NV
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yungezz
Copy link
Member

yungezz commented Oct 29, 2019

as long as CI pass, it's ok to merge

@yungezz yungezz merged commit bff55c4 into Azure:master Oct 29, 2019
@bganapa
Copy link
Member

bganapa commented Oct 30, 2019

@NullMDR Please make sure to add documentation on how to run this locally in the doc pages..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants