Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Search] Introduce 2019-05-06-Preview swagger #7615

Merged
merged 8 commits into from
Oct 25, 2019

Conversation

arv100kri
Copy link
Member

@arv100kri arv100kri commented Oct 24, 2019

Introduce a "base" swagger file for the preview API version 2019-05-06-Preview
The swagger is not complete - this PR will allow us to iterate development on the swagger.

Key changes in this PR:

  1. Swagger files for Microsoft.Azure.Search.Data and Microsoft.Azure.Search.Service are added for both "track1" and "track2" (hence the duplicates)
  2. The swagger files include -

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 24, 2019

In Testing, Please Ignore

[Logs] (Generated from 98d3615, Iteration 5)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 24, 2019

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • search/data-plane/Microsoft.Azure.Search.Data
  • search/data-plane/Microsoft.Azure.Search.Data/track1
  • search/data-plane/Microsoft.Azure.Search.Service/track1
  • search/data-plane/Microsoft.Azure.Search.Service

Copy link
Contributor

@bleroy bleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one branding change.

@arv100kri arv100kri force-pushed the arv100kri/2019-05-06-preview branch from 4066598 to 98d3615 Compare October 24, 2019 22:17
@arv100kri arv100kri requested a review from bleroy October 24, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants