Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Search] Add missing $select parameter to List APIs #7371

Merged
merged 1 commit into from
Oct 1, 2019
Merged

[Azure Search] Add missing $select parameter to List APIs #7371

merged 1 commit into from
Oct 1, 2019

Conversation

brjohnstmsft
Copy link
Member

@brjohnstmsft brjohnstmsft commented Oct 1, 2019 •
edited
Loading

The Azure Search REST API has always supported $select across all List APIs, but we forgot to specify it in the Swagger spec for all but List Indexes.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

[Azure Search] Add missing $select parameter to List APIs
96c1d1d 
The Azure Search REST API has always supported $select across all List APIs,
but we forgot to specify it in the Swagger spec for all but List Indexes.
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 96c1d1d, Iteration 6)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Oct 1, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Oct 1, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci azuresdkci requested a review from sarangan12 October 1, 2019 00:14
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@brjohnstmsft
Copy link
Member Author

brjohnstmsft commented Oct 1, 2019 •
edited
Loading

The model validation errors are due to a known issue. See the discussion in this PR for context: #6934

@sarangan12 sarangan12 merged commit 12cfa96 into Azure:master Oct 1, 2019
@brjohnstmsft brjohnstmsft deleted the search-select-fix branch October 1, 2019 18:29
@arv100kri arv100kri mentioned this pull request Oct 11, 2019
Merged
5 tasks
arv100kri pushed a commit to arv100kri/azure-rest-api-specs that referenced this pull request Oct 12, 2019
Revert [Azure Search] Add missing $select parameter to List APIs Azur…
e396d54 
…e#7371
sarangan12 pushed a commit that referenced this pull request Oct 14, 2019
@arv100kri @sarangan12
[Azure Search] Carve out a swagger spec for exclusive use by Track 1 …
dc2bf3c 
….NET SDK (#7468)

* Update the readme.md for code generation

* Carve out track 1 copy of 2019-05-06

* Revert [Azure Search] Add missing $select parameter to List APIs #7371

* Better formatting
@arv100kri arv100kri mentioned this pull request Oct 24, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarangan12 sarangan12 sarangan12 approved these changes

Assignees

@sarangan12 sarangan12

Labels
potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brjohnstmsft @AutorestCI @azuresdkci @sarangan12