Microsoft.StorageSync 2019-06-01 API version #7337

anpint · 2019-09-26T20:44:49Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…-03-01 to version 2019-06-01

…status (#7161) * introduce cloud tiering and recall status * fix validation errors * Additional validation fixes

openapi-sdkautomation · 2019-09-26T20:44:52Z

In Testing, Please Ignore

[Logs] (Generated from d1b1885, Iteration 7)

.NET: test-repo-billy/azure-sdk-for-net [Logs]

No packages generated.

Python: test-repo-billy/azure-sdk-for-python [Logs]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs]

Package generation in progress.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

No packages generated.

AutorestCI · 2019-09-26T20:45:48Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#7846

AutorestCI · 2019-09-26T20:47:21Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

azuresdkci · 2019-09-26T21:00:28Z

Can one of the admins verify this patch?

anpint · 2019-09-30T22:05:46Z

@Juliehzl, for your information, this PR contains the 2019-06-01 API version swagger generated through the OpenAPIHub, and updated with the changes that have been already approved in: #7161.

ryansbenson · 2019-10-02T19:55:27Z

specification/storagesync/resource-manager/readme.md

@@ -26,18 +26,27 @@ These are the global settings for the Storage Sync API.

 ``` yaml
 openapi-type: arm
-tag: package-2019-03-01
+tag: package-2019-06


shouldn't this be 2019-06-01?

Thanks for pointing it out @ryansbenson
I'll fix it.

@Juliehzl please approve the following PR:
#7413

Looks like I don't have permission to push to this branch, so I had to create a PR to fix the issue in the readme file.

This is not fixed yet.

I don't have permissions to push to this branch, so the fixes are going to this PR:
#7413

ryansbenson · 2019-10-02T19:59:40Z

Approved from ARMs side.

SDK - Please review the readme change.

yungezz · 2019-10-08T03:25:07Z

hi @Juliehzl is the PR ok to merge?

anpint · 2019-10-11T18:30:33Z

@yungezz It looks like @Juliehzl has been unresponsive for many days now. Are you able to help completing the PR?

sergey-shandar · 2019-10-11T20:04:26Z

specification/storagesync/resource-manager/readme.md

 ### Tag: package-2019-03-01

 These settings apply only when `--tag=package-2019-03-01` is specified on the command line.

-```yaml $(tag) == 'package-2019-03-01'
+``` yaml $(tag) == 'package-2019-03-01'


No need to add a space.

I didn't modify this myself (likely code generation made the changes). I can fix it anyways.

sergey-shandar · 2019-10-11T20:05:47Z

specification/storagesync/resource-manager/readme.md

@@ -155,7 +164,7 @@ See configuration in [readme.go.md](./readme.go.md)

 See configuration in [readme.java.md](./readme.java.md)

-## Multi-API/Profile support for AutoRest v3 generators 
+## Multi-API/Profile support for AutoRest v3 generators

 AutoRest V3 generators require the use of `--tag=all-api-versions` to select api files.



IMHO, the multiapi profile should also have the new version.

Good point. However, I see that the there is some text there that reads: "This block is updated by an automatic script. Edits may be lost!", so I feel maybe it should have been automatically updated. I'll add the new version there anyways.

sergey-shandar · 2019-10-11T20:06:08Z

specification/storagesync/resource-manager/readme.md

@@ -26,18 +26,27 @@ These are the global settings for the Storage Sync API.

 ``` yaml
 openapi-type: arm
-tag: package-2019-03-01
+tag: package-2019-06


This is not fixed yet.

) * Fix tag for 2019-06-01 version in readme.md * Remove uneeded spaces and add new version to Multi-API

anpint added 4 commits September 9, 2019 14:21

Adds base for updating Microsoft.StorageSync from version stable/2019…

f23380e

…-03-01 to version 2019-06-01

Updates readme

890631e

Updates API version in new specs and examples

a2749ee

Update StorageSync 2019-06-01 protocol with cloud tiering and recall …

565b2be

…status (#7161) * introduce cloud tiering and recall status * fix validation errors * Additional validation fixes

anpint requested a review from ankushbindlish2 as a code owner September 26, 2019 20:44

azuresdkci assigned Juliehzl Sep 26, 2019

azuresdkci requested a review from Juliehzl September 26, 2019 20:45

AutorestCI mentioned this pull request Sep 26, 2019

[AutoPR storagesync/resource-manager] Dev storagesync microsoft.storage sync 2019 06 01 Azure/azure-sdk-for-python#7454

Closed

anpint changed the title ~~Dev storagesync microsoft.storage sync 2019 06 01~~ Microsoft.StorageSync 2019-06-01 API version Sep 26, 2019

Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 29, 2019

ryansbenson reviewed Oct 2, 2019

View reviewed changes

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 2, 2019

sergey-shandar suggested changes Oct 11, 2019

View reviewed changes

sergey-shandar self-assigned this Oct 11, 2019

[Microsoft.StorageSync] Fix tags for 2019-06-01 version in readme (#7413

d1b1885

) * Fix tag for 2019-06-01 version in readme.md * Remove uneeded spaces and add new version to Multi-API

sergey-shandar approved these changes Oct 11, 2019

View reviewed changes

sergey-shandar merged commit 92a8868 into master Oct 11, 2019

AutorestCI mentioned this pull request Oct 11, 2019

[AutoPR storagesync/resource-manager] Microsoft.StorageSync 2019-06-01 API version Azure/azure-sdk-for-python#7846

Merged

anpint mentioned this pull request Nov 6, 2019

[Microsoft.StorageSync] Update SDK to use 2019-06-01 API version Azure/azure-sdk-for-net#8632

Merged

3 tasks

anpint deleted the dev-storagesync-Microsoft.StorageSync-2019-06-01 branch April 8, 2021 22:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsoft.StorageSync 2019-06-01 API version #7337

Microsoft.StorageSync 2019-06-01 API version #7337

anpint commented Sep 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 26, 2019 •

edited

Loading

AutorestCI commented Sep 26, 2019 •

edited

Loading

AutorestCI commented Sep 26, 2019 •

edited

Loading

azuresdkci commented Sep 26, 2019

anpint commented Sep 30, 2019

ryansbenson Oct 2, 2019

anpint Oct 4, 2019

anpint Oct 7, 2019

sergey-shandar Oct 11, 2019

anpint Oct 11, 2019

ryansbenson commented Oct 2, 2019

yungezz commented Oct 8, 2019

anpint commented Oct 11, 2019

sergey-shandar Oct 11, 2019

anpint Oct 11, 2019

sergey-shandar Oct 11, 2019

anpint Oct 11, 2019

sergey-shandar Oct 11, 2019

Microsoft.StorageSync 2019-06-01 API version #7337

Microsoft.StorageSync 2019-06-01 API version #7337

Conversation

anpint commented Sep 26, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Sep 26, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from d1b1885, Iteration 7)

AutorestCI commented Sep 26, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 26, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Sep 26, 2019

anpint commented Sep 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryansbenson commented Oct 2, 2019

yungezz commented Oct 8, 2019

anpint commented Oct 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anpint commented Sep 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 26, 2019 •

edited

Loading

AutorestCI commented Sep 26, 2019 •

edited

Loading

AutorestCI commented Sep 26, 2019 •

edited

Loading