Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StorageSync 2019-06-01 protocol with cloud tiering and recall status #7161

Conversation

anpint
Copy link
Member

@anpint anpint commented Sep 9, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Sep 9, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#7142

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 9, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@Juliehzl
Copy link
Contributor

Hi @anpint, can you try to make CI pass first?

@anpint
Copy link
Member Author

anpint commented Sep 13, 2019

Hi @anpint, can you try to make CI pass first?

@Juliehzl I've fixed the validation errors

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 13, 2019
@Juliehzl Juliehzl merged commit 565b2be into dev-storagesync-Microsoft.StorageSync-2019-06-01 Sep 15, 2019
sergey-shandar pushed a commit that referenced this pull request Oct 11, 2019
* Adds base for updating Microsoft.StorageSync from version stable/2019-03-01 to version 2019-06-01

* Updates readme

* Updates API version in new specs and examples

* Update StorageSync 2019-06-01 protocol with cloud tiering and recall status (#7161)

* introduce cloud tiering and recall status

* fix validation errors

* Additional validation fixes

* [Microsoft.StorageSync] Fix tags for 2019-06-01 version in readme (#7413)

* Fix tag for 2019-06-01 version in readme.md

* Remove uneeded spaces and add new version to Multi-API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants