Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the structure of urlConfiguration in rewriteRuleActionSet #7275

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Adding the structure of urlConfiguration in rewriteRuleActionSet #7275

merged 3 commits into from
Sep 25, 2019

Conversation

abjai
Copy link
Contributor

@abjai abjai commented Sep 20, 2019

Latest improvements:

These changes are already been approved in issue #7030 but could not be merged because of NRP release. These changes are targeted to merge in September milestone.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Sep 20, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp1osf7ccr/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp1osf7ccr/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[28267:0x27a0cc0]    69756 ms: Mark-sweep 1378.5 (1426.3) -> 1378.5 (1426.8) MB, 1413.9 / 0.0 ms  (average mu = 0.062, current mu = 0.001) allocation failure GC in old space requested
[28267:0x27a0cc0]    71175 ms: Mark-sweep 1379.2 (1426.8) -> 1379.1 (1427.3) MB, 1415.9 / 0.0 ms  (average mu = 0.033, current mu = 0.002) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x3e5d4015be1d]
Security context: 0x02988711e6e9 <JSObject>
    1: newScalar [0x31bd0d2901e9] [/node_modules/yaml-ast-parser/dist/src/yamlAST.js:~38] [pc=0x3e5d406a4a56](this=0x31bd0d297cb1 <Object map = 0x2725c52c4af1>,v=0x29e7beb026f1 <undefined>)
    2: arguments adaptor frame: 0->1
    3: readDoubleQuotedScalar(aka readDoubleQuotedScalar) [0x31bd0d298571] [/node_modules/yaml-ast-parser/dist/src/loader.js:~530] [p...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x3e5d4015be1d

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 20, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@anton-evseev
Copy link
Contributor

@KrisBash from ARM already reviewed these changes here: #7030

@anton-evseev anton-evseev added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 20, 2019
Copy link
Contributor

@anton-evseev anton-evseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a few nitpicks about descriptions

},
"modifiedQueryString": {
"type": "string",
"description": "It is the query string of url which user has provided for url rewrite. Null means no query string will be updated. Default value is null."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It is" is kind of redundand, most descriptions in spec start would start with "The query string..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved as per new commit

@anton-evseev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@anton-evseev
Copy link
Contributor

@sergey-shandar could you please review and merge?

@yungezz yungezz merged commit e89f35d into Azure:network-september-release Sep 25, 2019
sai-manoj-kumar added a commit that referenced this pull request Sep 26, 2019
yungezz pushed a commit that referenced this pull request Sep 27, 2019
sergey-shandar pushed a commit that referenced this pull request Oct 2, 2019
* Adds base for updating Microsoft.Network from version stable/2019-07-01 to version 2019-08-01

* Updates readme

* Updates API version in new specs and examples

* Add reference to Connection Monitor specs in 2019-08-01 (#7218)

* Support AH protocol (#7231)

* Virtual Network BGP Communities (#7248)

* Virtual Wan point to site feature redesign:- (#7238)

* Virtual Wan point to site feature redesign

* Fix examples

* Fix validation errors

* Fix validation error

* Fix validation errors

* Incorporate review comments

* Fix default error in standard error response

* Fix validation error

* Refer to default error from ddos swagger spec

* Fix build error

* Firewall Manager Feature Swagger Updates for Public Preview (#7266)

* Adding the structure of urlConfiguration in rewriteRuleActionSet (#7275)

* Revert "Adding the structure of urlConfiguration in rewriteRuleActionSet (#7275)" (#7333)

This reverts commit e89f35d.

* Virtual network gateway changes for dns forwarding (#7359)

* Virtuan network gateway changes for dns forwarding

* Fixed example response

* Fixed examples

* Fixed 201 example

* Top-level WAF (#7222)

* Move new props to the end to avoid breaking changes in SDK (#7387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants