Virtual Network BGP Communities

[jarango]

This pull request introduces a new property for the VirtualNetwork resource. The property is called "bgpCommunities". It defines a pair of communities that sent by the virtual network gateway with every prefix for this virtual network that is advertised over BGP to ExpressRoute devices.

The "VirtualNetworkCommunity" represents the community associated with the virtual network and is specified by the user via PUT operations. The "RegionalCommunity" represents the community associated with the region of the virtual network, and it is a read-only property.

The bgpCommunities is an optional property. If the user specifies it, then he/she must also specify the "VirtualNetworkCommunity" sub-property. The "RegionalCommunity" must not be specified by the user. It is set by NRP if and only if the bgpCommunities properties was specified by the user along with the "VirtualNetworkCommunity" sub-property.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[AutorestCI]

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmptuoh_whf/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmptuoh_whf/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[10324:0x4469cc0]    95794 ms: Mark-sweep 1383.5 (1428.8) -> 1383.5 (1429.3) MB, 2144.3 / 0.0 ms  (average mu = 0.154, current mu = 0.000) allocation failure GC in old space requested
[10324:0x4469cc0]    98086 ms: Mark-sweep 1383.6 (1429.3) -> 1383.6 (1429.8) MB, 2291.3 / 0.0 ms  (average mu = 0.080, current mu = 0.000) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x12200a15be1d]
Security context: 0x2c443281e6e9 <JSObject>
    1: readLineBreak(aka readLineBreak) [0x1ef6c8ae7a41] [/node_modules/yaml-ast-parser/dist/src/loader.js:~300] [pc=0x12200a90f858](this=0x13da775826f1 <undefined>,state=0x18bc1cea1e71 <State map = 0x356de8803b19>)
    2: readFlowCollection(aka readFlowCollection) [0x1ef6c8ae79d1] [/node_modules/yaml-ast-parser/dist/src/loader.js:~596] [pc=0x12200a909abb](t...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea0466 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [node]
11: 0xea0cea v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [node]
12: 0xea12a7 v8::internal::Factory::NewUninitializedFixedArray(int, v8::internal::PretenureFlag) [node]
13: 0xe5462f  [node]
14: 0x10fa57d v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [node]
15: 0x12200a15be1d

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[anton-evseev]

@majastrz please review this from ARM's side

[majastrz]

Looks good from ARM side.

[anton-evseev]

@sergey-shandar if everything's okay, could you please merge this PR?