Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBus: added NetworkRuleSets list API #7050

Merged
merged 4 commits into from
Sep 11, 2019
Merged

ServiceBus: added NetworkRuleSets list API #7050

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26fbb00
added NetworkRuleSets list API
Aug 27, 2019
87e0661
added x-ms-pageable and formating
Aug 28, 2019
e1ba230
Merge branch 'master' of https://github.com/Azure/azure-rest-api-spec…
Aug 29, 2019
2f83e3f
removed readonly for compatibilityLevel
Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions ...iceBus/stable/2017-04-01/examples/NameSpaces/VirtualNetworkRule/SBNetworkRuleSetList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
{
"parameters": {
"namespaceName": "sdk-Namespace-6019",
"resourceGroupName": "ResourceGroup",
"api-version": "2017-04-01",
"subscriptionId": "Subscription"
},
"responses": {
"200": {
"body": {
"value": [
{
"id": "/subscriptions/subscriptionid/resourceGroups/resourcegroupid/providers/Microsoft.ServiceBus/namespaces/sdk-Namespace-9659/networkrulesets/default",
"name": "default",
"type": "Microsoft.ServiceBus/Namespaces/NetworkRuleSet",
"properties": {
"defaultAction": "Deny",
"virtualNetworkRules": [
{
"subnet": {
"id": "/subscriptions/subscriptionid/resourcegroups/resourcegroupid/providers/Microsoft.Network/virtualNetworks/myvn/subnets/subnet2"
},
"ignoreMissingVnetServiceEndpoint": true
},
{
"subnet": {
"id": "/subscriptions/subscriptionid/resourcegroups/resourcegroupid/providers/Microsoft.Network/virtualNetworks/myvn/subnets/subnet3"
},
"ignoreMissingVnetServiceEndpoint": false
},
{
"subnet": {
"id": "/subscriptions/subscriptionid/resourcegroups/resourcegroupid/providers/Microsoft.Network/virtualNetworks/myvn/subnets/subnet6"
},
"ignoreMissingVnetServiceEndpoint": false
}
],
"ipRules": [
{
"ipMask": "1.1.1.1",
"action": "Allow"
},
{
"ipMask": "1.1.1.2",
"action": "Allow"
},
{
"ipMask": "1.1.1.3",
"action": "Allow"
},
{
"ipMask": "1.1.1.4",
"action": "Allow"
},
{
"ipMask": "1.1.1.5",
"action": "Allow"
}
]
}
}
]

}
}
}
}
61 changes: 61 additions & 0 deletions ...cation/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3212,6 +3212,51 @@
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/networkRuleSets": {
"get": {
"tags": [
"Namespaces"
],
"x-ms-examples": {
"NameSpaceNetworkRuleSetList": {
"$ref": "./examples/NameSpaces/VirtualNetworkRule/SBNetworkRuleSetList.json"
}
},
"operationId": "Namespaces_ListNetworkRuleSets",
"description": "Gets list of NetworkRuleSet for a Namespace.",
"parameters": [
{
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/NamespaceNameParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
}
],
"responses": {
"200": {
"description": "List of NetworkRuleSets for Namespace successfully returned.",
"schema": {
"$ref": "#/definitions/NetworkRuleSetListResult"
}
},
"default": {
"description": "ServiceBus error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add x-ms-pageable declaration to this API (see other places in this file for reference).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

},
"x-ms-pageable": {
"nextLinkName": "nextLink"
}
}
}
},
"definitions": {
Expand Down Expand Up @@ -4716,6 +4761,22 @@
}
],
"description": "Description of NetworkRuleSet resource."
},
"NetworkRuleSetListResult": {
"properties": {
"value": {
"type": "array",
"items": {
"$ref": "#/definitions/NetworkRuleSet"
},
"description": "Result of the List NetworkRuleSet operation."
},
"nextLink": {
"type": "string",
"description": "Link to the next set of results. Not empty if Value contains incomplete list of NetworkRuleSet."
}
},
"description": "The response of the List NetworkRuleSet operation."
}
},
"parameters": {
Expand Down