Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBus: added NetworkRuleSets list API #7050

Merged
merged 4 commits into from
Sep 11, 2019

Conversation

v-Ajnava
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@v-Ajnava v-Ajnava added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 27, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2019

In Testing, Please Ignore

[Logs] (Generated from 2f83e3f, Iteration 3)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
Pending Ruby: test-repo-billy/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Aug 27, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7200

@AutorestCI
Copy link

AutorestCI commented Aug 28, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5739

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 28, 2019
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add x-ms-pageable declaration to this API (see other places in this file for reference).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@v-Ajnava
Copy link
Member Author

@erich-wang, can you please review the PR. also suggest on the semantic validation 'message: 'ReadOnly property "compatibilityLevel": 20, cannot be sent in the request.'
'

@raych1
Copy link
Member

raych1 commented Aug 29, 2019

@v-Ajnava, I assume the parameter of SqlFilter should be a request parameter which cannot have a readonly property. The value of a readonly property is managed exclusively by the owning authority and cannot be supplied in request. reference

@erich-wang
Copy link
Member

@v-Ajnava, could you fix the semantic error as @raych1 commented?

1 similar comment
@erich-wang
Copy link
Member

@v-Ajnava, could you fix the semantic error as @raych1 commented?

@v-Ajnava
Copy link
Member Author

v-Ajnava commented Sep 9, 2019

@erich-wang, sorry for delay. right now, we want to restrict user input for 'compatibilityLevel' to 20 (if provided), so is it okay to, add minimum and maximum to 20 ? we have default set to 20. I will also discuss with team here.

@erich-wang
Copy link
Member

@v-Ajnava , using minimun and maximum LGTM.

@v-Ajnava
Copy link
Member Author

@erich-wang can you please review the changes. added minimum, maximum.

@erich-wang erich-wang merged commit 88c2c6e into Azure:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants