-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceBus: added NetworkRuleSets list API #7050
Conversation
In Testing, Please Ignore[Logs] (Generated from 2f83e3f, Iteration 3).NET: test-repo-billy/azure-sdk-for-net [Logs]
Python: test-repo-billy/azure-sdk-for-python [Logs]
Java: test-repo-billy/azure-sdk-for-java [Logs]
Go: test-repo-billy/azure-sdk-for-go [Logs]
JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
Ruby: test-repo-billy/azure-sdk-for-ruby
|
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
"schema": { | ||
"$ref": "#/definitions/ErrorResponse" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add x-ms-pageable
declaration to this API (see other places in this file for reference).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved
@erich-wang, can you please review the PR. also suggest on the semantic validation 'message: 'ReadOnly property |
@v-Ajnava, I assume the parameter of |
…into mastSBnetworkrulesets
1 similar comment
@erich-wang, sorry for delay. right now, we want to restrict user input for 'compatibilityLevel' to 20 (if provided), so is it okay to, add minimum and maximum to 20 ? we have default set to 20. I will also discuss with team here. |
@v-Ajnava , using minimun and maximum LGTM. |
@erich-wang can you please review the changes. added minimum, maximum. |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.