Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Stack] Mark the properties of Drive and Volume as readonly #6813

Merged
merged 1 commit into from
Aug 6, 2019
Merged

[Azure Stack] Mark the properties of Drive and Volume as readonly #6813

merged 1 commit into from
Aug 6, 2019

Conversation

zyxyoshine
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 31, 2019

In Testing, Please Ignore

[Logs] (Generated from ffb00f7, Iteration 1)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@zyxyoshine
Copy link
Contributor Author

@bganapa @deathly809 please help review.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyxyoshine , update property as required is breaking change. It would be better to have a new version of API.

@zyxyoshine
Copy link
Contributor Author

@raych1 Thanks, we have already added new version of API (#6666 ), and this PR is only for some additional changes.

@raych1
Copy link
Member

raych1 commented Aug 2, 2019

@bganapa, @deathly809, can you review? It looks good to me.

@raych1 raych1 merged commit 3ad5668 into Azure:master Aug 6, 2019
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
…zure#6813)

* Codespaces swagger updates - baseline

* Codespaces swagger updates, new 'networkSettings' resource definition'

* implemented PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants