Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Stack] Update Volume and Drive API for Fabric Admin #6666

Merged
merged 4 commits into from
Jul 22, 2019
Merged

[Azure Stack] Update Volume and Drive API for Fabric Admin #6666

merged 4 commits into from
Jul 22, 2019

Conversation

zyxyoshine
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 18, 2019

SDK Automation [Logs] (Generated from 71b4f6d, Iteration 4)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Jul 18, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jul 18, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jul 18, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@zyxyoshine
Copy link
Contributor Author

@bganapa Please help review.

@zyxyoshine zyxyoshine changed the title [ Azure Stack] Update Volume and Drive API for Fabric Admin [Azure Stack] Update Volume and Drive API for Fabric Admin Jul 18, 2019
@yaohaizh
Copy link
Contributor

yaohaizh commented Jul 18, 2019

@zyxyoshine For the new version changes, it better to provide two commits.

  1. First one just copy the content from the previous version
  2. The second should be new changes diff from the previous version for better pull review.
    Thanks.

@yaohaizh yaohaizh added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2019
@nschonni
Copy link
Contributor

You can add the missing word to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt so the spellcheck passes

@KrisBash KrisBash removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2019
@KrisBash
Copy link
Contributor

ARM doesn't typically review Azure Stack Fabric swaggers

@zyxyoshine
Copy link
Contributor Author

Thank you all, resolved comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants