Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing incorrectly formatted Cosmos DB list keys response #6587

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

shurd
Copy link
Contributor

@shurd shurd commented Jul 10, 2019

Addresses #3603

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 10, 2019

@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5933

@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5276

@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3409

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz
Copy link
Member

yungezz commented Jul 15, 2019

this is a breaking change which will cause breaking changes in SDKs. Just to double confirm, is this to fix a bug at Swagger file, or fixing swagger for service behavior change?

@shurd
Copy link
Contributor Author

shurd commented Jul 16, 2019

This is a bug in the Swagger file. The RP returns all 4 keys at the same level.

@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2019
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concern from ARM if this is fixing a bug in swagger

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 17, 2019
@yungezz yungezz merged commit 90fd5ec into Azure:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants