Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabaseAccountListKeysResult incorrectly models received response #3603

Closed
jhendrixMSFT opened this issue Aug 7, 2018 · 2 comments
Closed
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Cosmos Doc Db Service Attention Workflow: This issue is responsible by Azure service team.
Milestone

Comments

@jhendrixMSFT
Copy link
Member

Operation DatabaseAccounts_ListKeys returns a DatabaseAccountListKeysResult however this doesn't accurately model the response body.

{
  "primaryMasterKey": "xxx",
  "secondaryMasterKey": "xxx",
  "primaryReadonlyMasterKey": "xxx",
  "secondaryReadonlyMasterKey": "xxx"
}

Note the missing properties object for the read-only keys. I suspect the confusion comes from the x-ms-client-flatten setting; this is purely an SDK convenience mechanism and does not participate in modeling payloads. The swagger needs to be updated as now there is no way to retrieve the read-only keys.

@shurd
Copy link
Contributor

shurd commented Jul 10, 2019

Thank you for identifying this model error in the swagger. We will make the needed correction for the account keys response. We are tracking this internally as work item 469202. ETA for the update is August 2019.

@shurd shurd self-assigned this Jul 10, 2019
@shurd shurd added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jul 10, 2019
@shurd shurd added this to the Sprint 157 milestone Jul 10, 2019
@shurd
Copy link
Contributor

shurd commented Jul 22, 2019

The change has been merged so the swagger correctly models the response when listing keys.

@shurd shurd closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Cosmos Doc Db Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

4 participants