Azure Network August release #3635

MikhailTryakhov · 2018-08-14T12:56:52Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

Merged Network-August-Release branch to master

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

* Created folder for 2018-07-01 api version * fixed incorrect encoding symbol

Lint diff was failing on PRs with a base branch other than master. We needed to fetch the base branch ref from the origin before trying to resolve it to its commit hash.

…lease

* Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples

* Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma

* Service Endpoint Policies Swagger * Fix review comments

* Add enableTcpReset property to load balancer. * Update loadbalancer examples with enableTcpReset.

…lease

* Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update

* Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties

AutorestCI · 2018-08-14T13:04:37Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1571

AutorestCI · 2018-08-14T13:08:41Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3136

azuresdkci · 2018-08-14T13:15:00Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-14T13:21:11Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3335

AutorestCI · 2018-08-14T13:27:06Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2476

AutorestCI · 2018-08-14T13:28:21Z

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2322

jianghaolu · 2018-08-14T18:36:35Z

.../Microsoft.Network/stable/2018-07-01/examples/VirtualNetworkGatewayConnectionUpdateTags.json

+          "virtualNetworkGateway1": {
+            "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworkGateways/vpngw"
+          },
+          "localNetworkGateway2": {


According to https://github.com/Azure/azure-rest-api-specs/pull/3635/files#diff-795d13db3a317a9440687541d8d00549R2545, properties property is required.

Known issue. Let's discuss with leads when to plan a fix. that shouldn't be a blocker for this PR

jianghaolu · 2018-08-14T18:37:18Z

.../Microsoft.Network/stable/2018-07-01/examples/VirtualNetworkGatewayConnectionUpdateTags.json

+          "provisioningState": "Succeeded",
+          "resourceGuid": "00000000-0000-0000-0000-000000000000",
+          "virtualNetworkGateway1": {
+            "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworkGateways/vpngw"


According to https://github.com/Azure/azure-rest-api-specs/pull/3635/files#diff-795d13db3a317a9440687541d8d00549R2545, properties property is required.

Description of Changes: - Added a flag expressRouteGatewayBypass to the Connection Properties. - The user can set the flag to True to use MSEEv2 datapath Related work items: #2628003

* Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example

MikhailTryakhov · 2018-08-16T07:49:41Z

@jianghaolu can you please merge it?

… while doing a put, get and delete (#3655)

* Add/Edit Outbound Rule on Load Balancer and Examples * Adding properties enabletcpreset, idletimeoutinminutes and protocol * Adding a reference to Public IP Prefix * Dummy Commit

* Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * removed QueryConnectionMonitors Api

…ng. (#3635) * Add cluster properties and support presto and kafka profiles. * Try to fix lint errors. Remove incorrect use of required prop. * Add regex pattern validation for stack version. * Remove scale profile, and remove max/min count options for compute profile.

MikhailTryakhov and others added 15 commits July 26, 2018 11:00

Created folder for 2018-07-01 api version (#3509)

b42dc7e

* Created folder for 2018-07-01 api version * fixed incorrect encoding symbol

Fix lint diff and improve output on failure (#3528)

a09c1b7

Lint diff was failing on PRs with a base branch other than master. We needed to fetch the base branch ref from the origin before trying to resolve it to its commit hash.

Python conf for Network 2018-06 (#3535)

526f843

Py conf for Network 2018-07-01 (#3539)

6eba83d

Merge remote-tracking branch 'upstream/master' into Network-August-Re…

7f44963

…lease

Service Endpoint Policies Swagger (#3558)

65683a8

* Service Endpoint Policies Swagger * Fix review comments

Updated Network Usage location parameter pattern (#3583)

984fe8d

Add enableTcpReset property to load balancer (#3545)

0dfdf47

* Add enableTcpReset property to load balancer. * Update loadbalancer examples with enableTcpReset.

added global reach flag (#3542)

fdef80e

Merge remote-tracking branch 'upstream/master' into Network-August-Re…

5f6d6d5

…lease

fix query packet capture status in latest version (#3601)

c1be2e6

azuresdkci assigned jianghaolu Aug 14, 2018

azuresdkci requested a review from jianghaolu August 14, 2018 12:58

AutorestCI mentioned this pull request Aug 14, 2018

[AutoPR network/resource-manager/compute/resource-manager] Azure Network August release Azure/azure-sdk-for-ruby#1571

Closed

AutorestCI mentioned this pull request Aug 14, 2018

[AutoPR network/resource-manager/compute/resource-manager] Azure Network August release Azure/azure-sdk-for-python#3136

Closed

AutorestCI mentioned this pull request Aug 14, 2018

[AutoPR compute/resource-manager/network/resource-manager] Azure Network August release Azure/azure-sdk-for-node#3335

Closed

AutorestCI mentioned this pull request Aug 14, 2018

[AutoPR network/resource-manager/compute/resource-manager] Azure Network August release Azure/azure-sdk-for-java#2322

Closed

jianghaolu suggested changes Aug 14, 2018

View reviewed changes

pashukl and others added 2 commits August 15, 2018 12:11

Changes to Support MSEEv2 Datapath for ExpressRoute. (#3647)

b6822af

Description of Changes: - Added a flag expressRouteGatewayBypass to the Connection Properties. - The user can set the flag to True to use MSEEv2 datapath Related work items: #2628003

Added new API to networkwatcher.json and examples (#3650)

d7c69d9

* Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example

dsgouda mentioned this pull request Aug 16, 2018

Fix name from ServiceEndpointPolicyDefinition to ServiceEndpointPolicyDefinitions… #3655

Merged

10 tasks

chandrasekarsrinivasan and others added 3 commits August 16, 2018 10:55

Fix name from ServiceEndpointDefinition to ServiceEndpointDefinitions…

a8d30be

… while doing a put, get and delete (#3655)

Add/Edit Outbound Rule on Load Balancer and Examples (#3592)

2ca2757

* Add/Edit Outbound Rule on Load Balancer and Examples * Adding properties enabletcpreset, idletimeoutinminutes and protocol * Adding a reference to Public IP Prefix * Dummy Commit

Removed QueryConnectionMOnitors API (#3661)

880a171

* Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * removed QueryConnectionMonitors Api

jianghaolu approved these changes Aug 16, 2018

View reviewed changes

jianghaolu merged commit c9d1315 into master Aug 17, 2018

AutorestCI mentioned this pull request Aug 17, 2018

[AutoPR compute/resource-manager/network/resource-manager] Azure Network August release Azure/azure-sdk-for-go#2476

Closed

anton-evseev mentioned this pull request Aug 17, 2018

Re-generated Network for August release Azure/azure-sdk-for-net#4675

Closed

9 tasks

lmazuel deleted the Network-August-Release branch August 17, 2018 16:32

anton-evseev mentioned this pull request Aug 24, 2018

Re-generated Network for August release Azure/azure-sdk-for-net#4699

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure Network August release #3635

Azure Network August release #3635

MikhailTryakhov commented Aug 14, 2018

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

azuresdkci commented Aug 14, 2018

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

jianghaolu Aug 14, 2018

MikhailTryakhov Aug 15, 2018 •

edited

Loading

jianghaolu Aug 14, 2018

MikhailTryakhov commented Aug 16, 2018

Azure Network August release #3635

Azure Network August release #3635

Conversation

MikhailTryakhov commented Aug 14, 2018

PR information

Quality of Swagger

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Aug 14, 2018

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-java

jianghaolu Aug 14, 2018

Choose a reason for hiding this comment

MikhailTryakhov Aug 15, 2018 • edited Loading

Choose a reason for hiding this comment

jianghaolu Aug 14, 2018

Choose a reason for hiding this comment

MikhailTryakhov commented Aug 16, 2018

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

MikhailTryakhov Aug 15, 2018 •

edited

Loading