Add/Edit Outbound Rule on Load Balancer and Examples #3592

khannarhea · 2018-08-07T01:15:13Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkci · 2018-08-07T01:20:08Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-07T01:21:18Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-08-07T01:25:24Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3087

AutorestCI · 2018-08-07T01:37:14Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpkm8r8too/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpkm8r8too/sdk', '--nodejs', '[email protected]/autorest.nodejs@^2.1.43']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.79)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
FATAL: nodejs/generate - FAILED
FATAL: Error: AutoRest extension '@microsoft.azure/autorest.nodejs' reported error: Error: This socket is closed,[object Object],1
Process() cancelled due to exception : AutoRest extension '@microsoft.azure/autorest.nodejs' reported error: Error: This socket is closed,[object Object],1

AutorestCI · 2018-08-07T01:40:23Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp54_qexl0/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp54_qexl0/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '[email protected]/autorest.go@~2.1.110', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.110->2.1.110)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-06"} .
Processing batch task - {"tag":"package-2018-04"} .
Shutting Down
FATAL: go/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Failure during batch task - {"tag":"package-2018-04"} -- false.

AutorestCI · 2018-08-07T01:41:46Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

sergey-shandar · 2018-08-07T18:43:46Z

@ravbhatnagar potential SDK/service breaking changes

xieus

Do we have remove outboundNatRules from all NRP including national clouds?

xieus

We need to add TCP RST to outbound rules. Also check idle timeout to see if the property is there already.

xieus

As public ip prefix change is in, do we need to refer to public ip prefix somewhere for outbound rules?

sergey-shandar · 2018-08-10T17:19:01Z

@ravbhatnagar @MikhailTryakhov could you review the breaking changes?

sergey-shandar · 2018-08-14T23:02:19Z

It's not "breaking changes" because these properties are new..

sergey-shandar · 2018-08-14T23:03:06Z

@khannarhea please, address @xieus comments/questions.

…a/azure-rest-api-specs into Network-August-Release

khannarhea · 2018-08-15T17:40:17Z

@xieus - updated protocol, idletimeoutinminutes and enabletcpreset properties.

khannarhea · 2018-08-15T17:45:09Z

@sergey-shandar - this could potentially be breaking for Basic Load Balancer SKU.

christiankuhtz · 2018-08-15T18:13:16Z

Basic SKU is frozen. These are all Standard SKU only. Why would this break?

christiankuhtz · 2018-08-15T18:15:38Z

@yugangw-msft fyi

yugangw-msft · 2018-08-15T22:14:06Z

specification/network/resource-manager/Microsoft.Network/stable/2018-07-01/loadBalancer.json

@@ -1509,12 +1526,12 @@
          },
          "description": "Defines an external port range for inbound NAT to a single backend port on NICs associated with a load balancer. Inbound NAT rules are created automatically for each NIC associated with the Load Balancer using an external port from this range. Defining an Inbound NAT pool on your Load Balancer is mutually exclusive with defining inbound Nat rules. Inbound NAT pools are referenced from virtual machine scale sets. NICs that are associated with individual virtual machines cannot reference an inbound NAT pool. They have to reference individual inbound NAT rules."
        },
-        "outboundNatRules": {
+        "outboundRules": {


Any reason why we want to change the type name here? This will force client applications to update their code from new OutboundNatRule() to new OutboundRule() when migrate from old api-version to this new one. Is this necessary? Or the old name is just wrong?

Yes, this is name change for new feature which is approved by dev and pm team

So , functionality wise, I assume the outbound rules here will be a super set of the old NAT rules?
CC @tjprescott

@yugangw-msft NAT rules in load balancer context implies port forwarding (inbound NAT rule). These rules specify outbound translations and have nothing to do with port forwarding. To avoid this confusion, we opted for removing Nat from the rule name and not reuse what was begun 2+ years ago and never finished and never released.

Yes, OutboundRules are similar in shape, but different in how they are modeled.

OutboundNatRules were never available to anyone.

Thanks for the clarification. This is a zero impact breaking change.

They were never commands in the CLI.

…a/azure-rest-api-specs into Network-August-Release

khannarhea · 2018-08-15T23:39:53Z

@xieus @anilingle-ms I have added public ip prefix reference - please take a look if it looks good

anilingle-ms · 2018-08-16T04:47:26Z

I did not change this. I just changed compute. Json Small keyboard...

________________________________ From: Yugang Wang <[email protected]> Sent: Wednesday, August 15, 2018 8:16:09 PM To: Azure/azure-rest-api-specs Cc: Anil Ingle; Mention Subject: Re: [Azure/azure-rest-api-specs] Add/Edit Outbound Rule on Load Balancer and Examples (#3592) @yugangw-msft commented on this pull request.

________________________________ In specification/network/resource-manager/Microsoft.Network/stable/2018-07-01/loadBalancer.json<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F3592%23discussion_r210467147&data=02%7C01%7CAnil.Ingle%40microsoft.com%7C2bdaa62c7feb430c9c6a08d603269e53%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636699861735225663&sdata=DOwLwtHIO0Wi%2BY%2B%2BSTheXm8oRLiXqKaapCILpr5yhS8%3D&reserved=0>:

@@ -1509,12 +1526,12 @@

}, "description": "Defines an external port range for inbound NAT to a single backend port on NICs associated with a load balancer. Inbound NAT rules are created automatically for each NIC associated with the Load Balancer using an external port from this range. Defining an Inbound NAT pool on your Load Balancer is mutually exclusive with defining inbound Nat rules. Inbound NAT pools are referenced from virtual machine scale sets. NICs that are associated with individual virtual machines cannot reference an inbound NAT pool. They have to reference individual inbound NAT rules." }, - "outboundNatRules": { + "outboundRules": { So , functionality wise, I assume the outbound rules here will be a super set of the old NAT rules? CC @tjprescott<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftjprescott&data=02%7C01%7CAnil.Ingle%40microsoft.com%7C2bdaa62c7feb430c9c6a08d603269e53%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636699861735225663&sdata=bldKQ0qG4iVdODo7ERRH44Iwaa6vRip5Ph6MmAz6xgI%3D&reserved=0> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F3592%23discussion_r210467147&data=02%7C01%7CAnil.Ingle%40microsoft.com%7C2bdaa62c7feb430c9c6a08d603269e53%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636699861735235675&sdata=mqYurf%2FvgvvBbPbkbKQuGfVRO46ZxrPbaJDWemTri44%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAgdxIs6yYs_3I4DEAf6zcTZvYxgxWlebks5uROP5gaJpZM4VxU7c&data=02%7C01%7CAnil.Ingle%40microsoft.com%7C2bdaa62c7feb430c9c6a08d603269e53%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636699861735235675&sdata=ePucHIFs%2Ba02sHqDH9xtJGlEiJxJdaRfiUxxGdZWCaw%3D&reserved=0>.

MikhailTryakhov

This functionality didn't work any time in SDKs and wasn't implemented in PS or CLI
so we can merge it bumping SDK versions.

* Created folder for 2018-07-01 api version (#3509) * Created folder for 2018-07-01 api version * fixed incorrect encoding symbol * Fix lint diff and improve output on failure (#3528) Lint diff was failing on PRs with a base branch other than master. We needed to fetch the base branch ref from the origin before trying to resolve it to its commit hash. * Python conf for Network 2018-06 (#3535) * Py conf for Network 2018-07-01 (#3539) * Introduce Publicipprefix to swagger (#3520) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Publicipprefixaugust (#3573) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Service Endpoint Policies Swagger (#3558) * Service Endpoint Policies Swagger * Fix review comments * Updated Network Usage location parameter pattern (#3583) * Add enableTcpReset property to load balancer (#3545) * Add enableTcpReset property to load balancer. * Update loadbalancer examples with enableTcpReset. * added global reach flag (#3542) * fix query packet capture status in latest version (#3601) * Publicipprefixaugust (#3618) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Publicipprefixaugust (#3631) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties * Changes to Support MSEEv2 Datapath for ExpressRoute. (#3647) Description of Changes: - Added a flag expressRouteGatewayBypass to the Connection Properties. - The user can set the flag to True to use MSEEv2 datapath Related work items: #2628003 * Added new API to networkwatcher.json and examples (#3650) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * Fix name from ServiceEndpointDefinition to ServiceEndpointDefinitions while doing a put, get and delete (#3655) * Add/Edit Outbound Rule on Load Balancer and Examples (#3592) * Add/Edit Outbound Rule on Load Balancer and Examples * Adding properties enabletcpreset, idletimeoutinminutes and protocol * Adding a reference to Public IP Prefix * Dummy Commit * Removed QueryConnectionMOnitors API (#3661) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * removed QueryConnectionMonitors Api

gmainar

Looks good

Add/Edit Outbound Rule on Load Balancer and Examples

3cc4c28

khannarhea requested a review from MikhailTryakhov as a code owner August 7, 2018 01:15

azuresdkci assigned sergey-shandar Aug 7, 2018

azuresdkci requested a review from sergey-shandar August 7, 2018 01:16

AutorestCI mentioned this pull request Aug 7, 2018

[AutoPR network/resource-manager] Add/Edit Outbound Rule on Load Balancer and Examples Azure/azure-sdk-for-python#3087

Closed

AutorestCI mentioned this pull request Aug 7, 2018

[AutoPR network/resource-manager] Add/Edit Outbound Rule on Load Balancer and Examples Azure/azure-sdk-for-node#3299

Closed

sergey-shandar added the potential-sdk-breaking-change label Aug 7, 2018

Merge branch 'Network-August-Release' into Network-August-Release

481039b

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 7, 2018

xieus reviewed Aug 7, 2018

View reviewed changes

Merge branch 'Network-August-Release' into Network-August-Release

b2d4971

sergey-shandar added 2 commits August 13, 2018 11:40

Merge branch 'Network-August-Release' into Network-August-Release

bae0c0d

Merge branch 'Network-August-Release' into Network-August-Release

8052cdf

sergey-shandar approved these changes Aug 14, 2018

View reviewed changes

sergey-shandar removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Aug 14, 2018

khannarheams added 2 commits August 15, 2018 10:36

Adding properties enabletcpreset, idletimeoutinminutes and protocol

bce2d9b

Merge branch 'Network-August-Release' of https://github.com/khannarhe…

d772f45

…a/azure-rest-api-specs into Network-August-Release

sergey-shandar added the potential-sdk-breaking-change label Aug 15, 2018

sergey-shandar added 2 commits August 15, 2018 14:22

Merge branch 'Network-August-Release' into Network-August-Release

5af4f63

Merge branch 'Network-August-Release' into Network-August-Release

64995db

yugangw-msft reviewed Aug 15, 2018

View reviewed changes

khannarheams added 2 commits August 15, 2018 16:36

Adding a reference to Public IP Prefix

899ed49

Merge branch 'Network-August-Release' of https://github.com/khannarhe…

6fe1cb2

…a/azure-rest-api-specs into Network-August-Release

MikhailTryakhov approved these changes Aug 16, 2018

View reviewed changes

khannarheams and others added 2 commits August 16, 2018 11:29

Dummy Commit

5b5a9db

Merge branch 'Network-August-Release' into Network-August-Release

496d0d6

sergey-shandar merged commit 2ca2757 into Azure:Network-August-Release Aug 16, 2018

tjprescott mentioned this pull request Aug 17, 2018

Add new TopLevel Resource PublicIPPrefix to CLI Azure/azure-cli#6931

Closed

gmainar reviewed Aug 17, 2018

View reviewed changes

anton-evseev mentioned this pull request Aug 20, 2018

Re-generated Network for August release Azure/azure-sdk-for-net#4675

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add/Edit Outbound Rule on Load Balancer and Examples #3592

Add/Edit Outbound Rule on Load Balancer and Examples #3592

khannarhea commented Aug 7, 2018

azuresdkci commented Aug 7, 2018

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

sergey-shandar commented Aug 7, 2018

xieus left a comment

xieus left a comment

xieus left a comment

sergey-shandar commented Aug 10, 2018

sergey-shandar commented Aug 14, 2018

sergey-shandar commented Aug 14, 2018

khannarhea commented Aug 15, 2018

khannarhea commented Aug 15, 2018

christiankuhtz commented Aug 15, 2018

christiankuhtz commented Aug 15, 2018

yugangw-msft Aug 15, 2018 •

edited

Loading

khannarhea Aug 15, 2018

yugangw-msft Aug 16, 2018

christiankuhtz Aug 16, 2018

yugangw-msft Aug 17, 2018

tjprescott Aug 17, 2018

khannarhea commented Aug 15, 2018 •

edited

Loading

anilingle-ms commented Aug 16, 2018 via email

MikhailTryakhov left a comment

gmainar left a comment

Add/Edit Outbound Rule on Load Balancer and Examples #3592

Add/Edit Outbound Rule on Load Balancer and Examples #3592

Conversation

khannarhea commented Aug 7, 2018

PR information

Quality of Swagger

azuresdkci commented Aug 7, 2018

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-java

sergey-shandar commented Aug 7, 2018

xieus left a comment

Choose a reason for hiding this comment

xieus left a comment

Choose a reason for hiding this comment

xieus left a comment

Choose a reason for hiding this comment

sergey-shandar commented Aug 10, 2018

sergey-shandar commented Aug 14, 2018

sergey-shandar commented Aug 14, 2018

khannarhea commented Aug 15, 2018

khannarhea commented Aug 15, 2018

christiankuhtz commented Aug 15, 2018

christiankuhtz commented Aug 15, 2018

yugangw-msft Aug 15, 2018 • edited Loading

Choose a reason for hiding this comment

khannarhea Aug 15, 2018

Choose a reason for hiding this comment

yugangw-msft Aug 16, 2018

Choose a reason for hiding this comment

christiankuhtz Aug 16, 2018

Choose a reason for hiding this comment

yugangw-msft Aug 17, 2018

Choose a reason for hiding this comment

tjprescott Aug 17, 2018

Choose a reason for hiding this comment

khannarhea commented Aug 15, 2018 • edited Loading

anilingle-ms commented Aug 16, 2018 via email

MikhailTryakhov left a comment

Choose a reason for hiding this comment

gmainar left a comment

Choose a reason for hiding this comment

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

yugangw-msft Aug 15, 2018 •

edited

Loading

khannarhea commented Aug 15, 2018 •

edited

Loading