Nits - Services.json #29020

pjohari-ms · 2024-05-08T01:17:26Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-05-08T01:17:30Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
For details of the ARM review, see aka.ms/azsdk/pr-arm-review.

openapi-pipeline-app · 2024-05-08T01:17:32Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 5 Errors, 10 Warnings failed [Detail]

Compared specs (v0.10.8)	new version	base version
services.json	2024-05-15(aaee29e)	2023-11-15(main)
services.json	2024-05-15(aaee29e)	2024-02-15-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.DocumentDB/stable/2024-05-15/services.json#L332:7 Old: Microsoft.DocumentDB/stable/2023-11-15/services.json#L331:7
`❌` 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.DocumentDB/stable/2024-05-15/services.json#L322:9 Old: Microsoft.DocumentDB/stable/2023-11-15/services.json#L322:9
`❌` 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.DocumentDB/stable/2024-05-15/services.json#L328:5 Old: Microsoft.DocumentDB/stable/2023-11-15/services.json#L328:5
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'serviceType' that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/services.json#L322:9 Old: Microsoft.DocumentDB/stable/2023-11-15/services.json#L322:9
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'serviceType' that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/services.json#L328:5 Old: Microsoft.DocumentDB/stable/2023-11-15/services.json#L328:5

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.DocumentDB/stable/2024-05-15/services.json#L332:7 Old: Microsoft.DocumentDB/preview/2024-02-15-preview/services.json#L321:7
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.DocumentDB/stable/2024-05-15/services.json#L322:9 Old: Microsoft.DocumentDB/preview/2024-02-15-preview/services.json#L312:9
⚠️ 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.DocumentDB/stable/2024-05-15/services.json#L328:5 Old: Microsoft.DocumentDB/preview/2024-02-15-preview/services.json#L318:5
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'sourceBackupLocation' renamed or removed? New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L9677:7 Old: Microsoft.DocumentDB/preview/2024-02-15-preview/cosmos-db.json#L11621:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'restoreWithTtlDisabled' renamed or removed? New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L9677:7 Old: Microsoft.DocumentDB/preview/2024-02-15-preview/cosmos-db.json#L11621:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'restoreWithTtlDisabled' renamed or removed? New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L9724:7 Old: Microsoft.DocumentDB/preview/2024-02-15-preview/cosmos-db.json#L11681:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'restoreWithTtlDisabled' renamed or removed?
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'materializedViewDefinition' renamed or removed? New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L8163:7 Old: Microsoft.DocumentDB/preview/2024-02-15-preview/cosmos-db.json#L10045:7
⚠️ 1034 - AddedRequiredProperty	The new version has new required property 'serviceType' that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/services.json#L322:9 Old: Microsoft.DocumentDB/preview/2024-02-15-preview/services.json#L312:9
⚠️ 1034 - AddedRequiredProperty	The new version has new required property 'serviceType' that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/services.json#L328:5 Old: Microsoft.DocumentDB/preview/2024-02-15-preview/services.json#L318:5

️⚠️LintDiff: 0 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-2024-05	package-2024-05(aaee29e)	package-2024-05(release-cosmos-db-Microsoft.DocumentDB-2024-05-15)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L63
`❌` ResourceNameRestriction	The resource name parameter 'serviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L79
`❌` ProvisioningStateSpecifiedForLROPut	200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L80
`❌` ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L80
`❌` PutRequestResponseSchemeArm	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Service_Create' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L80
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L80
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L153
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L213
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L277
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L285
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L359
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L371
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L383
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L394
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L450
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L461
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L487
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L498
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L531
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L542
⚠️ MissingSegmentsInNestedResourceListOperation	A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L37
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L51
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L57
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L106
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L109
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L118
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L183
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L186
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L195

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-08T01:17:33Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning in generating from 0d3fef1f883b8063bc9af76fbf596e1a4168a58e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh]  notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
cmderr	[automation_init.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_init.sh] npm notice
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-cosmosdb [Preview SDK Changes]

azure_mgmt_cosmosdb-0.7.0-py3-none-any.whl
azure-mgmt-cosmosdb-0.7.0.zip

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model ClusterResourceProperties has a new parameter azure_connection_method
info	[Changelog]   - Model ClusterResourceProperties has a new parameter private_link_resource_id
info	[Changelog]   - Model DataCenterResourceProperties has a new parameter private_endpoint_ip_address
info	[Changelog]   - Model SqlDedicatedGatewayServiceResourceProperties has a new parameter dedicated_gateway_type

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed in generating from 0d3fef1f883b8063bc9af76fbf596e1a4168a58e. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact

❌Azure.ResourceManager.CosmosDB [Preview SDK Changes]
```
info	[Changelog]
```

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded in generating from 0d3fef1f883b8063bc9af76fbf596e1a4168a58e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-cosmos-generated [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
- azure-resourcemanager-cosmos-generated-1.0.0-beta.1-sources.jar

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded in generating from 0d3fef1f883b8063bc9af76fbf596e1a4168a58e. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/cosmos/armcosmos [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ServiceResourceCreateUpdateParameters.Properties` has been changed from `*ServiceResourceCreateUpdateProperties` to `ServiceResourceCreateUpdatePropertiesClassification`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ServerVersionFive0`, `ServerVersionSix0` added to enum type `ServerVersion`
info	[Changelog] - New enum type `AzureConnectionType` with values `AzureConnectionTypeNone`, `AzureConnectionTypeVPN`
info	[Changelog] - New enum type `DedicatedGatewayType` with values `DedicatedGatewayTypeDistributedQuery`, `DedicatedGatewayTypeIntegratedCache`
info	[Changelog] - New function `*DataTransferServiceResourceCreateUpdateParameters.GetServiceResourceCreateUpdateProperties() *ServiceResourceCreateUpdateProperties`
info	[Changelog] - New function `*GraphAPIComputeServiceResourceCreateUpdateParameters.GetServiceResourceCreateUpdateProperties() *ServiceResourceCreateUpdateProperties`
info	[Changelog] - New function `*MaterializedViewsBuilderServiceResourceCreateUpdateParameters.GetServiceResourceCreateUpdateProperties() *ServiceResourceCreateUpdateProperties`
info	[Changelog] - New function `*SQLDedicatedGatewayServiceResourceCreateUpdateParameters.GetServiceResourceCreateUpdateProperties() *ServiceResourceCreateUpdateProperties`
info	[Changelog] - New function `*ServiceResourceCreateUpdateProperties.GetServiceResourceCreateUpdateProperties() *ServiceResourceCreateUpdateProperties`
info	[Changelog] - New struct `DataTransferServiceResourceCreateUpdateParameters`
info	[Changelog] - New struct `GraphAPIComputeServiceResourceCreateUpdateParameters`
info	[Changelog] - New struct `MaterializedViewsBuilderServiceResourceCreateUpdateParameters`
info	[Changelog] - New struct `SQLDedicatedGatewayServiceResourceCreateUpdateParameters`
info	[Changelog] - New field `AzureConnectionMethod`, `PrivateLinkResourceID` in struct `ClusterResourceProperties`
info	[Changelog] - New field `PrivateEndpointIPAddress` in struct `DataCenterResourceProperties`
info	[Changelog] - New field `DedicatedGatewayType` in struct `SQLDedicatedGatewayServiceResourceProperties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 25 additive change(s).

Present SDK breaking changes suppressions
No suppression file added.

Absent SDK breaking changes suppressions
- Type of `ServiceResourceCreateUpdateParameters.Properties` has been changed from `*ServiceResourceCreateUpdateProperties` to `ServiceResourceCreateUpdatePropertiesClassification`

Parse Suppression File Errors
No suppression file added.

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded in generating from 0d3fef1f883b8063bc9af76fbf596e1a4168a58e. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-cosmosdb [Preview SDK Changes]

azure-arm-cosmosdb-15.7.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface DataTransferServiceResourceCreateUpdateParameters
info	[Changelog]   - Added Interface GraphAPIComputeServiceResourceCreateUpdateParameters
info	[Changelog]   - Added Interface MaterializedViewsBuilderServiceResourceCreateUpdateParameters
info	[Changelog]   - Added Interface ServiceResourceCreateUpdateProperties
info	[Changelog]   - Added Interface SqlDedicatedGatewayServiceResourceCreateUpdateParameters
info	[Changelog]   - Added Type Alias AzureConnectionType
info	[Changelog]   - Added Type Alias DedicatedGatewayType
info	[Changelog]   - Added Type Alias ServiceResourceCreateUpdatePropertiesUnion
info	[Changelog]   - Interface ClusterResourceProperties has a new optional parameter azureConnectionMethod
info	[Changelog]   - Interface ClusterResourceProperties has a new optional parameter privateLinkResourceId
info	[Changelog]   - Interface DataCenterResourceProperties has a new optional parameter privateEndpointIpAddress
info	[Changelog]   - Interface SqlDedicatedGatewayServiceResourceProperties has a new optional parameter dedicatedGatewayType
info	[Changelog]   - Added Enum KnownAzureConnectionType
info	[Changelog]   - Added Enum KnownDedicatedGatewayType
info	[Changelog]   - Enum KnownServerVersion has a new value Five0
info	[Changelog]   - Enum KnownServerVersion has a new value Six0

️❌ azure-resource-manager-schemas failed [Detail]

❌Code Generator Failed in generating from 0d3fef1f883b8063bc9af76fbf596e1a4168a58e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.

️⚠️ azure-powershell warning [Detail]

⚠️Warning in generating from 0d3fef1f883b8063bc9af76fbf596e1a4168a58e. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.cosmos-db.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-08T01:17:33Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/cosmos/armcosmos	https://apiview.dev/Assemblies/Review/b6c1e0c0f6e54f6b8de67946304e3b9f?revisionId=7fb375051d174871a84471ad525b8964
JavaScript	@azure/arm-cosmosdb	https://apiview.dev/Assemblies/Review/06c23e48548143fb8df81695f9f5b2d6?revisionId=4bca6a04f9104da3a3b44d47cae850c8
Java	azure-resourcemanager-cosmos-generated	https://apiview.dev/Assemblies/Review/06cb8d7a951f40a8810a0ffbd3cabd77?revisionId=87c3e3b13f46427987c18b7c9be78184
Swagger	Microsoft.DocumentDB	https://apiview.dev/Assemblies/Review/ac373549b7d34a108e5add93e45b3e3f?revisionId=c9c9fe3c3a2541509224d25d8f2d2af4

… stable_nits_0507

* Adds base for updating Microsoft.DocumentDB from version stable/2023-11-15 to version 2024-05-15 * Updates readme * Updates API version in new specs and examples * Add mongo v5 and v6 to the swagger (#28473) Co-authored-by: Andrew Khoma <[email protected]> * [CosmosDB-MICassandra] Added VPN feature properties to stable (#28540) * Added VPN feature properties * Fixed SpellCheck violation and added arm-id format to privateLinkResourceId * Added arm-id-details to privateLinkResourceId --------- Co-authored-by: drewkaufmann <[email protected]> * SqlDedicatedGateway DistributedQuery stable changes (#28747) * Distributed Query changes * Nits * Fixed model validation * More fixes * Nits - review comments (#28957) * Nits - Services.json (#29020) * add sdk-suppressions.yaml (#29077) --------- Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: Guanzhou Song <[email protected]> Co-authored-by: drewkaufmann <[email protected]> Co-authored-by: Peng Jiahui <[email protected]>

) * Adds base for updating Microsoft.DocumentDB from version stable/2023-11-15 to version 2024-05-15 * Updates readme * Updates API version in new specs and examples * Add mongo v5 and v6 to the swagger (Azure#28473) Co-authored-by: Andrew Khoma <[email protected]> * [CosmosDB-MICassandra] Added VPN feature properties to stable (Azure#28540) * Added VPN feature properties * Fixed SpellCheck violation and added arm-id format to privateLinkResourceId * Added arm-id-details to privateLinkResourceId --------- Co-authored-by: drewkaufmann <[email protected]> * SqlDedicatedGateway DistributedQuery stable changes (Azure#28747) * Distributed Query changes * Nits * Fixed model validation * More fixes * Nits - review comments (Azure#28957) * Nits - Services.json (Azure#29020) * add sdk-suppressions.yaml (Azure#29077) --------- Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: Guanzhou Song <[email protected]> Co-authored-by: drewkaufmann <[email protected]> Co-authored-by: Peng Jiahui <[email protected]>

Nits - Services.json

0b137cd

Merge branch 'release-cosmos-db-Microsoft.DocumentDB-2024-05-15' into…

aaee29e

… stable_nits_0507

pjohari-ms enabled auto-merge (squash) May 8, 2024 01:18

azure-sdk added the BreakingChange-Go-Sdk label May 8, 2024

azure-sdk mentioned this pull request May 8, 2024

[AutoPR sdk/resourcemanager/cosmos/armcosmos] Nits - Services.json azure-sdk/azure-sdk-for-go#9800

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 8, 2024

chandugunturi self-requested a review May 8, 2024 05:54

chandugunturi approved these changes May 8, 2024

View reviewed changes

pjohari-ms merged commit 90ee870 into Azure:release-cosmos-db-Microsoft.DocumentDB-2024-05-15 May 8, 2024
24 of 29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nits - Services.json #29020

Nits - Services.json #29020

pjohari-ms commented May 8, 2024

openapi-pipeline-app bot commented May 8, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 8, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 8, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 8, 2024 •

edited

Loading

Nits - Services.json #29020

Nits - Services.json #29020

Conversation

pjohari-ms commented May 8, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented May 8, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented May 8, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 8, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented May 8, 2024 • edited Loading

Generated ApiView

openapi-pipeline-app bot commented May 8, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 8, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 8, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 8, 2024 •

edited

Loading