SqlDedicatedGateway DistributedQuery stable changes #28747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| Compared specs (v0.10.7) | new version | base version |
|---|---|---|
| services.json | 2024-05-15(e342e30) | 2023-11-15(main) |
| services.json | 2024-05-15(e342e30) | 2024-02-15-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| package-2024-05 | package-2024-05(e342e30) | package-2024-05(release-cosmos-db-Microsoft.DocumentDB-2024-05-15) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L63 |
|
The resource name parameter 'serviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L79 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L80 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L80 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Service_Create' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L80 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L80 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L153 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L213 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L277 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L285 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L359 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L371 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L383 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L394 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L450 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L461 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L487 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L498 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L531 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L542 |
| A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L37 |
|
| Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L48 |
|
| Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L51 |
|
| Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L57 |
|
| Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L106 |
|
| Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L109 |
|
| Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L118 |
|
| Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L183 |
|
| Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L186 |
|
| Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/stable/2024-05-15/services.json#L195 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
This was referenced Apr 18, 2024
| @@ -402,6 +406,43 @@ | |||
| } | |||
| } | |||
| }, | |||
| "DataTransferServiceResourceCreateUpdateParameters": { | |||
There was a problem hiding this comment.
Name & description not matching.
| @@ -500,6 +554,16 @@ | |||
| } | |||
| } | |||
| }, | |||
| "MaterializedViewsBuilderServiceResourceCreateUpdateParameters": { | |||
There was a problem hiding this comment.
Description has to change to reflect MaterializedViewsBuilderServiceResourceCreateUpdateParameters.
chandugunturi
approved these changes
Apr 23, 2024
pjohari-ms
merged commit 1ed0f49
into
Azure:release-cosmos-db-Microsoft.DocumentDB-2024-05-15
26 of 29 checks passed
mentat9
pushed a commit
that referenced
this pull request
May 16, 2024
* Adds base for updating Microsoft.DocumentDB from version stable/2023-11-15 to version 2024-05-15 * Updates readme * Updates API version in new specs and examples * Add mongo v5 and v6 to the swagger (#28473) Co-authored-by: Andrew Khoma <[email protected]> * [CosmosDB-MICassandra] Added VPN feature properties to stable (#28540) * Added VPN feature properties * Fixed SpellCheck violation and added arm-id format to privateLinkResourceId * Added arm-id-details to privateLinkResourceId --------- Co-authored-by: drewkaufmann <[email protected]> * SqlDedicatedGateway DistributedQuery stable changes (#28747) * Distributed Query changes * Nits * Fixed model validation * More fixes * Nits - review comments (#28957) * Nits - Services.json (#29020) * add sdk-suppressions.yaml (#29077) --------- Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: Guanzhou Song <[email protected]> Co-authored-by: drewkaufmann <[email protected]> Co-authored-by: Peng Jiahui <[email protected]>
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
) * Adds base for updating Microsoft.DocumentDB from version stable/2023-11-15 to version 2024-05-15 * Updates readme * Updates API version in new specs and examples * Add mongo v5 and v6 to the swagger (Azure#28473) Co-authored-by: Andrew Khoma <[email protected]> * [CosmosDB-MICassandra] Added VPN feature properties to stable (Azure#28540) * Added VPN feature properties * Fixed SpellCheck violation and added arm-id format to privateLinkResourceId * Added arm-id-details to privateLinkResourceId --------- Co-authored-by: drewkaufmann <[email protected]> * SqlDedicatedGateway DistributedQuery stable changes (Azure#28747) * Distributed Query changes * Nits * Fixed model validation * More fixes * Nits - review comments (Azure#28957) * Nits - Services.json (Azure#29020) * add sdk-suppressions.yaml (Azure#29077) --------- Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: Guanzhou Song <[email protected]> Co-authored-by: drewkaufmann <[email protected]> Co-authored-by: Peng Jiahui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.