Adding patching scenario ARM API #25446

harryli0108 · 2023-08-22T17:54:35Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-08-22T17:54:37Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-08-22T17:54:38Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 2 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-preview-2023-08	package-preview-2023-08(87c9398)	package-preview-2023-08(release-app-Microsoft.App-2023-08-01-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ PageableOperation	Based on the response model schema, operation 'Patches_ListByBuilderResource' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.App/preview/2023-08-01-preview/Patches.json#L37
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'skipconfig' in:'Patches_Skip_Configure'. Consider updating the operationId Location: Microsoft.App/preview/2023-08-01-preview/Patches.json#L191

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-22T17:54:39Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 7351a69682622681d6f8daa6a000f7827443dd7d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-appcontainers [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ContainerAppsAPIClientOperationsMixin.get_custom_domain_verification_id
info	[Changelog]   - Added operation group BuildersOperations
info	[Changelog]   - Added operation group BuildsOperations
info	[Changelog]   - Added operation group ManagedEnvironmentUsagesOperations
info	[Changelog]   - Added operation group PatchesOperations
info	[Changelog]   - Added operation group UsagesOperations
info	[Changelog]   - Model AuthConfig has a new parameter encryption_settings
info	[Changelog]   - Model AvailableWorkloadProfileProperties has a new parameter gpus
info	[Changelog]   - Model CertificateProperties has a new parameter type
info	[Changelog]   - Model DaprComponent has a new parameter service_component_bind
info	[Changelog]   - Model Ingress has a new parameter additional_port_mappings
info	[Changelog]   - Model Login has a new parameter token_store
info	[Changelog]   - Model ManagedEnvironment has a new parameter app_insights_configuration
info	[Changelog]   - Model ManagedEnvironment has a new parameter open_telemetry_configuration

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 7351a69682622681d6f8daa6a000f7827443dd7d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 7351a69682622681d6f8daa6a000f7827443dd7d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `BuildProvisioningState` with values `BuildProvisioningStateCanceled`, `BuildProvisioningStateCreating`, `BuildProvisioningStateDeleting`, `BuildProvisioningStateFailed`, `BuildProvisioningStateSucceeded`, `BuildProvisioningStateUpdating`
info	[Changelog] - New enum type `BuildStatus` with values `BuildStatusCanceled`, `BuildStatusFailed`, `BuildStatusInProgress`, `BuildStatusNotStarted`, `BuildStatusSucceeded`
info	[Changelog] - New enum type `BuilderProvisioningState` with values `BuilderProvisioningStateCanceled`, `BuilderProvisioningStateCreating`, `BuilderProvisioningStateDeleting`, `BuilderProvisioningStateFailed`, `BuilderProvisioningStateSucceeded`, `BuilderProvisioningStateUpdating`
info	[Changelog] - New enum type `CertificateType` with values `CertificateTypeImagePullTrustedCA`, `CertificateTypeServerSSLCertificate`
info	[Changelog] - New enum type `DetectionStatus` with values `DetectionStatusFailed`, `DetectionStatusRegistryLoginFailed`, `DetectionStatusSucceeded`
info	[Changelog] - New enum type `PatchApplyStatus` with values `PatchApplyStatusCanceled`, `PatchApplyStatusCreatingRevision`, `PatchApplyStatusImagePushPullFailed`, `PatchApplyStatusManuallySkipped`, `PatchApplyStatusNotStarted`, `PatchApplyStatusRebaseFailed`, `PatchApplyStatusRebaseInProgress`, `PatchApplyStatusRevisionCreationFailed`, `PatchApplyStatusSucceeded`
info	[Changelog] - New enum type `PatchProvisioningState` with values `PatchProvisioningStateCanceled`, `PatchProvisioningStateFailed`, `PatchProvisioningStateSucceeded`
info	[Changelog] - New enum type `PatchType` with values `PatchTypeFrameworkAndOSSecurity`, `PatchTypeFrameworkSecurity`, `PatchTypeOSSecurity`, `PatchTypeOther`
info	[Changelog] - New function `NewBuildersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*BuildersClient, error)`
info	[Changelog] - New function `*BuildersClient.BeginCreateOrUpdate(context.Context, string, string, BuilderResource, *BuildersClientBeginCreateOrUpdateOptions) (*runtime.Poller[BuildersClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*BuildersClient.BeginDelete(context.Context, string, string, *BuildersClientBeginDeleteOptions) (*runtime.Poller[BuildersClientDeleteResponse], error)`
info	[Changelog] - New function `*BuildersClient.Get(context.Context, string, string, *BuildersClientGetOptions) (BuildersClientGetResponse, error)`
info	[Changelog] - New function `*BuildersClient.NewListByResourceGroupPager(string, *BuildersClientListByResourceGroupOptions) *runtime.Pager[BuildersClientListByResourceGroupResponse]`
info	[Changelog] - New function `*BuildersClient.NewListBySubscriptionPager(*BuildersClientListBySubscriptionOptions) *runtime.Pager[BuildersClientListBySubscriptionResponse]`
info	[Changelog] - New function `*BuildersClient.BeginUpdate(context.Context, string, string, BuilderResourceUpdate, *BuildersClientBeginUpdateOptions) (*runtime.Poller[BuildersClientUpdateResponse], error)`
info	[Changelog] - New function `NewBuildsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*BuildsClient, error)`
info	[Changelog] - New function `*BuildsClient.BeginCreateOrUpdate(context.Context, string, string, string, BuildResource, *BuildsClientBeginCreateOrUpdateOptions) (*runtime.Poller[BuildsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*BuildsClient.BeginDelete(context.Context, string, string, string, *BuildsClientBeginDeleteOptions) (*runtime.Poller[BuildsClientDeleteResponse], error)`
info	[Changelog] - New function `*BuildsClient.Get(context.Context, string, string, string, *BuildsClientGetOptions) (BuildsClientGetResponse, error)`
info	[Changelog] - New function `*BuildsClient.NewListByBuilderResourcePager(string, string, *BuildsClientListByBuilderResourceOptions) *runtime.Pager[BuildsClientListByBuilderResourceResponse]`
info	[Changelog] - New function `*ClientFactory.NewBuildersClient() *BuildersClient`
info	[Changelog] - New function `*ClientFactory.NewBuildsClient() *BuildsClient`
info	[Changelog] - New function `*ClientFactory.NewManagedEnvironmentUsagesClient() *ManagedEnvironmentUsagesClient`
info	[Changelog] - New function `*ClientFactory.NewPatchesClient() *PatchesClient`
info	[Changelog] - New function `*ClientFactory.NewUsagesClient() *UsagesClient`
info	[Changelog] - New function `*ContainerAppsAPIClient.GetCustomDomainVerificationID(context.Context, *ContainerAppsAPIClientGetCustomDomainVerificationIDOptions) (ContainerAppsAPIClientGetCustomDomainVerificationIDResponse, error)`
info	[Changelog] - New function `NewManagedEnvironmentUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedEnvironmentUsagesClient, error)`
info	[Changelog] - New function `*ManagedEnvironmentUsagesClient.NewListPager(string, string, *ManagedEnvironmentUsagesClientListOptions) *runtime.Pager[ManagedEnvironmentUsagesClientListResponse]`
info	[Changelog] - New function `NewPatchesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PatchesClient, error)`
info	[Changelog] - New function `*PatchesClient.BeginApply(context.Context, string, string, string, *PatchesClientBeginApplyOptions) (*runtime.Poller[PatchesClientApplyResponse], error)`
info	[Changelog] - New function `*PatchesClient.BeginDelete(context.Context, string, string, string, *PatchesClientBeginDeleteOptions) (*runtime.Poller[PatchesClientDeleteResponse], error)`
info	[Changelog] - New function `*PatchesClient.Get(context.Context, string, string, string, *PatchesClientGetOptions) (PatchesClientGetResponse, error)`
info	[Changelog] - New function `*PatchesClient.ListByBuilderResource(context.Context, string, string, *PatchesClientListByBuilderResourceOptions) (PatchesClientListByBuilderResourceResponse, error)`
info	[Changelog] - New function `*PatchesClient.BeginSkipConfigure(context.Context, string, string, string, bool, *PatchesClientBeginSkipConfigureOptions) (*runtime.Poller[PatchesClientSkipConfigureResponse], error)`
info	[Changelog] - New function `NewUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UsagesClient, error)`
info	[Changelog] - New function `*UsagesClient.NewListPager(string, *UsagesClientListOptions) *runtime.Pager[UsagesClientListResponse]`
info	[Changelog] - New struct `AppInsightsConfiguration`
info	[Changelog] - New struct `BlobStorageTokenStore`
info	[Changelog] - New struct `BuildCollection`
info	[Changelog] - New struct `BuildConfiguration`
info	[Changelog] - New struct `BuildProperties`
info	[Changelog] - New struct `BuildResource`
info	[Changelog] - New struct `BuilderCollection`
info	[Changelog] - New struct `BuilderProperties`
info	[Changelog] - New struct `BuilderResource`
info	[Changelog] - New struct `BuilderResourceUpdate`
info	[Changelog] - New struct `BuilderResourceUpdateProperties`
info	[Changelog] - New struct `ContainerRegistry`
info	[Changelog] - New struct `ContainerRegistryWithCustomImage`
info	[Changelog] - New struct `DaprComponentServiceBinding`
info	[Changelog] - New struct `DaprServiceBindMetadata`
info	[Changelog] - New struct `DataDogConfiguration`
info	[Changelog] - New struct `DestinationsConfiguration`
info	[Changelog] - New struct `EncryptionSettings`
info	[Changelog] - New struct `EnvironmentVariable`
info	[Changelog] - New struct `HTTPGet`
info	[Changelog] - New struct `IngressPortMapping`
info	[Changelog] - New struct `ListUsagesResult`
info	[Changelog] - New struct `LogsConfiguration`
info	[Changelog] - New struct `MetricsConfiguration`
info	[Changelog] - New struct `OpenTelemetryConfiguration`
info	[Changelog] - New struct `PatchCollection`
info	[Changelog] - New struct `PatchDetails`
info	[Changelog] - New struct `PatchDetailsNewLayer`
info	[Changelog] - New struct `PatchDetailsOldLayer`
info	[Changelog] - New struct `PatchProperties`
info	[Changelog] - New struct `PatchResource`
info	[Changelog] - New struct `PreBuildStep`
info	[Changelog] - New struct `TokenStore`
info	[Changelog] - New struct `TracesConfiguration`
info	[Changelog] - New struct `Usage`
info	[Changelog] - New struct `UsageName`
info	[Changelog] - New field `EncryptionSettings` in struct `AuthConfigProperties`
info	[Changelog] - New field `Gpus` in struct `AvailableWorkloadProfileProperties`
info	[Changelog] - New field `Type` in struct `CertificateProperties`
info	[Changelog] - New field `ServiceComponentBind` in struct `DaprComponentProperties`
info	[Changelog] - New field `AdditionalPortMappings` in struct `Ingress`
info	[Changelog] - New field `TokenStore` in struct `Login`
info	[Changelog] - New field `AppInsightsConfiguration`, `OpenTelemetryConfiguration` in struct `ManagedEnvironmentProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 153 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 7351a69682622681d6f8daa6a000f7827443dd7d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appcontainers [View full logs] [Preview SDK Changes]

azure-arm-appcontainers-2.1.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group Builders
info	[Changelog]   - Added operation group Builds
info	[Changelog]   - Added operation group ManagedEnvironmentUsages
info	[Changelog]   - Added operation group Patches
info	[Changelog]   - Added operation group Usages
info	[Changelog]   - Added Interface AppInsightsConfiguration
info	[Changelog]   - Added Interface BlobStorageTokenStore
info	[Changelog]   - Added Interface BuildCollection
info	[Changelog]   - Added Interface BuildConfiguration
info	[Changelog]   - Added Interface BuilderCollection
info	[Changelog]   - Added Interface BuilderResource
info	[Changelog]   - Added Interface BuilderResourceUpdate
info	[Changelog]   - Added Interface BuildersCreateOrUpdateHeaders
info	[Changelog]   - Added Interface BuildersCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface BuildersDeleteHeaders
info	[Changelog]   - Added Interface BuildersDeleteOptionalParams
info	[Changelog]   - Added Interface BuildersGetOptionalParams
info	[Changelog]   - Added Interface BuildersListByResourceGroupNextOptionalParams
info	[Changelog]   - Added Interface BuildersListByResourceGroupOptionalParams
info	[Changelog]   - Added Interface BuildersListBySubscriptionNextOptionalParams
info	[Changelog]   - Added Interface BuildersListBySubscriptionOptionalParams
info	[Changelog]   - Added Interface BuildersUpdateHeaders
info	[Changelog]   - Added Interface BuildersUpdateOptionalParams
info	[Changelog]   - Added Interface BuildResource
info	[Changelog]   - Added Interface BuildsCreateOrUpdateHeaders
info	[Changelog]   - Added Interface BuildsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface BuildsDeleteHeaders
info	[Changelog]   - Added Interface BuildsDeleteOptionalParams
info	[Changelog]   - Added Interface BuildsGetOptionalParams
info	[Changelog]   - Added Interface BuildsListByBuilderResourceNextOptionalParams
info	[Changelog]   - Added Interface BuildsListByBuilderResourceOptionalParams
info	[Changelog]   - Added Interface ContainerRegistry
info	[Changelog]   - Added Interface ContainerRegistryWithCustomImage
info	[Changelog]   - Added Interface DaprComponentServiceBinding
info	[Changelog]   - Added Interface DaprServiceBindMetadata
info	[Changelog]   - Added Interface DataDogConfiguration
info	[Changelog]   - Added Interface DestinationsConfiguration
info	[Changelog]   - Added Interface EncryptionSettings
info	[Changelog]   - Added Interface EnvironmentVariable
info	[Changelog]   - Added Interface GetCustomDomainVerificationIdOptionalParams
info	[Changelog]   - Added Interface HttpGet
info	[Changelog]   - Added Interface IngressPortMapping
info	[Changelog]   - Added Interface ListUsagesResult
info	[Changelog]   - Added Interface LogsConfiguration
info	[Changelog]   - Added Interface ManagedEnvironmentUsagesListNextOptionalParams
info	[Changelog]   - Added Interface ManagedEnvironmentUsagesListOptionalParams
info	[Changelog]   - Added Interface MetricsConfiguration
info	[Changelog]   - Added Interface OpenTelemetryConfiguration
info	[Changelog]   - Added Interface PatchCollection
info	[Changelog]   - Added Interface PatchDetails
info	[Changelog]   - Added Interface PatchDetailsNewLayer
info	[Changelog]   - Added Interface PatchDetailsOldLayer
info	[Changelog]   - Added Interface PatchesApplyHeaders
info	[Changelog]   - Added Interface PatchesApplyOptionalParams
info	[Changelog]   - Added Interface PatchesDeleteHeaders
info	[Changelog]   - Added Interface PatchesDeleteOptionalParams
info	[Changelog]   - Added Interface PatchesGetOptionalParams
info	[Changelog]   - Added Interface PatchesListByBuilderResourceOptionalParams
info	[Changelog]   - Added Interface PatchesSkipConfigureHeaders
info	[Changelog]   - Added Interface PatchesSkipConfigureOptionalParams
info	[Changelog]   - Added Interface PatchProperties
info	[Changelog]   - Added Interface PatchResource
info	[Changelog]   - Added Interface PreBuildStep
info	[Changelog]   - Added Interface TokenStore
info	[Changelog]   - Added Interface TracesConfiguration
info	[Changelog]   - Added Interface Usage
info	[Changelog]   - Added Interface UsageName
info	[Changelog]   - Added Interface UsagesListNextOptionalParams
info	[Changelog]   - Added Interface UsagesListOptionalParams
info	[Changelog]   - Added Type Alias BuilderProvisioningState
info	[Changelog]   - Added Type Alias BuildersCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias BuildersGetResponse
info	[Changelog]   - Added Type Alias BuildersListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias BuildersListByResourceGroupResponse
info	[Changelog]   - Added Type Alias BuildersListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias BuildersListBySubscriptionResponse
info	[Changelog]   - Added Type Alias BuildersUpdateResponse
info	[Changelog]   - Added Type Alias BuildProvisioningState
info	[Changelog]   - Added Type Alias BuildsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias BuildsGetResponse
info	[Changelog]   - Added Type Alias BuildsListByBuilderResourceNextResponse
info	[Changelog]   - Added Type Alias BuildsListByBuilderResourceResponse
info	[Changelog]   - Added Type Alias BuildStatus
info	[Changelog]   - Added Type Alias CertificateType
info	[Changelog]   - Added Type Alias DetectionStatus
info	[Changelog]   - Added Type Alias GetCustomDomainVerificationIdResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentUsagesListNextResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentUsagesListResponse
info	[Changelog]   - Added Type Alias PatchApplyStatus
info	[Changelog]   - Added Type Alias PatchesApplyResponse
info	[Changelog]   - Added Type Alias PatchesGetResponse
info	[Changelog]   - Added Type Alias PatchesListByBuilderResourceResponse
info	[Changelog]   - Added Type Alias PatchProvisioningState
info	[Changelog]   - Added Type Alias PatchType
info	[Changelog]   - Added Type Alias UsagesListNextResponse
info	[Changelog]   - Added Type Alias UsagesListResponse
info	[Changelog]   - Interface AuthConfig has a new optional parameter encryptionSettings
info	[Changelog]   - Interface AvailableWorkloadProfileProperties has a new optional parameter gpus
info	[Changelog]   - Interface CertificateProperties has a new optional parameter type
info	[Changelog]   - Interface DaprComponent has a new optional parameter serviceComponentBind
info	[Changelog]   - Interface Ingress has a new optional parameter additionalPortMappings
info	[Changelog]   - Interface Login has a new optional parameter tokenStore
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter appInsightsConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter openTelemetryConfiguration
info	[Changelog]   - Added Enum KnownBuilderProvisioningState
info	[Changelog]   - Added Enum KnownBuildProvisioningState
info	[Changelog]   - Added Enum KnownBuildStatus
info	[Changelog]   - Added Enum KnownCertificateType
info	[Changelog]   - Added Enum KnownDetectionStatus
info	[Changelog]   - Added Enum KnownPatchApplyStatus
info	[Changelog]   - Added Enum KnownPatchProvisioningState
info	[Changelog]   - Added Enum KnownPatchType

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 7351a69682622681d6f8daa6a000f7827443dd7d. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️app [View full logs] [Preview Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 7351a69682622681d6f8daa6a000f7827443dd7d. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.app.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.app.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-22T17:54:40Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appcontainers/armappcontainers	https://apiview.dev/Assemblies/Review/5457469a05cf4639b325fdfbb578b3ac
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/380e4c5994f142daa541af5ebfafeb8b
JavaScript	@azure/arm-appcontainers	https://apiview.dev/Assemblies/Review/21a3c25600114e3a9aca5b4b7bc10d07
Swagger	Microsoft.App	https://apiview.dev/Assemblies/Review/d8d946d1c2be4ee1a781e0381b769e7c

openapi-pipeline-app · 2023-08-22T17:55:15Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

openapi-pipeline-app · 2023-08-22T17:58:17Z

Swagger Validation Report

️🔄BreakingChange inProgress [Detail]

️🔄Breaking Change(Cross-Version) inProgress [Detail]

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` unacceptable kind of an object to dump [object Error]	"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/79b9e8e4a7bf51a26f6852f2dd8af11703157416/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Patches.json"
`❌` unacceptable kind of an object to dump [object Error]	"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/79b9e8e4a7bf51a26f6852f2dd8af11703157416/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Patches.json"

️❌SemanticValidation: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: nullable JsonUrl: Microsoft.App/preview/2023-08-01-preview/Patches.json#L356:21
`❌` INVALID_TYPE	Expected type object but found type string JsonUrl: Microsoft.App/preview/2023-08-01-preview/Patches.json#L356:21

️❌PrettierCheck: 6 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` HowToFix	Code style issues found path: Microsoft.App/preview/2023-08-01-preview/Patches.json
`❌` HowToFix	Code style issues found path: preview/2023-08-01-preview/examples/Patches_Apply.json
`❌` HowToFix	Code style issues found path: preview/2023-08-01-preview/examples/Patches_Delete.json
`❌` HowToFix	Code style issues found path: preview/2023-08-01-preview/examples/Patches_Get.json
`❌` HowToFix	Code style issues found path: preview/2023-08-01-preview/examples/Patches_ListByBuilderResource.json
`❌` HowToFix	Code style issues found path: preview/2023-08-01-preview/examples/Patches_Skip_Configure.json

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️⌛PR Summary pending [Detail]

️⌛Automated merging requirements met pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-22T18:54:14Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

openapi-pipeline-app · 2023-08-22T21:37:24Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

openapi-pipeline-app · 2023-08-22T22:00:10Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

harryli0108 · 2023-08-28T16:52:19Z

This PR is currently trying to merge into another person's feature branch. The idea here is to minimize the file diff shown so that we won't have duplicate reviews on the same files. The changes will be merged into release-app-Microsoft.App-2023-08-01-preview eventually.

sjanamma · 2023-09-01T20:38:39Z

specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Patches.json

+        }
+      }
+    },
+    "/subscription/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.App/builders/{builderName}/patches/{patchName}/skip/{patchSkipConfig}": {


"/subscription/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.App/builders/{builderName}/patches/{patchName}/skip

This path doesn't align with the guidelines.
Can this be -
"/subscription/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.App/builders/{builderName}/patches/{patchName}/skipConfig ? #Resolved

Sure! Adding this change in the next commit.

Didn't see a change here. POST URLs must end with the action name (skipConfig) on a resource ({patchName}). They can't be a parameter like you have here. The URL in sjanamma's comment above is correct.

Sorry I might get confused about that a bit. The parameter is now changed to an in-body one to make sure the path for post action aligns with the guideline.

visingla-ms · 2023-09-19T13:31:46Z

specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Patches.json

+            "description": "Patching operation has been started.",
+            "schema": {
+              "$ref": "#/definitions/PatchResource"
+            },


202 response can't have response body, it should return empty body. #Resolved

got it! updated in the latest commit

visingla-ms · 2023-09-19T13:32:31Z

specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Patches.json

+            }
+          },
+          "204": {
+            "description": "Patch deletion completed successfully."


Patch deletion completed successfully.

204 means that resource being deleted is not found or doesn't exist. #Resolved

updated in the latest commit.

visingla-ms · 2023-09-19T13:49:24Z

specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Patches.json

+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.App/builders/{builderName}/patches/{patchName}": {
+      "get": {


I was going through earlier comments and observed that there is only get and delete on patches resource type. and you explained that patch resource is created when a build instance is being created.

Does that mean, there will be only one patch resource that can be created under a build resource instance? More like singleton instance? #Resolved

There could be multiple patch resources created. And by patch resources, I mean the db entries that user interacts. If there are multiple container apps created in an environment, and many of them are available to be patched, then there could be multiple patch resources.

najian · 2023-09-20T09:05:51Z

specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Patches.json

+          "description": "The status of the patch operation once it has been provisioned",
+          "readOnly": true
+        },
+        "createdTime": {


There’s already createTime and UpdateTime inside commontype/proxyResource/systemdata
And Patch resource contains proxyResource
"description": "Container App Patch",
"allOf": [
{
"$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ProxyResource"
}
]

It‘s dup createTime and updateTime here in my opinion

Ref to https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/types.json

the main reason we have a createdTime here is because the systemData created time is not used in patches. The resource created time we have shows the resource creation time in data plane. Updated time shows the last time the resource got updated either by user or data plane.

I believe this is also what container app revision was doing.

TimLovellSmith · 2023-09-21T20:07:06Z

@harryli0108 /cc @visingla-ms

One more question about this API - is this really best modeled as a POST API? It sounds to me a bit like either it is 'creating' an instance of a skip configuration for an existing patch, which I imagine is something that should be gettable later, or 'updating' a patch, by adding a skip config on it.

Do either of these match your mental model?

In which case it seems like it could have been modeled with different verbs/actions such as
PUT patches/patchName/skipConfig/default
PATCH patches/patchName

and in the former case, skip configs could be created using templates, blocked using policy, etc.

Do you still think POST is preferable?

"/subscription/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.App/builders/{builderName}/patches/{patchName}/skipConfig": {
"post": {
"tags": [
"Patches"
],
"operationId": "Patches_Skip_Configure",
"description": "Configure the patch skip option by patch name.",

harryli0108 · 2023-09-21T20:30:23Z

@harryli0108 /cc @visingla-ms

One more question about this API - is this really best modeled as a POST API? It sounds to me a bit like either it is 'creating' an instance of a skip configuration for an existing patch, which I imagine is something that should be gettable later, or 'updating' a patch, by adding a skip config on it.

Do either of these match your mental model?

In which case it seems like it could have been modeled with different verbs/actions such as PUT patches/patchName/skipConfig/default PATCH patches/patchName

and in the former case, skip configs could be created using templates, blocked using policy, etc.

Do you still think POST is preferable?

"/subscription/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.App/builders/{builderName}/patches/{patchName}/skipConfig": { "post": { "tags": [ "Patches" ], "operationId": "Patches_Skip_Configure", "description": "Configure the patch skip option by patch name.",

Thanks for double checking! I still think that POST method lines up with the current design of patches more then the other methods.

For skipping a patch, instead of creating a policy for it to be skipped, it is actually updating a field called PatchApplyStatus (which exists already when the patch was created). So intead of "creating" something, we're actually updating a field in the resource. I can see the argument from customer's standpoint, but I think it probably matches more with the POST method then create.

And for PATCH method, because skipping is not fully customizing the patch object, I don't want to give the impression that the patch object could be updated by user in anyways. Therefore, I used post/delete method to define skipping, deleting and applying. And these methods are the only "actions" that the user could use to interact with patch resource.

harryli0108 · 2023-09-22T16:31:17Z

/pr RequestMerge

* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: [email protected] <[email protected]> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <[email protected]> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <[email protected]> * complete examples Signed-off-by: Bernd Verst <[email protected]> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <[email protected]> * include updated readme Signed-off-by: Bernd Verst <[email protected]> * fix casing Signed-off-by: Bernd Verst <[email protected]> * formatting Signed-off-by: Bernd Verst <[email protected]> * Use Types v5 Signed-off-by: Bernd Verst <[email protected]> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <[email protected]> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <[email protected]> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <[email protected]> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <[email protected]> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <[email protected]> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <[email protected]> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <[email protected]> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <[email protected]> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <[email protected]> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <[email protected]> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate --------- Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Hal Spang <[email protected]> Signed-off-by: Yash Nisar <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: yalixiang <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Michael Dai <[email protected]> Co-authored-by: bgashirabake <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Harry Li <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: halspang <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: michimune <[email protected]> Co-authored-by: Michimune Kohno <[email protected]> Co-authored-by: Yash Nisar <[email protected]> Co-authored-by: Seris370 <[email protected]> Co-authored-by: Chenghui Yu <[email protected]>

* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: [email protected] <[email protected]> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <[email protected]> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <[email protected]> * complete examples Signed-off-by: Bernd Verst <[email protected]> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <[email protected]> * include updated readme Signed-off-by: Bernd Verst <[email protected]> * fix casing Signed-off-by: Bernd Verst <[email protected]> * formatting Signed-off-by: Bernd Verst <[email protected]> * Use Types v5 Signed-off-by: Bernd Verst <[email protected]> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <[email protected]> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <[email protected]> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <[email protected]> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <[email protected]> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <[email protected]> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <[email protected]> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <[email protected]> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <[email protected]> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <[email protected]> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <[email protected]> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate * update tests for jobs * update tests for jobs * fix name and resource values in examples * fix name and resource values in examples * fix name and resource values in examples * fix name and resource values in examples --------- Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Hal Spang <[email protected]> Signed-off-by: Yash Nisar <[email protected]> Co-authored-by: Zunli Hu <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: yalixiang <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Michael Dai <[email protected]> Co-authored-by: bgashirabake <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Harry Li <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: halspang <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: michimune <[email protected]> Co-authored-by: Michimune Kohno <[email protected]> Co-authored-by: Yash Nisar <[email protected]> Co-authored-by: Seris370 <[email protected]> Co-authored-by: Chenghui Yu <[email protected]>

* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: [email protected] <[email protected]> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <[email protected]> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <[email protected]> * complete examples Signed-off-by: Bernd Verst <[email protected]> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <[email protected]> * include updated readme Signed-off-by: Bernd Verst <[email protected]> * fix casing Signed-off-by: Bernd Verst <[email protected]> * formatting Signed-off-by: Bernd Verst <[email protected]> * Use Types v5 Signed-off-by: Bernd Verst <[email protected]> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <[email protected]> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <[email protected]> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <[email protected]> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <[email protected]> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <[email protected]> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <[email protected]> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <[email protected]> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <[email protected]> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <[email protected]> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <[email protected]> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate --------- Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Hal Spang <[email protected]> Signed-off-by: Yash Nisar <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: yalixiang <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Michael Dai <[email protected]> Co-authored-by: bgashirabake <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Harry Li <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: halspang <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: michimune <[email protected]> Co-authored-by: Michimune Kohno <[email protected]> Co-authored-by: Yash Nisar <[email protected]> Co-authored-by: Seris370 <[email protected]> Co-authored-by: Chenghui Yu <[email protected]>

pauld-msft and others added 4 commits August 21, 2023 16:35

cherry picked the build and builder updates

2f63d26

some more cleanup

0445b59

Adding patching scenario and samples

24fd918

Added to readme

79b9e8e

harryli0108 marked this pull request as ready for review August 22, 2023 17:55

AzureRestAPISpecReview added CI-FixRequiredOnFailure resource-manager labels Aug 22, 2023

This was referenced Aug 22, 2023

[AutoPR app] Adding patching scenario ARM API azure-sdk/azure-resource-manager-schemas#3129

Draft

[AutoPR azure-resourcemanager-appcontainers] Adding patching scenario ARM API azure-sdk/azure-sdk-for-java#6614

Closed

Lint fix

00c0c6b

azure-sdk mentioned this pull request Aug 22, 2023

[AutoPR sdk/resourcemanager/appcontainers/armappcontainers] Adding patching scenario ARM API azure-sdk/azure-sdk-for-go#7039

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Aug 22, 2023

Linting

f7ef2b0

This was referenced Aug 22, 2023

[AutoPR track2_azure-mgmt-appcontainers] Adding patching scenario ARM API azure-sdk/azure-sdk-for-python#4461

Closed

[AutoPR @azure/arm-appcontainers] Adding patching scenario ARM API azure-sdk/azure-sdk-for-js#6396

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Aug 22, 2023

Linting error fix

382a9ee

harryli0108 added the ARMReview label Aug 30, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 30, 2023

sjanamma reviewed Sep 1, 2023

View reviewed changes

harryli0108 added 2 commits September 14, 2023 13:50

Removed invalid required tag

ca0ccc1

Fixed examples

07c09e7

harryli0108 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 14, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 14, 2023

visingla-ms reviewed Sep 19, 2023

View reviewed changes

visingla-ms added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 19, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 19, 2023

Addressed comments

87c9398

najian reviewed Sep 20, 2023

View reviewed changes

konrad-jamrozik mentioned this pull request Sep 20, 2023

[LintDiff] AggregateError is not showing constituent errors. Original bug report: error encountered: Error: Error running Nimma Azure/azure-sdk-tools#6856

Closed

harryli0108 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 20, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 20, 2023

visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 21, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 21, 2023

raych1 added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Sep 22, 2023

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Sep 22, 2023

github-actions bot added the MergeRequested label Sep 22, 2023

rkmanda approved these changes Sep 23, 2023

View reviewed changes

rkmanda merged commit c70291e into release-app-Microsoft.App-2023-08-01-preview Sep 23, 2023
26 of 27 checks passed

rkmanda deleted the harrli/adding-patcher-api-specs branch September 23, 2023 04:11

harryli0108 mentioned this pull request Mar 1, 2024

ContainerAppsBuild and ContainerAppsPatch API #27982

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding patching scenario ARM API #25446

Adding patching scenario ARM API #25446

harryli0108 commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

harryli0108 commented Aug 28, 2023

sjanamma Sep 1, 2023 •

edited by visingla-ms

Loading

harryli0108 Sep 1, 2023

mentat9 Sep 9, 2023

harryli0108 Sep 13, 2023

visingla-ms Sep 19, 2023 •

edited

Loading

harryli0108 Sep 19, 2023

visingla-ms Sep 19, 2023 •

edited

Loading

harryli0108 Sep 19, 2023

visingla-ms Sep 19, 2023 •

edited

Loading

harryli0108 Sep 19, 2023

najian Sep 20, 2023

najian Sep 20, 2023

harryli0108 Sep 20, 2023

TimLovellSmith commented Sep 21, 2023

harryli0108 commented Sep 21, 2023

harryli0108 commented Sep 22, 2023

Adding patching scenario ARM API #25446

Adding patching scenario ARM API #25446

Conversation

harryli0108 commented Aug 22, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

Generated ApiView

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

openapi-pipeline-app bot commented Aug 22, 2023

Swagger Validation Report

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

harryli0108 commented Aug 28, 2023

sjanamma Sep 1, 2023 • edited by visingla-ms Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

visingla-ms Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

visingla-ms Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

visingla-ms Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimLovellSmith commented Sep 21, 2023

harryli0108 commented Sep 21, 2023

harryli0108 commented Sep 22, 2023

harryli0108 commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

sjanamma Sep 1, 2023 •

edited by visingla-ms

Loading

visingla-ms Sep 19, 2023 •

edited

Loading

visingla-ms Sep 19, 2023 •

edited

Loading

visingla-ms Sep 19, 2023 •

edited

Loading