-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing source to cloud patching from 08-01-preview branch #26245
Removing source to cloud patching from 08-01-preview branch #26245
Conversation
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
default | default(3a2730c) | default(release-app-Microsoft.App-2023-08-01-preview) |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
@rkmanda Hi! Sorry for tagging you here. This PR is opened to revert the changes for the source to cloud patching resource from this unreleased api version. We will open a new PR once we know the API version the patching resource will be targeting to. I know it is near the release date for the 08-01 api version. Could this be expedited by any chance? Much appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
443ec76
into
release-app-Microsoft.App-2023-08-01-preview
* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: [email protected] <[email protected]> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <[email protected]> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <[email protected]> * complete examples Signed-off-by: Bernd Verst <[email protected]> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <[email protected]> * include updated readme Signed-off-by: Bernd Verst <[email protected]> * fix casing Signed-off-by: Bernd Verst <[email protected]> * formatting Signed-off-by: Bernd Verst <[email protected]> * Use Types v5 Signed-off-by: Bernd Verst <[email protected]> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <[email protected]> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <[email protected]> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <[email protected]> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <[email protected]> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <[email protected]> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <[email protected]> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <[email protected]> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <[email protected]> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <[email protected]> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <[email protected]> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate --------- Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Hal Spang <[email protected]> Signed-off-by: Yash Nisar <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: yalixiang <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Michael Dai <[email protected]> Co-authored-by: bgashirabake <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Harry Li <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: halspang <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: michimune <[email protected]> Co-authored-by: Michimune Kohno <[email protected]> Co-authored-by: Yash Nisar <[email protected]> Co-authored-by: Seris370 <[email protected]> Co-authored-by: Chenghui Yu <[email protected]>
* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: [email protected] <[email protected]> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <[email protected]> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <[email protected]> * complete examples Signed-off-by: Bernd Verst <[email protected]> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <[email protected]> * include updated readme Signed-off-by: Bernd Verst <[email protected]> * fix casing Signed-off-by: Bernd Verst <[email protected]> * formatting Signed-off-by: Bernd Verst <[email protected]> * Use Types v5 Signed-off-by: Bernd Verst <[email protected]> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <[email protected]> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <[email protected]> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <[email protected]> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <[email protected]> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <[email protected]> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <[email protected]> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <[email protected]> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <[email protected]> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <[email protected]> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <[email protected]> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate * update tests for jobs * update tests for jobs * fix name and resource values in examples * fix name and resource values in examples * fix name and resource values in examples * fix name and resource values in examples --------- Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Hal Spang <[email protected]> Signed-off-by: Yash Nisar <[email protected]> Co-authored-by: Zunli Hu <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: yalixiang <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Michael Dai <[email protected]> Co-authored-by: bgashirabake <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Harry Li <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: halspang <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: michimune <[email protected]> Co-authored-by: Michimune Kohno <[email protected]> Co-authored-by: Yash Nisar <[email protected]> Co-authored-by: Seris370 <[email protected]> Co-authored-by: Chenghui Yu <[email protected]>
* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: [email protected] <[email protected]> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <[email protected]> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <[email protected]> * complete examples Signed-off-by: Bernd Verst <[email protected]> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <[email protected]> * include updated readme Signed-off-by: Bernd Verst <[email protected]> * fix casing Signed-off-by: Bernd Verst <[email protected]> * formatting Signed-off-by: Bernd Verst <[email protected]> * Use Types v5 Signed-off-by: Bernd Verst <[email protected]> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <[email protected]> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <[email protected]> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <[email protected]> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <[email protected]> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <[email protected]> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <[email protected]> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <[email protected]> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <[email protected]> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <[email protected]> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <[email protected]> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate --------- Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Hal Spang <[email protected]> Signed-off-by: Yash Nisar <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: yalixiang <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Michael Dai <[email protected]> Co-authored-by: bgashirabake <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Harry Li <[email protected]> Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: halspang <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: michimune <[email protected]> Co-authored-by: Michimune Kohno <[email protected]> Co-authored-by: Yash Nisar <[email protected]> Co-authored-by: Seris370 <[email protected]> Co-authored-by: Chenghui Yu <[email protected]>
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.