Use conditional compile #24374

markcowl · 2023-06-08T21:48:52Z

Failures in TypeSpecValidation are a known bug in TSV, where it validates more folders than were actually changed

openapi-workflow-bot · 2023-06-08T21:48:56Z

Hi, @markcowl Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-06-08T21:48:57Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️❌TypeSpecAPIView: 0 Errors, 2 Warnings failed [Detail]

Rule	Message
⚠️ Failed to generate TypeSpec APIView. Please check the detail log and make sure TypeSpec compiler version is the latest.	"How to fix":"Check the detailed log and verify if the TypeSpec emitter is able to create API review file for the changes in PR."
⚠️ Failed to generate TypeSpec APIView. Please check the detail log and make sure TypeSpec compiler version is the latest.	"How to fix":"Check the detailed log and verify if the TypeSpec emitter is able to create API review file for the changes in PR."

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️❌TypeSpec Validation: 3 Errors, 6 Warnings failed [Detail]

Rule	Message
`❌` MissingExamplesDirectory	"details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Inference, please ensure the 'examples' is added in the PR."
`❌` SwaggerNotExistInPRBranch	"details":"The generated swagger file 2022-12-01/openapi.json from typespec specification/cognitiveservices/OpenAI.Inference is not on the branch."
`❌` SwaggerNotExistInPRBranch	"details":"The generated swagger file 2023-03-15-preview/openapi.json from typespec specification/cognitiveservices/OpenAI.Inference is not on the branch."
⚠️ @azure-tools/typespec-autorest/union-unsupported	Unions cannot be emitted to OpenAPI v2 unless all options are literals of the same type. Location: cognitiveservices/OpenAI.Inference/models/completions.create.tsp#L198
⚠️ @azure-tools/typespec-autorest/union-unsupported	Unions cannot be emitted to OpenAPI v2 unless all options are literals of the same type. Location: cognitiveservices/OpenAI.Inference/models/chat.completions.tsp#L162
⚠️ @azure-tools/typespec-autorest/union-unsupported	Unions cannot be emitted to OpenAPI v2 unless all options are literals of the same type. Location: cognitiveservices/OpenAI.Inference/models/completions.create.tsp#L198
⚠️ @azure-tools/typespec-autorest/union-unsupported	Unions cannot be emitted to OpenAPI v2 unless all options are literals of the same type. Location: cognitiveservices/OpenAI.Inference/models/chat.completions.tsp#L162
⚠️ MissingTypeSpecProjectConfig	"details":"The configuration 'output-file' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Inference, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'."
⚠️ MissingTypeSpecProjectConfig	"details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Inference, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'."

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-08T21:48:58Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-python failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from 601e3d4. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/cognitiveservices/HealthInsights/healthinsights.oncophenotype/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
warn		specification/cognitiveservices/HealthInsights/healthinsights.openapi/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
warn		specification/cognitiveservices/HealthInsights/healthinsights.trialmatcher/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 601e3d4. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py]  notice
cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 9.7.1
cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
cmderr	[generate.py] npm notice Run `npm install -g [email protected]` to update!
cmderr	[generate.py] npm notice

️✔️azure-ai-anomalydetector [View full logs] [Release SDK Changes]

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from 601e3d4. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		specification/cognitiveservices/HealthInsights/healthinsights.openapi/tspconfig.yaml skipped due to azure-sdk-for-net-track2 not found in tspconfig.yaml
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:145
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 145 | �[0m         �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:145
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 145 | �[0m         �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mException: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:133
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 133 | �[0m             �[36;1mthrow "Not provide service name or namespace."�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mNot provide service name or namespace.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 601e3d4. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Generate changelog failed: ENOENT: no such file or directory, open '/mnt/vss/_work/1/s/azure-sdk-for-js/sdk/anomalydetector/ai-anomaly-detector-rest/changelog-temp/package/CHANGELOG.md'

️✔️@azure-rest/ai-anomaly-detector [View full logs] [Release SDK Changes]
- azure-rest-ai-anomaly-detector-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-08T21:48:59Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-ai-anomalydetector	https://apiview.dev/Assemblies/Review/358aeec687484d44b09305d4708f4ab6
JavaScript	@azure-rest/ai-anomaly-detector	https://apiview.dev/Assemblies/Review/13d061df6aa34083b37f74b7aca89e67

openapi-pipeline-app · 2023-06-08T22:56:18Z

Swagger Validation Report

️⌛BreakingChange pending [Detail]

️⌛Breaking Change(Cross-Version) pending [Detail]

️⌛CredScan pending [Detail]

️⌛LintDiff pending [Detail]

️⌛Avocado pending [Detail]

️⌛ApiReadinessCheck pending [Detail]

️⌛~[Staging] ServiceAPIReadinessTest pending [Detail]

️⌛SwaggerAPIView pending [Detail]

️⌛CadlAPIView pending [Detail]

️⌛TypeSpecAPIView pending [Detail]

️⌛ModelValidation pending [Detail]

️⌛SemanticValidation pending [Detail]

️⌛PoliCheck pending [Detail]

️⌛PrettierCheck pending [Detail]

️⌛SpellCheck pending [Detail]

️⌛Lint(RPaaS) pending [Detail]

️⌛CadlValidation pending [Detail]

️⌛TypeSpec Validation pending [Detail]

️⌛PR Summary pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

eng/pipelines/templates/steps/typespec-ci.yml

specification/cognitiveservices/HealthInsights/healthinsights.oncophenotype/tspconfig.yaml

…oncophenotype/tspconfig.yaml

mikeharder

LGTM, but please wait for review from @timotheeguerin

* Add conditional compile of client.tsp * Always execute from main.tsp, always check client.tsp * Fix script * Remove yaml reference * Update specification/cognitiveservices/HealthInsights/healthinsights.oncophenotype/tspconfig.yaml --------- Co-authored-by: Mike Harder <[email protected]>

markcowl requested a review from yangyuan as a code owner June 8, 2023 21:48

openapi-assignment-bot bot assigned anuchandy Jun 8, 2023

ghost added the Cognitive Services label Jun 8, 2023

This was referenced Jun 8, 2023

[AutoPR @azure-rest/ai-anomaly-detector] Use conditional compile azure-sdk/azure-sdk-for-js#5393

Closed

[AutoPR azure-ai-anomalydetector] Use conditional compile azure-sdk/azure-sdk-for-java#5748

Closed

markcowl added 3 commits June 8, 2023 15:26

Add conditional compile of client.tsp

6068a2c

Always execute from main.tsp, always check client.tsp

1678df7

Fix script

0b27942

mikeharder requested changes Jun 8, 2023

View reviewed changes

eng/pipelines/templates/steps/typespec-ci.yml Outdated Show resolved Hide resolved

eng/pipelines/templates/steps/typespec-ci.yml Show resolved Hide resolved

eng/pipelines/templates/steps/typespec-ci.yml Show resolved Hide resolved

Remove yaml reference

39480b6

mikeharder reviewed Jun 8, 2023

View reviewed changes

specification/cognitiveservices/HealthInsights/healthinsights.oncophenotype/tspconfig.yaml Outdated Show resolved Hide resolved

Update specification/cognitiveservices/HealthInsights/healthinsights.…

d8aaec5

…oncophenotype/tspconfig.yaml

mikeharder approved these changes Jun 8, 2023

View reviewed changes

timotheeguerin approved these changes Jun 8, 2023

View reviewed changes

markcowl merged commit 601e3d4 into Azure:main Jun 8, 2023

This was referenced Jun 8, 2023

[ReleasePR @azure-rest/ai-anomaly-detector] [TypeSpec] Update formatting of existing specs Azure/azure-sdk-for-js#25672

Closed

[ReleasePR azure-ai-anomalydetector] [TypeSpec] Update formatting of existing specs Azure/azure-sdk-for-java#34673

Closed

mikeharder mentioned this pull request Jun 9, 2023

[HealthInsights] Remove typespec-csharp from default emitters #24300

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use conditional compile #24374

Use conditional compile #24374

markcowl commented Jun 8, 2023 •

edited by mikeharder

Loading

openapi-workflow-bot bot commented Jun 8, 2023

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 8, 2023

mikeharder left a comment

Use conditional compile #24374

Use conditional compile #24374

Conversation

markcowl commented Jun 8, 2023 • edited by mikeharder Loading

openapi-workflow-bot bot commented Jun 8, 2023

openapi-pipeline-app bot commented Jun 8, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 8, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 8, 2023 • edited Loading

Generated ApiView

openapi-pipeline-app bot commented Jun 8, 2023

Swagger Validation Report

mikeharder left a comment

Choose a reason for hiding this comment

markcowl commented Jun 8, 2023 •

edited by mikeharder

Loading

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 8, 2023 •

edited

Loading