Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HealthInsights] Remove typespec-csharp from default emitters #24300

Closed
mikeharder opened this issue Jun 5, 2023 · 1 comment
Closed

[HealthInsights] Remove typespec-csharp from default emitters #24300

mikeharder opened this issue Jun 5, 2023 · 1 comment
Assignees

Comments

@mikeharder
Copy link
Member

Some tspconfig.yaml in the specs repo are configured to, by default, use emitters not installed by the root package.json. Example:

This causes tsp compile in this folder to fail, since it tries to run an emitter not installed.

Fix is to keep the emitter config, but remove from emit list.

@mikeharder mikeharder self-assigned this Jun 5, 2023
@mikeharder mikeharder moved this from 🤔 Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Jun 5, 2023
mikeharder added a commit to mikeharder/azure-rest-api-specs that referenced this issue Jun 5, 2023
- typespec-csharp is not installed by root package.json
- Causes "tsp compile" to fail
- Fixes Azure#24300
@mikeharder mikeharder moved this from 🐝 Dev to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Jun 6, 2023
@mikeharder mikeharder changed the title [TypeSpecValidation] Only emitters installed by root package.json should be enabled by default [HealthInsights] Remove typespec-csharp from default emitters Jun 8, 2023
@mikeharder
Copy link
Member Author

Fixed by #24374

@github-project-automation github-project-automation bot moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jun 9, 2023
@mikeharder mikeharder moved this from 🎊 Closed to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Jun 9, 2023
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant