Release securityinsights microsoft.security insights 2022 11 01 #21540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2022-08-01 to version 2022-11-01
…stable (Azure#20944) * update * update api versions
* Automation rules 2022-11-01 stable version * preetier * Remove unused url parameters
…nsights-2022-11-01
|
Hi, @anat-gilenson Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
/azp run |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.2)] | new version | base version |
|---|---|---|
| AlertRules.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| AlertRules.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| AutomationRules.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| AutomationRules.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| Bookmarks.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| Bookmarks.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| DataConnectors.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| Incidents.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| Incidents.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| OnboardingStates.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| OnboardingStates.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| SecurityMLAnalyticsSettings.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| ThreatIntelligence.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| ThreatIntelligence.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| Watchlists.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| Watchlists.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| AlertTypes.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| AlertTypes.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| EntityTypes.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| EntityTypes.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| IncidentTypes.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| IncidentTypes.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
| operations.json | 2022-11-01(ad0ca8b) | 2022-08-01(main) |
| operations.json | 2022-11-01(ad0ca8b) | 2022-11-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/incidents/{incidentIdentifier}/runPlaybook' removed or restructured? Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AutomationRules.json#L220:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/bookmarks/{bookmarkId}/relations' removed or restructured? Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Bookmarks.json#L222:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/bookmarks/{bookmarkId}/expand' removed or restructured? Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Bookmarks.json#L283:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/bookmarks/{bookmarkId}/relations/{relationName}' removed or restructured? Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Bookmarks.json#L331:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/incidents/{incidentId}/createTeam' removed or restructured? Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Incidents.json#L234:5 |
|
| The new version is missing a definition that was found in the old version. Was 'MLBehaviorAnalyticsAlertRule' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'MLBehaviorAnalyticsAlertRuleProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'MLBehaviorAnalyticsAlertRuleTemplate' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ThreatIntelligenceAlertRule' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ThreatIntelligenceAlertRuleProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ThreatIntelligenceAlertRuleTemplate' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NrtAlertRuleProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NrtAlertRuleTemplate' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NrtAlertRule' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'SentinelEntitiesMappings' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRuleBooleanCondition' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRuleBooleanConditionSupportedOperator' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRulePropertyArrayConditionSupportedArrayConditionType' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRulePropertyArrayConditionSupportedArrayType' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRulePropertyArrayValuesCondition' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'BooleanConditionProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManualTriggerRequestBody' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'PropertyArrayConditionProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'BookmarkExpandParameters' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/Bookmarks.json#L223:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Bookmarks.json#L511:3 |
|
| The new version is missing a definition that was found in the old version. Was 'EntityMappingsList' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/Bookmarks.json#L223:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Bookmarks.json#L511:3 |
|
| The new version is missing a definition that was found in the old version. Was 'EntityInnerKind' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/Bookmarks.json#L223:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Bookmarks.json#L511:3 |
|
| The new version is missing a definition that was found in the old version. Was 'UrlEntityProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/Bookmarks.json#L223:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Bookmarks.json#L511:3 |
|
| The new version is missing a definition that was found in the old version. Was 'SubmissionMailEntityProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/Bookmarks.json#L223:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Bookmarks.json#L511:3 |
|
| The new version is missing a definition that was found in the old version. Was 'SecurityGroupEntityProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/Bookmarks.json#L223:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Bookmarks.json#L511:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AlertSeverityEnum' removed or renamed? New: Microsoft.SecurityInsights/stable/2022-11-01/Bookmarks.json#L223:3 Old: Microsoft.SecurityInsights/preview/2022-11-01-preview/Bookmarks.json#L511:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 4 Errors, 1 Warnings failed [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2022-11 | package-2022-11(ad0ca8b) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
Property name should be camel case. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L1078 |
|
|
Property name should be camel case. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L1084 |
|
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/DataConnectors.json#L37 |
RPC-V2-URI-5 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/DataConnectors.json#L82 |
RPC-V2-URI-5 |
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L7 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L37 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L82 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L234 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L282 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L431 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L476 |
|
Property name should be camel case. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L898 |
|
Property name should be camel case. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L904 |
|
Property name should be camel case. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L1509 |
|
Property name should be camel case. Location: Microsoft.SecurityInsights/stable/2022-11-01/AlertRules.json#L1515 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L12 |
|
The delete response body must be empty. Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L151 |
|
The delete response body must be empty. Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L157 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L175 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L1001 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Bookmarks.json#L37 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Bookmarks.json#L82 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Incidents.json#L37 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Incidents.json#L94 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Incidents.json#L234 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Incidents.json#L279 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Incidents.json#L324 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Incidents.json#L385 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Incidents.json#L534 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Incidents.json#L579 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Incidents.json#L640 |
|
The resource name parameter 'relationName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/Incidents.json#L640 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/OnboardingStates.json#L37 |
|
The resource name parameter 'sentinelOnboardingStateName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/OnboardingStates.json#L37 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2022-11-01/OnboardingStates.json#L177 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌~[Staging] SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌PoliCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Click detail for error messages. Exception contact [email protected] or https://aka.ms/swaggersupport. |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
AzureRestAPISpecReview
added
ARMReview
CI-FixRequiredOnFailure
CI-MissingBaseCommit
new-api-version
resource-manager
WaitForARMFeedback
|
Hi @anat-gilenson, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi, @anat-gilenson, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
This was referenced Nov 17, 2022
dw511214992
approved these changes
Nov 21, 2022
This was referenced Nov 21, 2022
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
…e#21540) * Adds base for updating Microsoft.SecurityInsights from version stable/2022-08-01 to version 2022-11-01 * Updates readme * Updates API version in new specs and examples * SecurityMLAnalyticsSettings to Microsoft.SecurityInsights-2022-11-01-stable (Azure#20944) * update * update api versions * Automation rules 2022-11-01 - alert & update triggers (Azure#21205) * Automation rules 2022-11-01 stable version * preetier * Remove unused url parameters Co-authored-by: jungph808 <[email protected]> Co-authored-by: Dor Siso <[email protected]>
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
…e#21540) * Adds base for updating Microsoft.SecurityInsights from version stable/2022-08-01 to version 2022-11-01 * Updates readme * Updates API version in new specs and examples * SecurityMLAnalyticsSettings to Microsoft.SecurityInsights-2022-11-01-stable (Azure#20944) * update * update api versions * Automation rules 2022-11-01 - alert & update triggers (Azure#21205) * Automation rules 2022-11-01 stable version * preetier * Remove unused url parameters Co-authored-by: jungph808 <[email protected]> Co-authored-by: Dor Siso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All PRs to this branch have been reviewed and approved.