Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation rules 2022-11-01 - alert & update triggers #21205

Conversation

dosiso
Copy link
Contributor

@dosiso dosiso commented Oct 20, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. 2022-11-01
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. 2022-11-01
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @dosiso Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 20, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 19 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.1)] new version base version
    AutomationRules.json 2022-11-01(ce2f697) 2022-08-01(main)
    AutomationRules.json 2022-11-01(ce2f697) 2022-10-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/incidents/{incidentIdentifier}/runPlaybook' removed or restructured?
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L220:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AutomationRuleBooleanCondition' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L282:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AutomationRuleBooleanConditionSupportedOperator' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L282:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AutomationRulePropertyArrayConditionSupportedArrayConditionType' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L282:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AutomationRulePropertyArrayConditionSupportedArrayType' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L282:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AutomationRulePropertyArrayValuesCondition' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L282:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'BooleanConditionProperties' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L282:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManualTriggerRequestBody' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L282:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PropertyArrayConditionProperties' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L224:3
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L282:3
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'PropertyArray, Boolean' from the old version.
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L291:9
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L388:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'IncidentCustomDetailsKey, IncidentCustomDetailsValue' from the old version.
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L531:5
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L686:5
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'IncidentCustomDetailsKey, IncidentCustomDetailsValue' from the old version.
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L847:9
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L1012:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'PropertyArray, Boolean' from the old version.
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L929:5
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L1111:5
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'PropertyArray, Boolean' from the old version.
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L291:9
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L388:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'PropertyArray, Boolean' from the old version.
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L291:9
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L388:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'PropertyArray, Boolean' from the old version.
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L291:9
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L388:9
    ⚠️ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L995:7
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L1199:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'logicAppResourceId' that was not found in the old version.
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L870:9
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L1035:9
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'logicAppResourceId' that was not found in the old version.
    New: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L990:5
    Old: Microsoft.SecurityInsights/preview/2022-10-01-preview/AutomationRules.json#L1197:5
    ️⚠️LintDiff: 7 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-11 package-2022-11(ce2f697) package-2022-11(release-securityinsights-Microsoft.SecurityInsights-2022-11-01)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ R4021 - DescriptionAndTitleMissing 'AutomationRulePropertyArrayChangedConditionSupportedArrayType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L370
    ⚠️ R4021 - DescriptionAndTitleMissing 'AutomationRulePropertyArrayChangedConditionSupportedChangeType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L402
    ⚠️ R4021 - DescriptionAndTitleMissing 'AutomationRulePropertyArrayChangedValuesCondition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L419
    ⚠️ R4021 - DescriptionAndTitleMissing 'AutomationRulePropertyChangedConditionSupportedChangedType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L430
    ⚠️ R4021 - DescriptionAndTitleMissing 'AutomationRulePropertyChangedConditionSupportedPropertyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L452
    ⚠️ R4021 - DescriptionAndTitleMissing 'AutomationRulePropertyValuesChangedCondition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L824
    ⚠️ R4021 - DescriptionAndTitleMissing 'propertyValues' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L836


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R3017 - GuidUsage Guid used in model definition 'PlaybookActionProperties' for property 'tenantId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L1000
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L901
    ⚠️ R4006 - DeprecatedXmsCodeGenerationSetting The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L7
    ⚠️ R4021 - DescriptionAndTitleMissing 'AutomationRule' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L248
    ⚠️ R4021 - DescriptionAndTitleMissing 'order' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L274
    ⚠️ R4021 - DescriptionAndTitleMissing 'AutomationRulePropertyConditionSupportedOperator' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L479
    ⚠️ R4021 - DescriptionAndTitleMissing 'AutomationRulePropertyValuesCondition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L844
    ⚠️ R4021 - DescriptionAndTitleMissing 'propertyValues' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L853
    ⚠️ R4021 - DescriptionAndTitleMissing 'AutomationRulesList' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L878
    ⚠️ R4021 - DescriptionAndTitleMissing 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L881
    ⚠️ R4021 - DescriptionAndTitleMissing 'nextLink' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L887
    ⚠️ R4021 - DescriptionAndTitleMissing 'ConditionType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L929
    ⚠️ R4021 - DescriptionAndTitleMissing 'IncidentPropertiesAction' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L956
    ⚠️ R4021 - DescriptionAndTitleMissing 'PlaybookActionProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L990
    ⚠️ R4021 - DescriptionAndTitleMissing 'triggersOn' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L1058
    ⚠️ R4021 - DescriptionAndTitleMissing 'triggersWhen' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.SecurityInsights/stable/2022-11-01/AutomationRules.json#L1080
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 20, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking


    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 30243a8bc00c985e3bf72647b255dfc0ac93f89f. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.SecurityInsights [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 30243a8bc00c985e3bf72647b255dfc0ac93f89f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.15.0 -> 8.19.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group SecurityMLAnalyticsSettingsOperations
      info	[Changelog]   - Model FusionAlertRule has a new parameter techniques
      info	[Changelog]   - Model FusionAlertRuleTemplate has a new parameter techniques
      info	[Changelog]   - Model IncidentOwnerInfo has a new parameter owner_type
      info	[Changelog]   - Model ScheduledAlertRule has a new parameter techniques
      info	[Changelog]   - Model ScheduledAlertRuleProperties has a new parameter techniques
      info	[Changelog]   - Model ScheduledAlertRuleTemplate has a new parameter techniques
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 30243a8bc00c985e3bf72647b255dfc0ac93f89f. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-securityinsight [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 30243a8bc00c985e3bf72647b255dfc0ac93f89f. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-securityinsights [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 30243a8bc00c985e3bf72647b255dfc0ac93f89f. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️securityinsights [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from 30243a8bc00c985e3bf72647b255dfc0ac93f89f. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.securityinsights [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 20, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-securityinsight Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-securityinsight Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 20, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @dosiso your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @dosiso dosiso marked this pull request as ready for review October 20, 2022 10:00
    @rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 21, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 21, 2022
    @dosiso
    Copy link
    Contributor Author

    dosiso commented Oct 24, 2022

    @dw511214992 can we go ahead & merge PR?

    @dosiso dosiso requested a review from anat-gilenson October 24, 2022 08:10
    @dw511214992 dw511214992 merged commit 9ab5c65 into Azure:release-securityinsights-Microsoft.SecurityInsights-2022-11-01 Oct 24, 2022
    dw511214992 pushed a commit that referenced this pull request Nov 21, 2022
    * Adds base for updating Microsoft.SecurityInsights from version stable/2022-08-01 to version 2022-11-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * SecurityMLAnalyticsSettings to Microsoft.SecurityInsights-2022-11-01-stable (#20944)
    
    * update
    
    * update api versions
    
    * Automation rules 2022-11-01 - alert & update triggers (#21205)
    
    * Automation rules 2022-11-01 stable version
    
    * preetier
    
    * Remove unused url parameters
    
    Co-authored-by: jungph808 <[email protected]>
    Co-authored-by: Dor Siso <[email protected]>
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    …e#21540)
    
    * Adds base for updating Microsoft.SecurityInsights from version stable/2022-08-01 to version 2022-11-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * SecurityMLAnalyticsSettings to Microsoft.SecurityInsights-2022-11-01-stable (Azure#20944)
    
    * update
    
    * update api versions
    
    * Automation rules 2022-11-01 - alert & update triggers (Azure#21205)
    
    * Automation rules 2022-11-01 stable version
    
    * preetier
    
    * Remove unused url parameters
    
    Co-authored-by: jungph808 <[email protected]>
    Co-authored-by: Dor Siso <[email protected]>
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    …e#21540)
    
    * Adds base for updating Microsoft.SecurityInsights from version stable/2022-08-01 to version 2022-11-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * SecurityMLAnalyticsSettings to Microsoft.SecurityInsights-2022-11-01-stable (Azure#20944)
    
    * update
    
    * update api versions
    
    * Automation rules 2022-11-01 - alert & update triggers (Azure#21205)
    
    * Automation rules 2022-11-01 stable version
    
    * preetier
    
    * Remove unused url parameters
    
    Co-authored-by: jungph808 <[email protected]>
    Co-authored-by: Dor Siso <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants