Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed static IP allocation only from examples #19858

Merged

Conversation

arpit-gagneja
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify: remove unsupported enum value
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. Planned GA in September
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @arpit-gagneja Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 20, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 20, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - armdnsresolver - 1.0.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-dnsresolver - 1.0.0b1
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from bd05dd0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-dnsresolver [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model DnsForwardingRulesetPatch has a new parameter dns_resolver_outbound_endpoints
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter dns_resolver_outbound_endpoints of model DnsForwardingRuleset is now required
      info	[Changelog]   - Parameter domain_name of model ForwardingRule is now required
      info	[Changelog]   - Parameter id of model SubResource is now required
      info	[Changelog]   - Parameter ip_address of model TargetDnsServer is now required
      info	[Changelog]   - Parameter ip_configurations of model InboundEndpoint is now required
      info	[Changelog]   - Parameter subnet of model IpConfiguration is now required
      info	[Changelog]   - Parameter subnet of model OutboundEndpoint is now required
      info	[Changelog]   - Parameter target_dns_servers of model ForwardingRule is now required
      info	[Changelog]   - Parameter virtual_network of model DnsResolver is now required
      info	[Changelog]   - Parameter virtual_network of model VirtualNetworkLink is now required
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from bd05dd0. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armdnsresolver [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `DNSResolverOutboundEndpoints` in struct `DNSForwardingRulesetPatch`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from bd05dd0. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.DnsResolver [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @arpit-gagneja, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @arpit-gagneja
    Copy link
    Contributor Author

    @ruowan : this is not a breaking change. we have not released any SDKs for stable version (GA) yet. we will be announcing the GA tentatively in the end of September this year. I will send an email including you to get an exemption from the breaking change board.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 20, 2022
    @ruowan ruowan merged commit bd05dd0 into Azure:main Jul 22, 2022
    akning-ms pushed a commit that referenced this pull request Aug 1, 2022
    * update folder structure
    
    * small errors and CI check
    
    * [Language Text] Update swagger titles (#19835)
    
    * [Language Text] Update swagger titles
    
    * edits
    
    * address feedback
    
    * Review request for Microsoft.ContainerService to add version 2022-06-01 (#19848)
    
    * Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * update readmes (#19421)
    
    * Add key management service profile of a managed cluster for version 2022-06-01 (#19529)
    
    * Add NetworkPlugin none option to 2022-06-01 (#19510)
    
    * Add NetworkPlugin none option to 2022-06-01
    
    * improve description for none value
    
    * Fix violated rule R4041 for 2022-06-01 managedCluster swagger (#19581)
    
    * remove useless directive
    
    * fix R4041
    
    * GA AKS support for Dedicated Host Group (#19547)
    
    * GA AKS support for Dedicated Host Group
    
    * fit some format minor issue
    
    * add newline in end of files
    
    * Defender updates (#19665)
    
    * Defender updates
    
    * sample
    
    * remove old description
    
    Co-authored-by: Bin Xia <[email protected]>
    Co-authored-by: Matt Stam <[email protected]>
    Co-authored-by: Jianping Zeng <[email protected]>
    Co-authored-by: Or Parnes <[email protected]>
    
    * Update resources.json (#19861)
    
    * Pattts/predictive autoscale 20221001 (#19765)
    
    * Rev Autoscale API from 2021-05-01-preview to 2022-10-01.
    
    * Fix minor swagger issue. Default should be 'false'
    
    * Fix swagger validation error
    
    * Defining a new package 2022-10
    
    * AutoscaleSettingResource now reference allOf 'resource' which is the actual autoscaleSetting resource definition
    
    * Fix require property issue
    
    * Run prettier against autoscale_API.json
    
    * [Maps - Render & Spatial Services] add v2022-08-01 (#19520)
    
    * copy old swagger to new folders
    
    * set api version to 2022-08-01
    
    * apply api changes
    
    Co-authored-by: Gigi Grajo <[email protected]>
    
    * update appconfiguration (#19330)
    
    * update appconfiguration
    
    * Update readme.python.md
    
    * Update readme.python.md
    
    * Update readme.python.md
    
    * Update readme.python.md
    
    * Update readme.python.md
    
    * Update readme.python.md
    
    * Update readme.python.md
    
    * [Hub Generated] Publish private branch 'main' (#19852)
    
    * Add StorageMover specification for PubliC Preview
    
    * SpellCheck fix
    
    * Update custom-words
    
    * Update specification/storagemover/resource-manager/readme.md
    
    Co-authored-by: Abhishek Krishna <[email protected]>
    Co-authored-by: Dapeng Zhang <[email protected]>
    
    * Merging Dynatrace swagger in stable folder (#19862)
    
    * Committing base swagger version
    
    * Removing preview tag from stable folder api version
    
    * Changing version name in all the files
    
    * Updating readme.go and readme.md files
    
    * [CDN] Fix customDomains property type in Endpoint (#19788)
    
    * [CDN] Fix customDomains property type in Endpoint
    
    * Fix linter error
    
    Co-authored-by: Bo Zhang <[email protected]>
    
    * Adding Microsoft.Sql AdvancedThreatProtectionSettings APIs for MI on v5 tag for 2022-02-01-preview (#19866)
    
    * update folders
    
    * [Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 (#19844)
    
    * Update description of exportable attribute and release_policy.data
    
    * Remove submodule azure-reset-api-specs
    
    * Fix description for exportable
    
    Co-authored-by: Sunny Solanki <[email protected]>
    
    * Add latest StorageMover updates (#19876)
    
    * Add StorageMover specification for PubliC Preview
    
    * SpellCheck fix
    
    * Update custom-words
    
    * Update specification/storagemover/resource-manager/readme.md
    
    * Add latest StorageMover updates
    
    Co-authored-by: Abhishek Krishna <[email protected]>
    Co-authored-by: Dapeng Zhang <[email protected]>
    
    * Update readme.python.md (#19899)
    
    * Update readme.python.md
    
    * Update readme.md
    
    * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review (#19878)
    
    * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review
    
    * Add known words
    
    * Removed static IP allocation only from examples (#19858)
    
    * Removed static IP allocation
    
    * Removed static only from examples
    
    Co-authored-by: Arpit Gagneja <[email protected]>
    
    * Update securityinsights readme.python (#19903)
    
    * update securityinsights readme.python
    
    * Update readme.python.md
    
    Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>
    
    * fix lint errors in Synapse trigger.json (#19660)
    
    * put json files into RP folders
    
    * update readme
    
    * Add CONTRIBUTING.md (#19257)
    
    * Add CONTRIBUTING.md
    
    * Apply suggestions from PR review
    
    Co-authored-by: Heath Stewart <[email protected]>
    
    * Apply suggestions from PR review
    
    Co-authored-by: Weidong Xu <[email protected]>
    
    * Regen toc for CONTRIBUTING.md
    
    * Address PR review comments
    
    * Address PR review comments
    
    Co-authored-by: Heath Stewart <[email protected]>
    Co-authored-by: Weidong Xu <[email protected]>
    
    * fix devcenter readme.go.md config (#19906)
    
    * fix readme.go.md config
    
    * rename to SkuInfo
    
    * add annotation for labservices (#19884)
    
    * add to description of OS state (#19764)
    
    * [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#19767)
    
    * Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item
    
    * Update managed hsm private endpoint connection item in mhsm spec for latest api version
    
    * Address LRO_RESPONSE_HEADER violation for managed hsm
    
    Long running operations that are annotated with x-ms-long-running-operation:true
    must return location header or azure-AsyncOperation in response.
    Added the missing location header for managed hsm update command as well as to the corresponding
    examples.
    
    * [Microsoft.DeviceUpdate] Adding first stable API version (#19846)
    
    * Copied the most recent preview version into the first stable version
    
    * Updated api version in new stable version, added the tag to readme.md
    
    * Fixed typo
    
    * Fixed the wrong path in readme.md
    
    * Reverted VS Code automatic breaking change
    
    * Fix broken link (#19688)
    
    * add aadObjectId property to kustoPool (#19856)
    
    Co-authored-by: Amit Elran <[email protected]>
    
    * Updata securityinsights readme.python (#19917)
    
    * update securityinsights readme.python
    
    * update readme.python
    
    Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>
    
    * modify readme.typescripy.md for compute package (#19607)
    
    Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
    
    * Dev gubalasu frontdoor microsoft.network 2021 06 01 (#19578)
    
    * Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2021-06-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * update waf configs and examples from 2020-11-01
    
    * Update api version in new specs and examples
    
    * Migration api update
    
    * Update readme
    
    * Fix readme
    
    * update readme
    
    * Fix readme again
    
    * Fix readme
    
    * Fix readme
    
    * update waf policy provisioning state
    
    * Update securityinsights readme.python (#19923)
    
    * update securityinsights readme.python
    
    * update readme.python
    
    * last modify
    
    * Update readme.python.md
    
    Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>
    
    * sync with changes made to master
    
    * update folder structure
    
    * small errors and CI check
    
    * update folders
    
    * put json files into RP folders
    
    * update readme
    
    * resolve capitalization and number misplacement accident
    
    Co-authored-by: Theodore Chang <[email protected]>
    Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
    Co-authored-by: FumingZhang <[email protected]>
    Co-authored-by: Bin Xia <[email protected]>
    Co-authored-by: Matt Stam <[email protected]>
    Co-authored-by: Jianping Zeng <[email protected]>
    Co-authored-by: Or Parnes <[email protected]>
    Co-authored-by: Alexander Batishchev <[email protected]>
    Co-authored-by: PatrickTseng <[email protected]>
    Co-authored-by: gigi <[email protected]>
    Co-authored-by: Gigi Grajo <[email protected]>
    Co-authored-by: zhenbiao wei <[email protected]>
    Co-authored-by: Abhishek Krishna <[email protected]>
    Co-authored-by: Abhishek Krishna <[email protected]>
    Co-authored-by: Dapeng Zhang <[email protected]>
    Co-authored-by: Divyansh Agarwal <[email protected]>
    Co-authored-by: t-bzhan <[email protected]>
    Co-authored-by: Bo Zhang <[email protected]>
    Co-authored-by: Uriel Cohen <[email protected]>
    Co-authored-by: susolank <[email protected]>
    Co-authored-by: Sunny Solanki <[email protected]>
    Co-authored-by: Ralf Beckers <[email protected]>
    Co-authored-by: arpit-gagneja <[email protected]>
    Co-authored-by: Arpit Gagneja <[email protected]>
    Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>
    Co-authored-by: YanjunGao <[email protected]>
    Co-authored-by: Mike Kistler <[email protected]>
    Co-authored-by: Heath Stewart <[email protected]>
    Co-authored-by: Weidong Xu <[email protected]>
    Co-authored-by: Jiahui Peng <[email protected]>
    Co-authored-by: j-zhong-ms <[email protected]>
    Co-authored-by: Tom FitzMacken <[email protected]>
    Co-authored-by: neeerajaakula <[email protected]>
    Co-authored-by: darkoa-msft <[email protected]>
    Co-authored-by: Roy Wellington <[email protected]>
    Co-authored-by: Amit Elran <[email protected]>
    Co-authored-by: Amit Elran <[email protected]>
    Co-authored-by: kazrael2119 <[email protected]>
    Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
    Co-authored-by: gubalasu <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants