Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KustoPool: Add aadObjectId property #19856

Merged
merged 1 commit into from
Jul 25, 2022
Merged

KustoPool: Add aadObjectId property #19856

merged 1 commit into from
Jul 25, 2022

Conversation

amitelran
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@amitelran amitelran requested a review from wonner as a code owner July 20, 2022 14:56
@openapi-workflow-bot
Copy link

Hi, @amitelran Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 20, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    kustoPool.json 2021-06-01(ae523a2) 2021-06-01(main)
    Rule Message
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'aadObjectId' in response that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L3551:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L3551:7
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'aadObjectId' in response that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L3674:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L3669:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'aadObjectId' that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L3551:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L3551:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'aadObjectId' that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L3674:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L3669:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-composite-v2 package-composite-v2(ae523a2) package-composite-v2(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L182
    ❌ R4039 - ParametersOrder The parameters:workspaceName,resourceGroupName,kustoPoolName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L225
    ❌ R4039 - ParametersOrder The parameters:workspaceName,resourceGroupName,kustoPoolName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L300
    ❌ R4039 - ParametersOrder The parameters:workspaceName,resourceGroupName,kustoPoolName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L367
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L416
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L462
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L508
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L556
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L614
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L662
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L717
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L772
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L820
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L875
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,attachedDatabaseConfigurationName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L923
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,attachedDatabaseConfigurationName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L969
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,attachedDatabaseConfigurationName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1037
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1765
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1819
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1867
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1913
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1975
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,databaseName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2027
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,databaseName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2084
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,databaseName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2135
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,databaseName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2184
    ❌ R4039 - ParametersOrder The parameters:workspaceName,kustoPoolName,databaseName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2249
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2309
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2383
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2420
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/synapse/resource-manager/readme.md
    tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L346:22
    ExampleUrl: preview/2021-06-01-preview/examples/KustoPoolsUpdate.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1285:22
    ExampleUrl: preview/2021-06-01-preview/examples/KustoPoolDatabasesUpdate.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1688:22
    ExampleUrl: preview/2021-06-01-preview/examples/KustoPoolDataConnectionsUpdate.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L346:22
    ExampleUrl: preview/2021-06-01-preview/examples/KustoPoolsUpdate.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1285:22
    ExampleUrl: preview/2021-06-01-preview/examples/KustoPoolDatabasesUpdate.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1688:22
    ExampleUrl: preview/2021-06-01-preview/examples/KustoPoolDataConnectionsUpdate.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 2 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/ae523a269ec6b3665790fc1fa1085dc95002d2ac/specification/synapse/resource-manager/readme.md#tag-package-composite-v2">synapse/resource-manager/readme.md#package-composite-v2
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ PreCheck/DuplicateSchema "readme":"synapse/resource-manager/readme.md",
    "tag":"package-composite-v2",
    "details":"Duplicate Schema named 'PrivateEndpointConnectionForPrivateLinkHubBasic' (5 differences):\n - properties.id.$ref: "#/components/schemas/schemas:93" => "#/components/schemas/schemas:1467"\n - properties.id.description: "identifier" =>\n - properties.id.readOnly: true =>\n - properties.properties.description: "Properties of private endpoint connection for private link hub" =>\n - properties.properties.x-ms-client-flatten: true =>"
    ⚠️ Modeler/MissingType "readme":"synapse/resource-manager/readme.md",
    "tag":"package-composite-v2",
    "details":"The schema 'KekIdentityProperties-useSystemAssignedIdentity' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/workspace.json#/components/schemas/KekIdentityProperties-useSystemAssignedIdentity"


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/resource-manager/readme.md",
    "tag":"package-composite-v2",
    "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink"
    ⚠️ PreNamer/DeduplicateName "readme":"synapse/resource-manager/readme.md",
    "tag":"package-composite-v2",
    "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'"
    ⚠️ PreNamer/DeduplicateName "readme":"synapse/resource-manager/readme.md",
    "tag":"package-composite-v2",
    "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'"
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 20, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - armsynapse - 0.6.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.1.0b5
    ❌azure-sdk-for-js - @azure/arm-synapse - 9.0.0-beta.1
    ️❌ azure-sdk-for-net failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from 4c50e5a. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Failure during batch task - {"tag":"$(tag)"} -- false.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 4c50e5a. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  WARN deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh]  @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-synapse        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettings
info	[Changelog]   - Added Interface DedicatedSQLminimalTlsSettingsListResult
info	[Changelog]   - Added Interface DedicatedSQLminimalTlsSettingsPatchInfo
info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetOptionalParams
info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextOptionalParams
info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListOptionalParams
info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateOptionalParams
info	[Changelog]   - Added Type Alias ActualState
info	[Changelog]   - Added Type Alias DedicatedSQLminimalTlsSettings
info	[Changelog]   - Added Type Alias DedicatedSQLMinimalTlsSettingsName
info	[Changelog]   - Added Type Alias DesiredState
info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetResponse
info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextResponse
info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListResponse
info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateResponse
info	[Changelog]   - Class SynapseManagementClient has a new parameter workspaceManagedSqlServerDedicatedSQLMinimalTlsSettings
info	[Changelog]   - Type Alias ClusterPrincipalAssignment has a new parameter aadObjectId
info	[Changelog]   - Type Alias DatabasePrincipalAssignment has a new parameter aadObjectId
info	[Changelog]   - Added Enum KnownDedicatedSQLMinimalTlsSettingsName
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState
info	[Changelog]   - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]  
  
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 4c50e5a. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] config global `--global`, `--local` are deprecated. Use `--location=global` instead.
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.15.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.15.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-synapse        [View full logs]         [Release SDK Changes]      
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ClusterPrincipalAssignment has a new parameter aad_object_id
info	[Changelog]   - Model DatabasePrincipalAssignment has a new parameter aad_object_id
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 4c50e5a. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armsynapse        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentity.ActualState` has been changed from `*ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualState` to `*ActualState`
info	[Changelog] - Type of `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentity.DesiredState` has been changed from `*ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredState` to `*DesiredState`
info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredStateDisabled` has been removed
info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateEnabled` has been removed
info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateUnknown` has been removed
info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateDisabling` has been removed
info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateDisabled` has been removed
info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredStateEnabled` has been removed
info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateEnabling` has been removed
info	[Changelog] - Function `PossibleManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredStateValues` has been removed
info	[Changelog] - Function `PossibleManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateValues` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `DesiredStateEnabled`
info	[Changelog] - New const `ActualStateDisabled`
info	[Changelog] - New const `ActualStateDisabling`
info	[Changelog] - New const `DesiredStateDisabled`
info	[Changelog] - New const `ActualStateEnabling`
info	[Changelog] - New const `ActualStateEnabled`
info	[Changelog] - New const `ActualStateUnknown`
info	[Changelog] - New function `PossibleActualStateValues() []ActualState`
info	[Changelog] - New function `PossibleDesiredStateValues() []DesiredState`
info	[Changelog] - New field `AADObjectID` in struct `ClusterPrincipalProperties`
info	[Changelog] - New field `AADObjectID` in struct `DatabasePrincipalProperties`
info	[Changelog]
info	[Changelog] Total 10 breaking change(s), 11 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 4c50e5a. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️synapse        [View full logs]       
    ️❌ azure-powershell failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from 4c50e5a. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.synapse        [View full logs]         [Release SDK Changes]      
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi @amitelran, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.  
    TaskHow to fixPriority
     
    AvocadoFix-AvocadoHigh
     
    Semantic validationFix-SemanticValidation-ErrorHigh
     
    Model validationFix-ModelValidation-ErrorHigh
     
    LintDiffFix-LintDiffhigh
      If you need further help, please feedback via swagger feedback.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    NewApiVersionRequired reason:
     
    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.  

     EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
          
    
  
    
    
  
    

  
    
      
    
    @azure-sdk
azure-sdk



    mentioned this pull request
    
      Jul 20, 2022
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
  This was referenced Jul 20, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
    @azure-sdk
azure-sdk



    mentioned this pull request
    
      Jul 20, 2022
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    




    

      
    
  
        



    

      
    
  
            
    
    
    
      
    
    
    
    

      

          @JeffreyRichter
JeffreyRichter




          added
  the 

  Approved-BreakingChange

  DO NOT USE! OBSOLETE label. See  https://github.com/Azure/azure-sdk-tools/issues/6374
 label


      Jul 22, 2022

    
    
  
    





    

      
    
  
        



    

      
    
  
            


  
    
  
    
    
  
    
  
    


        @ruowan
  ruowan



        merged commit 4c50e5a
      into

      
  
    main
  


    Jul 25, 2022

  
    

    


    

  
    
  
  
    
  
          @ruowan
  ruowan


    
    deleted the
    
      
        user/amelran/kustopool-aadobjectid-property
    
    branch

    July 25, 2022 03:39    
    

    

    
  
    
  
    
    
  
    

  
    
      
    
  This was referenced Jul 25, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

  

    
  
    
  
  
    
    
  akning-ms 

      pushed a commit
      that referenced
      this pull request

    
      Aug 1, 2022
    
    
    
      

    
  
    
    
    
      

    
  
    
      
        @grizzlytheodore
      
        @deyaaeldeen
        
    
      
        @FumingZhang
      
        @bingosummer
      
        @mattstam
      
        @zjpjack
      
        @orparnes
      
        @abatishchev
      
        @PatrickTseng
      
        @gigigoo0
      
        @Wzb123456789
      
        @AbhishekKrishna123
      
        @ArcturusZhang
      
        @divyansh3131
      
        @t-bzhan
      
        @cohen-uriel-ms
      
        @susolank
      
        @bexxx
      
        @arpit-gagneja
      
        @argagnej
      
        @yanjungao718
      
        @mikekistler
      
        @heaths
      
        @weidongxu-microsoft
      
        @Alancere
      
        @j-zhong-ms
      
        @tfitzmac
      
        @neeerajaakula
      
        @darkoa-msft
      
        @roy-work
      
        @amitelran
      
        @kazrael2119
      
        @gubalasu
  
    

    


      
    
        
          Compute update folder structure (#19723)
        

          
            
          

      
    

      
    
          

    
    
    

  

    


      
    

      
    
      
    

      
      
    
        
          2dcad6d
        
      
    
    
    
  
    
    
    
      
    * update folder structure

* small errors and CI check

* [Language Text] Update swagger titles (#19835)

* [Language Text] Update swagger titles

* edits

* address feedback

* Review request for Microsoft.ContainerService to add version 2022-06-01 (#19848)

* Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01

* Updates readme

* Updates API version in new specs and examples

* update readmes (#19421)

* Add key management service profile of a managed cluster for version 2022-06-01 (#19529)

* Add NetworkPlugin none option to 2022-06-01 (#19510)

* Add NetworkPlugin none option to 2022-06-01

* improve description for none value

* Fix violated rule R4041 for 2022-06-01 managedCluster swagger (#19581)

* remove useless directive

* fix R4041

* GA AKS support for Dedicated Host Group (#19547)

* GA AKS support for Dedicated Host Group

* fit some format minor issue

* add newline in end of files

* Defender updates (#19665)

* Defender updates

* sample

* remove old description

Co-authored-by: Bin Xia <[email protected]>
Co-authored-by: Matt Stam <[email protected]>
Co-authored-by: Jianping Zeng <[email protected]>
Co-authored-by: Or Parnes <[email protected]>

* Update resources.json (#19861)

* Pattts/predictive autoscale 20221001 (#19765)

* Rev Autoscale API from 2021-05-01-preview to 2022-10-01.

* Fix minor swagger issue. Default should be 'false'

* Fix swagger validation error

* Defining a new package 2022-10

* AutoscaleSettingResource now reference allOf 'resource' which is the actual autoscaleSetting resource definition

* Fix require property issue

* Run prettier against autoscale_API.json

* [Maps - Render & Spatial Services] add v2022-08-01 (#19520)

* copy old swagger to new folders

* set api version to 2022-08-01

* apply api changes

Co-authored-by: Gigi Grajo <[email protected]>

* update appconfiguration (#19330)

* update appconfiguration

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* [Hub Generated] Publish private branch 'main' (#19852)

* Add StorageMover specification for PubliC Preview

* SpellCheck fix

* Update custom-words

* Update specification/storagemover/resource-manager/readme.md

Co-authored-by: Abhishek Krishna <[email protected]>
Co-authored-by: Dapeng Zhang <[email protected]>

* Merging Dynatrace swagger in stable folder (#19862)

* Committing base swagger version

* Removing preview tag from stable folder api version

* Changing version name in all the files

* Updating readme.go and readme.md files

* [CDN] Fix customDomains property type in Endpoint (#19788)

* [CDN] Fix customDomains property type in Endpoint

* Fix linter error

Co-authored-by: Bo Zhang <[email protected]>

* Adding Microsoft.Sql AdvancedThreatProtectionSettings APIs for MI on v5 tag for 2022-02-01-preview (#19866)

* update folders

* [Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 (#19844)

* Update description of exportable attribute and release_policy.data

* Remove submodule azure-reset-api-specs

* Fix description for exportable

Co-authored-by: Sunny Solanki <[email protected]>

* Add latest StorageMover updates (#19876)

* Add StorageMover specification for PubliC Preview

* SpellCheck fix

* Update custom-words

* Update specification/storagemover/resource-manager/readme.md

* Add latest StorageMover updates

Co-authored-by: Abhishek Krishna <[email protected]>
Co-authored-by: Dapeng Zhang <[email protected]>

* Update readme.python.md (#19899)

* Update readme.python.md

* Update readme.md

* Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review (#19878)

* Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review

* Add known words

* Removed static IP allocation only from examples (#19858)

* Removed static IP allocation

* Removed static only from examples

Co-authored-by: Arpit Gagneja <[email protected]>

* Update securityinsights readme.python (#19903)

* update securityinsights readme.python

* Update readme.python.md

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>

* fix lint errors in Synapse trigger.json (#19660)

* put json files into RP folders

* update readme

* Add CONTRIBUTING.md (#19257)

* Add CONTRIBUTING.md

* Apply suggestions from PR review

Co-authored-by: Heath Stewart <[email protected]>

* Apply suggestions from PR review

Co-authored-by: Weidong Xu <[email protected]>

* Regen toc for CONTRIBUTING.md

* Address PR review comments

* Address PR review comments

Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>

* fix devcenter readme.go.md config (#19906)

* fix readme.go.md config

* rename to SkuInfo

* add annotation for labservices (#19884)

* add to description of OS state (#19764)

* [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#19767)

* Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item

* Update managed hsm private endpoint connection item in mhsm spec for latest api version

* Address LRO_RESPONSE_HEADER violation for managed hsm

Long running operations that are annotated with x-ms-long-running-operation:true
must return location header or azure-AsyncOperation in response.
Added the missing location header for managed hsm update command as well as to the corresponding
examples.

* [Microsoft.DeviceUpdate] Adding first stable API version (#19846)

* Copied the most recent preview version into the first stable version

* Updated api version in new stable version, added the tag to readme.md

* Fixed typo

* Fixed the wrong path in readme.md

* Reverted VS Code automatic breaking change

* Fix broken link (#19688)

* add aadObjectId property to kustoPool (#19856)

Co-authored-by: Amit Elran <[email protected]>

* Updata securityinsights readme.python (#19917)

* update securityinsights readme.python

* update readme.python

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>

* modify readme.typescripy.md for compute package (#19607)

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>

* Dev gubalasu frontdoor microsoft.network 2021 06 01 (#19578)

* Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2021-06-01

* Updates readme

* Updates API version in new specs and examples

* update waf configs and examples from 2020-11-01

* Update api version in new specs and examples

* Migration api update

* Update readme

* Fix readme

* update readme

* Fix readme again

* Fix readme

* Fix readme

* update waf policy provisioning state

* Update securityinsights readme.python (#19923)

* update securityinsights readme.python

* update readme.python

* last modify

* Update readme.python.md

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>

* sync with changes made to master

* update folder structure

* small errors and CI check

* update folders

* put json files into RP folders

* update readme

* resolve capitalization and number misplacement accident

Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: FumingZhang <[email protected]>
Co-authored-by: Bin Xia <[email protected]>
Co-authored-by: Matt Stam <[email protected]>
Co-authored-by: Jianping Zeng <[email protected]>
Co-authored-by: Or Parnes <[email protected]>
Co-authored-by: Alexander Batishchev <[email protected]>
Co-authored-by: PatrickTseng <[email protected]>
Co-authored-by: gigi <[email protected]>
Co-authored-by: Gigi Grajo <[email protected]>
Co-authored-by: zhenbiao wei <[email protected]>
Co-authored-by: Abhishek Krishna <[email protected]>
Co-authored-by: Abhishek Krishna <[email protected]>
Co-authored-by: Dapeng Zhang <[email protected]>
Co-authored-by: Divyansh Agarwal <[email protected]>
Co-authored-by: t-bzhan <[email protected]>
Co-authored-by: Bo Zhang <[email protected]>
Co-authored-by: Uriel Cohen <[email protected]>
Co-authored-by: susolank <[email protected]>
Co-authored-by: Sunny Solanki <[email protected]>
Co-authored-by: Ralf Beckers <[email protected]>
Co-authored-by: arpit-gagneja <[email protected]>
Co-authored-by: Arpit Gagneja <[email protected]>
Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>
Co-authored-by: YanjunGao <[email protected]>
Co-authored-by: Mike Kistler <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: Jiahui Peng <[email protected]>
Co-authored-by: j-zhong-ms <[email protected]>
Co-authored-by: Tom FitzMacken <[email protected]>
Co-authored-by: neeerajaakula <[email protected]>
Co-authored-by: darkoa-msft <[email protected]>
Co-authored-by: Roy Wellington <[email protected]>
Co-authored-by: Amit Elran <[email protected]>
Co-authored-by: Amit Elran <[email protected]>
Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
Co-authored-by: gubalasu <[email protected]>
    
    
    

    

    
    
  
    

    

  



    



        
    
  
          
  
  



    



  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
      @ruowan
  
    ruowan



          
            
              
            
          
          ruowan approved these changes

        
    
        
    
          

  
      @wonner
  
    wonner



          
            
              
            
          
          wonner approved these changes

        
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
      @ruowan
  
    ruowan
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    Approved-BreakingChange

  DO NOT USE! OBSOLETE label. See  https://github.com/Azure/azure-sdk-tools/issues/6374
  

    Approved-ModelValidation

  

    CI-BreakingChange-Go

  

    CI-BreakingChange-JavaScript

  

    CI-FixRequiredOnFailure



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

        
          

    

  
      
    
  
    
    
    
      4 participants
    
    
    
    
        
          @amitelran 
        
          @wonner 
        
          @ruowan 
        
          @JeffreyRichter