Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataBox Api version upgrade to 2022-02-01 #18285

Closed
wants to merge 4 commits into from
Closed

Conversation

sashanm
Copy link
Contributor

@sashanm sashanm commented Mar 16, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@ruowan ruowan self-assigned this Mar 18, 2022
@ruowan
Copy link
Member

ruowan commented Mar 18, 2022

/azp run

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 18, 2022

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 0 Warnings warning [Detail]
The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Jobs_Get' is not read only. Please add the readonly for the systemData.
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L502
R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Jobs_Create' is not read only. Please add the readonly for the systemData.
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L567
R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Jobs_Update' is not read only. Please add the readonly for the systemData.
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L688
R4039 - ParametersOrder The parameters:jobName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L113
R4039 - ParametersOrder The parameters:jobName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L167
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L1072
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L1148
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L1287
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L1371
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L1383
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L1434
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L2123
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L2157
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L2798
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L2840
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L2910
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L2934
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L2959
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L2972
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L2995
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L3019
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L3058
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L3071
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L3188
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L3195
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L3411
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L3556
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L3582
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L3589
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.DataBox/stable/2022-02-01/databox.json#L3632
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 18, 2022

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armdatabox - 0.5.0
azure-sdk-for-python-track2 - track2_azure-mgmt-databox - 1.0.0
️✔️azure-sdk-for-go - databox/mgmt/2022-02-01/databox - v63.3.0
️✔️azure-sdk-for-go - databox/mgmt/2021-12-01/databox - v63.3.0
️✔️azure-sdk-for-go - databox/mgmt/2021-05-01/databox - v63.3.0
️✔️azure-sdk-for-go - databox/mgmt/2021-03-01/databox - v63.3.0
azure-sdk-for-go - databox/mgmt/2020-11-01/databox - v63.3.0
+	Const `ShareDestinationFormatTypeAzurePremiumFiles` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `DiskJobDetails` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `DiskScheduleAvailabilityRequest` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `HeavyJobDetails` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `JobDetailsType` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `JobDetails` has been removed
+	Field `ForwardDcAccessCode` of struct `DcAccessSecurityCode` has been removed
+	Field `ReverseDcAccessCode` of struct `DcAccessSecurityCode` has been removed
azure-sdk-for-go - databox/mgmt/2020-04-01/databox - v63.3.0
+	Field `ExpectedDataSizeInTerabytes` of struct `DiskJobDetails` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `DiskScheduleAvailabilityRequest` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `HeavyJobDetails` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `JobDetailsType` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `JobDetails` has been removed
+	Field `ForwardDcAccessCode` of struct `DcAccessSecurityCode` has been removed
+	Field `ReverseDcAccessCode` of struct `DcAccessSecurityCode` has been removed
azure-sdk-for-go - databox/mgmt/2019-09-01/databox - v63.3.0
+	Field `ExpectedDataSizeInTerabytes` of struct `DiskJobDetails` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `DiskScheduleAvailabilityRequest` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `HeavyJobDetails` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `JobDetailsType` has been removed
+	Field `ExpectedDataSizeInTerabytes` of struct `JobDetails` has been removed
+	Field `ForwardDcAccessCode` of struct `DcAccessSecurityCode` has been removed
+	Field `ReverseDcAccessCode` of struct `DcAccessSecurityCode` has been removed
️✔️azure-sdk-for-go - databox/mgmt/2018-01-01/databox - v63.3.0
️✔️azure-sdk-for-go - preview/databox/mgmt/2021-08-01-preview/databox - v63.3.0
️❌ azure-sdk-for-net failed [Detail]
  • Failed [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-6.0
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/databox/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] No usable version of the libssl was found
    cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
    cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
    cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
    warn	Skip package processing as generation is failed
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.0 -> 8.7.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.7.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-databox [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation JobsOperations.mark_devices_shipped
    info	[Changelog]   - Added operation group DataBoxManagementClientOperationsMixin
    info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter actions
    info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter data_center_code
    info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter datacenter_address
    info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter device_erasure_details
    info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter expected_data_size_in_tera_bytes
    info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter granular_copy_progress
    info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter last_mitigation_action_on_job
    info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter actions
    info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter data_center_code
    info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter datacenter_address
    info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter device_erasure_details
    info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter expected_data_size_in_tera_bytes
    info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter last_mitigation_action_on_job
    info	[Changelog]   - Model DataBoxJobDetails has a new parameter actions
    info	[Changelog]   - Model DataBoxJobDetails has a new parameter data_center_code
    info	[Changelog]   - Model DataBoxJobDetails has a new parameter datacenter_address
    info	[Changelog]   - Model DataBoxJobDetails has a new parameter device_erasure_details
    info	[Changelog]   - Model DataBoxJobDetails has a new parameter expected_data_size_in_tera_bytes
    info	[Changelog]   - Model DataBoxJobDetails has a new parameter last_mitigation_action_on_job
    info	[Changelog]   - Model DataImportDetails has a new parameter log_collection_level
    info	[Changelog]   - Model JobDetails has a new parameter actions
    info	[Changelog]   - Model JobDetails has a new parameter data_center_code
    info	[Changelog]   - Model JobDetails has a new parameter datacenter_address
    info	[Changelog]   - Model JobDetails has a new parameter device_erasure_details
    info	[Changelog]   - Model JobDetails has a new parameter expected_data_size_in_tera_bytes
    info	[Changelog]   - Model JobDetails has a new parameter last_mitigation_action_on_job
    info	[Changelog]   - Model JobResource has a new parameter system_data
    info	[Changelog]   - Model Preferences has a new parameter storage_account_access_tier_preferences
    info	[Changelog]   - Model RegionConfigurationRequest has a new parameter datacenter_address_request
    info	[Changelog]   - Model RegionConfigurationResponse has a new parameter datacenter_address_response
    info	[Changelog]   - Model UpdateJobDetails has a new parameter return_to_customer_package_details
    info	[Changelog]
    info	[Changelog] **Breaking changes**
    info	[Changelog]
    info	[Changelog]   - Model DataBoxDiskJobDetails no longer has parameter expected_data_size_in_terabytes
    info	[Changelog]   - Model DataBoxHeavyJobDetails no longer has parameter expected_data_size_in_terabytes
    info	[Changelog]   - Model DataBoxJobDetails no longer has parameter expected_data_size_in_terabytes
    info	[Changelog]   - Model DiskScheduleAvailabilityRequest has a new required parameter expected_data_size_in_tera_bytes
    info	[Changelog]   - Model DiskScheduleAvailabilityRequest no longer has parameter expected_data_size_in_terabytes
    info	[Changelog]   - Model JobDetails no longer has parameter expected_data_size_in_terabytes
️⚠️ azure-sdk-for-js warning [Detail]
  • ⚠️Warning [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    cmderr	[automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
    cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
    cmderr	[automation_init.sh]  @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
    cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-databox [View full logs]  [Preview SDK Changes]
    info	[Changelog]
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. SDK Automation 14.0.0
    command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️databox/mgmt/2022-02-01/databox [View full logs]  [Preview SDK Changes]
    info	[Changelog] This is a new package
    info	[Changelog]
  • ️✔️databox/mgmt/2021-12-01/databox [View full logs
    info	[Changelog] This is a new package
    info	[Changelog]
  • ️✔️databox/mgmt/2021-05-01/databox [View full logs
    info	[Changelog] This is a new package
    info	[Changelog]
  • ️✔️databox/mgmt/2021-03-01/databox [View full logs
    info	[Changelog] This is a new package
    info	[Changelog]
  • ️✔️databox/mgmt/2020-11-01/databox [View full logs
    Only show 14 items here, please refer to log for details.
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New function `SystemData.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New struct `SystemData`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskJobDetails`
    info	[Changelog] - New field `ReverseDCAccessCode` in struct `DcAccessSecurityCode`
    info	[Changelog] - New field `ForwardDCAccessCode` in struct `DcAccessSecurityCode`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `HeavyJobDetails`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetails`
    info	[Changelog] - New field `SystemData` in struct `JobResource`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskScheduleAvailabilityRequest`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetailsType`
    info	[Changelog]
    info	[Changelog] Total 7 breaking change(s), 10 additive change(s).
  • ️✔️databox/mgmt/2020-04-01/databox [View full logs
    Only show 14 items here, please refer to log for details.
    info	[Changelog] - Field `ExpectedDataSizeInTerabytes` of struct `HeavyJobDetails` has been removed
    info	[Changelog] - Field `ExpectedDataSizeInTerabytes` of struct `JobDetails` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetails`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskJobDetails`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetailsType`
    info	[Changelog] - New field `ReverseDCAccessCode` in struct `DcAccessSecurityCode`
    info	[Changelog] - New field `ForwardDCAccessCode` in struct `DcAccessSecurityCode`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `HeavyJobDetails`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskScheduleAvailabilityRequest`
    info	[Changelog]
    info	[Changelog] Total 6 breaking change(s), 6 additive change(s).
  • ️✔️databox/mgmt/2019-09-01/databox [View full logs
    Only show 14 items here, please refer to log for details.
    info	[Changelog] - Field `ExpectedDataSizeInTerabytes` of struct `JobDetailsType` has been removed
    info	[Changelog] - Field `ExpectedDataSizeInTerabytes` of struct `JobDetails` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskJobDetails`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetailsType`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `HeavyJobDetails`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetails`
    info	[Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskScheduleAvailabilityRequest`
    info	[Changelog] - New field `ForwardDCAccessCode` in struct `DcAccessSecurityCode`
    info	[Changelog] - New field `ReverseDCAccessCode` in struct `DcAccessSecurityCode`
    info	[Changelog]
    info	[Changelog] Total 6 breaking change(s), 6 additive change(s).
  • ️✔️databox/mgmt/2018-01-01/databox [View full logs
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️preview/databox/mgmt/2021-08-01-preview/databox [View full logs
    info	[Changelog] This is a new package
    info	[Changelog]
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️armdatabox [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New struct `DeviceErasureDetails`
    info	[Changelog] - New field `DeviceErasureDetails` in struct `CustomerDiskJobDetails`
    info	[Changelog] - New field `DeviceErasureDetails` in struct `DiskJobDetails`
    info	[Changelog] - New field `DeviceErasureDetails` in struct `HeavyJobDetails`
    info	[Changelog] - New field `DeviceErasureDetails` in struct `JobDetails`
    info	[Changelog] - New field `DeviceErasureDetails` in struct `CommonJobDetails`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 7 additive change(s).
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
    cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
    cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
    cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
  • ️✔️azure-resourcemanager-databox [View full logs]  [Preview SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  old lockfile
    cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
    cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
    cmderr	[initScript.sh] npm WARN old lockfile
    cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
    cmderr	[initScript.sh] npm WARN old lockfile
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️databox [View full logs]  [Preview Schema Changes]
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-workflow-bot
Copy link

Hi @sashanm, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

TaskHow to fixPriority
AvocadoFix-AvocadoHigh
Semantic validationFix-SemanticValidation-ErrorHigh
Model validationFix-ModelValidation-ErrorHigh
LintDiffFix-LintDiffhigh
If you need further help, please feedback via swagger feedback.

@vaishnavi-janardhan
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 18285 in repo Azure/azure-rest-api-specs

@vaishnavi-janardhan
Copy link
Contributor

Hi @ruowan, none of the failing checks seem to be arising due to the files being added in this PR. Could you please review the failing checks?

@ruowan
Copy link
Member

ruowan commented Apr 5, 2022

Pls ignore credScan failure. It's a false alarm, we are fixing it.

@ruowan ruowan added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 5, 2022
@vaishnavi-janardhan
Copy link
Contributor

vaishnavi-janardhan commented Apr 18, 2022

Dear review board, please find below certain observations on the CI failure

  • Swagger SDK breaking change tracking - This failure doesn't seem to be related to the changes in the current PR. We have been seeing the same failure in our previous PRs as well (PR upgrade to 2021-12-01)
  • SDK azure-sdk-for-net - 2 failures in this check were seen in the previous PR as well. The failures are with the test code in the azure-sdk-for-net repo. Should we modify the test code before the swagger PR gets checked in.

Could you please look into this and advise us on how to fix these failures? Thank you!

@mentat9
Copy link
Member

mentat9 commented Apr 18, 2022

@sashanm - Please either create your new API version PR using OpenAPIHub or manually create it using the PR format for new API versions:

  1. Copy all files from current API version to new API version folder.
  2. Create first commit.
  3. Apply changes for new API version in subsequent commits including updating API version in files.

@mentat9 mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 18, 2022
@vaishnavi-janardhan
Copy link
Contributor

@mentat9 I've created a new PR following the steps that you have mentioned above. Could you please review it?

`readme.python` has used track2 by default, so it no longer needs `track2` tag.
@mentat9
Copy link
Member

mentat9 commented Apr 21, 2022

@mentat9 I've created a new PR following the steps that you have mentioned above. Could you please review it?

Yes, I've added the new one to my queue. Please close this one.

@sashanm sashanm closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants