You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: ⚠️
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
Change to data plane APIs
Adding new properties
All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
+ Const `ShareDestinationFormatTypeAzurePremiumFiles` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `DiskJobDetails` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `DiskScheduleAvailabilityRequest` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `HeavyJobDetails` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `JobDetailsType` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `JobDetails` has been removed
+ Field `ForwardDcAccessCode` of struct `DcAccessSecurityCode` has been removed
+ Field `ReverseDcAccessCode` of struct `DcAccessSecurityCode` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `DiskJobDetails` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `DiskScheduleAvailabilityRequest` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `HeavyJobDetails` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `JobDetailsType` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `JobDetails` has been removed
+ Field `ForwardDcAccessCode` of struct `DcAccessSecurityCode` has been removed
+ Field `ReverseDcAccessCode` of struct `DcAccessSecurityCode` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `DiskJobDetails` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `DiskScheduleAvailabilityRequest` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `HeavyJobDetails` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `JobDetailsType` has been removed
+ Field `ExpectedDataSizeInTerabytes` of struct `JobDetails` has been removed
+ Field `ForwardDcAccessCode` of struct `DcAccessSecurityCode` has been removed
+ Field `ReverseDcAccessCode` of struct `DcAccessSecurityCode` has been removed
⚠️Warning [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. SDK Automation 14.0.0
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr [automation_generate.sh]
cmderr [automation_generate.sh] npm notice New minor version of npm available! 8.5.0 -> 8.7.0
cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.7.0>
cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr [automation_generate.sh] npm notice
info [Changelog] **Features**
info [Changelog]
info [Changelog] - Added operation JobsOperations.mark_devices_shipped
info [Changelog] - Added operation group DataBoxManagementClientOperationsMixin
info [Changelog] - Model DataBoxDiskJobDetails has a new parameter actions
info [Changelog] - Model DataBoxDiskJobDetails has a new parameter data_center_code
info [Changelog] - Model DataBoxDiskJobDetails has a new parameter datacenter_address
info [Changelog] - Model DataBoxDiskJobDetails has a new parameter device_erasure_details
info [Changelog] - Model DataBoxDiskJobDetails has a new parameter expected_data_size_in_tera_bytes
info [Changelog] - Model DataBoxDiskJobDetails has a new parameter granular_copy_progress
info [Changelog] - Model DataBoxDiskJobDetails has a new parameter last_mitigation_action_on_job
info [Changelog] - Model DataBoxHeavyJobDetails has a new parameter actions
info [Changelog] - Model DataBoxHeavyJobDetails has a new parameter data_center_code
info [Changelog] - Model DataBoxHeavyJobDetails has a new parameter datacenter_address
info [Changelog] - Model DataBoxHeavyJobDetails has a new parameter device_erasure_details
info [Changelog] - Model DataBoxHeavyJobDetails has a new parameter expected_data_size_in_tera_bytes
info [Changelog] - Model DataBoxHeavyJobDetails has a new parameter last_mitigation_action_on_job
info [Changelog] - Model DataBoxJobDetails has a new parameter actions
info [Changelog] - Model DataBoxJobDetails has a new parameter data_center_code
info [Changelog] - Model DataBoxJobDetails has a new parameter datacenter_address
info [Changelog] - Model DataBoxJobDetails has a new parameter device_erasure_details
info [Changelog] - Model DataBoxJobDetails has a new parameter expected_data_size_in_tera_bytes
info [Changelog] - Model DataBoxJobDetails has a new parameter last_mitigation_action_on_job
info [Changelog] - Model DataImportDetails has a new parameter log_collection_level
info [Changelog] - Model JobDetails has a new parameter actions
info [Changelog] - Model JobDetails has a new parameter data_center_code
info [Changelog] - Model JobDetails has a new parameter datacenter_address
info [Changelog] - Model JobDetails has a new parameter device_erasure_details
info [Changelog] - Model JobDetails has a new parameter expected_data_size_in_tera_bytes
info [Changelog] - Model JobDetails has a new parameter last_mitigation_action_on_job
info [Changelog] - Model JobResource has a new parameter system_data
info [Changelog] - Model Preferences has a new parameter storage_account_access_tier_preferences
info [Changelog] - Model RegionConfigurationRequest has a new parameter datacenter_address_request
info [Changelog] - Model RegionConfigurationResponse has a new parameter datacenter_address_response
info [Changelog] - Model UpdateJobDetails has a new parameter return_to_customer_package_details
info [Changelog]
info [Changelog] **Breaking changes**
info [Changelog]
info [Changelog] - Model DataBoxDiskJobDetails no longer has parameter expected_data_size_in_terabytes
info [Changelog] - Model DataBoxHeavyJobDetails no longer has parameter expected_data_size_in_terabytes
info [Changelog] - Model DataBoxJobDetails no longer has parameter expected_data_size_in_terabytes
info [Changelog] - Model DiskScheduleAvailabilityRequest has a new required parameter expected_data_size_in_tera_bytes
info [Changelog] - Model DiskScheduleAvailabilityRequest no longer has parameter expected_data_size_in_terabytes
info [Changelog] - Model JobDetails no longer has parameter expected_data_size_in_terabytes
⚠️Warning [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. SDK Automation 14.0.0
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr [automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr [automation_init.sh] [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
cmderr [automation_init.sh] @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr [automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn File azure-sdk-for-js_tmp/initOutput.json not found to read
command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
Only show 14 items here, please refer to log for details.
info [Changelog] ### Features Added
info [Changelog]
info [Changelog] - New function `SystemData.MarshalJSON() ([]byte, error)`
info [Changelog] - New struct `SystemData`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskJobDetails`
info [Changelog] - New field `ReverseDCAccessCode` in struct `DcAccessSecurityCode`
info [Changelog] - New field `ForwardDCAccessCode` in struct `DcAccessSecurityCode`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `HeavyJobDetails`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetails`
info [Changelog] - New field `SystemData` in struct `JobResource`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskScheduleAvailabilityRequest`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetailsType`
info [Changelog]
info [Changelog] Total 7 breaking change(s), 10 additive change(s).
Only show 14 items here, please refer to log for details.
info [Changelog] - Field `ExpectedDataSizeInTerabytes` of struct `HeavyJobDetails` has been removed
info [Changelog] - Field `ExpectedDataSizeInTerabytes` of struct `JobDetails` has been removed
info [Changelog]
info [Changelog] ### Features Added
info [Changelog]
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetails`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskJobDetails`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetailsType`
info [Changelog] - New field `ReverseDCAccessCode` in struct `DcAccessSecurityCode`
info [Changelog] - New field `ForwardDCAccessCode` in struct `DcAccessSecurityCode`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `HeavyJobDetails`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskScheduleAvailabilityRequest`
info [Changelog]
info [Changelog] Total 6 breaking change(s), 6 additive change(s).
Only show 14 items here, please refer to log for details.
info [Changelog] - Field `ExpectedDataSizeInTerabytes` of struct `JobDetailsType` has been removed
info [Changelog] - Field `ExpectedDataSizeInTerabytes` of struct `JobDetails` has been removed
info [Changelog]
info [Changelog] ### Features Added
info [Changelog]
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskJobDetails`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetailsType`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `HeavyJobDetails`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `JobDetails`
info [Changelog] - New field `ExpectedDataSizeInTeraBytes` in struct `DiskScheduleAvailabilityRequest`
info [Changelog] - New field `ForwardDCAccessCode` in struct `DcAccessSecurityCode`
info [Changelog] - New field `ReverseDCAccessCode` in struct `DcAccessSecurityCode`
info [Changelog]
info [Changelog] Total 6 breaking change(s), 6 additive change(s).
info [Changelog] ### Features Added
info [Changelog]
info [Changelog] - New struct `DeviceErasureDetails`
info [Changelog] - New field `DeviceErasureDetails` in struct `CustomerDiskJobDetails`
info [Changelog] - New field `DeviceErasureDetails` in struct `DiskJobDetails`
info [Changelog] - New field `DeviceErasureDetails` in struct `HeavyJobDetails`
info [Changelog] - New field `DeviceErasureDetails` in struct `JobDetails`
info [Changelog] - New field `DeviceErasureDetails` in struct `CommonJobDetails`
info [Changelog]
info [Changelog] Total 0 breaking change(s), 7 additive change(s).
⚠️Warning [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. SDK Automation 14.0.0
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr [generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr [generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr [generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr [generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr [generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
⚠️Warning [Logs] Generate from 60eaaac34e6980c0e649633e4fa246423f3add36. Schema Automation 14.0.0
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr [initScript.sh] old lockfile
cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr [initScript.sh] npm WARN old lockfile
cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr [initScript.sh] npm WARN old lockfile
warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
Hi @sashanm, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
SDK azure-sdk-for-net - 2 failures in this check were seen in the previous PR as well. The failures are with the test code in the azure-sdk-for-net repo. Should we modify the test code before the swagger PR gets checked in.
Could you please look into this and advise us on how to fix these failures? Thank you!
ARMChangesRequested<valid label in PR review process>add this label when require changes after ARM reviewWaitForARMFeedback<valid label in PR review process> add this label when ARM review is required
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.