-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataBox] Bump the api version to add new values for enums for JobStageStatus and CustomerResolutionCode and new field StorageAccountAccessTierPreferences #16989
Conversation
Added new fields/enums for new api version
Hi, @aakash049 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnumerationInProgress Location: Microsoft.DataBox/stable/2021-12-01/databox.json#L1893 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️❌
Avocado: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag. readme: specification/databox/resource-manager/readme.md json: Microsoft.DataBox/stable/2019-09-01/databox.json |
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2021-12-01/databox.json compared with base:stable/2021-05-01/databox.json
- current:stable/2021-12-01/databox.json compared with base:preview/2021-08-01-preview/databox.json
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi, @aakash049 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Hi @aakash049, Your PR has some issues. Please fix the CI sequentially by following the order of
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 16989 in repo Azure/azure-rest-api-specs |
/azp run |
Commenter does not have sufficient privileges for PR 16989 in repo Azure/azure-rest-api-specs |
@ruowan Could you help take a look at this avocado failure. seems like a false alarm ? |
I don't have the permission to merge this PR. @akning-ms Could you help merge it? |
…for enums for JobStageStatus and CustomerResolutionCode and new field StorageAccountAccessTierPreferences (#2245) Create to sync Azure/azure-rest-api-specs#16989 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/databox?expand=1)
…geStatus and CustomerResolutionCode and new field StorageAccountAccessTierPreferences (Azure#16989) * Added new fields/enums for new api version Added new fields/enums for new api version * changes * version change * Update databox.json * Update databox.json * Updated Readme * Update databox.json * Prettier change * spell check * Update databox.json * Update databox.json * Update databox.json * Update databox.json * Added Granular Changes * Fix lint error with copylogdetailstype * added new DC * Empty array x-ms-identifiers * Update databox.json * Delete readme.ruby.md Co-authored-by: John Emmanuel Mandam <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.