Added Azure FarmBeats(Public Preview) Event Grid Events for first time (RP Namespace: Microsoft.AgFoodPlatform) #14201

BlackRider97 · 2021-04-30T07:25:28Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
  Publish the event schemas for Microsoft.AgFoodPlatform's Azure FarmBeats resource Event Grid system topic.
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
We are planning to go Public Preview on 11th May, 2021
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…e (RP Namespace: Microsoft.AgFoodPlatform)

openapi-workflow-bot · 2021-04-30T07:25:32Z

Hi, @BlackRider97 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-04-30T07:25:32Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌LintDiff: 1 Errors, 0 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- eventgrid/data-plane/readme.md tag:package-2018-01
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- eventgrid/data-plane/readme.md tag:package-2018-01

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` AutoRest exception	"readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"Syntax Error Encountered: Unexpected token : in JSON"

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` AutoRest exception	"readme":"eventgrid/data-plane/readme.md", "tag":"package-2018-01", "details":"Syntax Error Encountered: Unexpected token : in JSON"

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️🔄[Staging] SDK Track2 Validation inProgress [Detail]

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-04-30T07:25:33Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌ azure-sdk-for-python failed [Detail]

❌Failed [Logs] Generate from efefcdec604371c4c9755e568411675e8ebb864d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout	[automation_generate.sh] [Autorest]
cmdout	[automation_generate.sh] [Autorest]    Loading AutoRest core      '/home/vsts/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4417)
cmdout	[automation_generate.sh] [Autorest] ERROR: Syntax Error Encountered: Unexpected token : in JSON
cmdout	[automation_generate.sh] [Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/eventgrid/data-plane/readme.md:23:33
cmdout	[automation_generate.sh] [Autorest] [OperationAbortedException] Error occurred. Exiting.
cmdout	[automation_generate.sh] [Autorest]/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️❌ azure-sdk-for-js failed [Detail]

❌Failed [Logs] Generate from efefcdec604371c4c9755e568411675e8ebb864d. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/eventgrid/data-plane/readme.md
cmderr	[Autorest] ERROR: Syntax Error Encountered: Unexpected token : in JSON
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/eventgrid/data-plane/readme.md:23:33
cmdout	[Autorest] [OperationAbortedException] Error occurred. Exiting.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js/azure-sdk-for-js]: autorest
warn	Skip package processing as generation is failed

️❌ azure-sdk-for-go failed [Detail]

❌Failed [Logs] Generate from efefcdec604371c4c9755e568411675e8ebb864d. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr	[main.go] [AUTOREST] ERROR: Syntax Error Encountered: Unexpected token : in JSON
cmderr	[main.go] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/eventgrid/data-plane/readme.md:23:33
cmderr	[main.go] [ERROR] total 1 error(s):
cmderr	[main.go] [ERROR] cannot generate readme 'specification/eventgrid/data-plane/readme.md': autorest error with arguments '[email protected]/[email protected], --go, --verbose, --go-sdk-folder=., --multiapi, --use-onever, --version=V2, --go.license-header=MICROSOFT_MIT_NO_VERSION, ../../../../../azure-rest-api-specs/specification/eventgrid/data-plane/readme.md, --metadata-output-folder=../../../../../azure-rest-api-specs/specification/eventgrid/data-plane':
cmderr	[main.go] [ERROR] exit status 1
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: go run ./tools/generator/main.go
warn	Skip package processing as generation is failed

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-04-30T07:25:33Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-workflow-bot · 2021-04-30T07:29:16Z

Hi @BlackRider97, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

BlackRider97 · 2021-04-30T09:05:50Z

SDK generation is failing before my changes. Am I missing something here ?

...fication/eventgrid/data-plane/Microsoft.AgFoodPlatform/stable/2018-01-01/AzureFarmBeats.json

…able/2018-01-01/AzureFarmBeats.json Co-authored-by: Rakshith Bhyravabhotla <[email protected]>

ellismg

Small nit around the description for one event (just missing a space) but otherwise LGTM!

ellismg · 2021-05-17T18:28:32Z

...fication/eventgrid/data-plane/Microsoft.AgFoodPlatform/stable/2018-01-01/AzureFarmBeats.json

+          "type": "string"
+        },
+        "parentId": {
+          "description": "Id of the parent(field or seasonalField) it belongs to.",


Suggested change

"description": "Id of the parent(field or seasonalField) it belongs to.",

"description": "Id of the parent (field or seasonalField) it belongs to.",

…e (RP Namespace: Microsoft.AgFoodPlatform) (#14201) (#14603) * Added Azure FarmBeats(Public Preview) Event Grid Events for first time (RP Namespace: Microsoft.AgFoodPlatform) * Fixed spelling mistakes * Update specification/eventgrid/data-plane/Microsoft.AgFoodPlatform/stable/2018-01-01/AzureFarmBeats.json Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: Rajneesh Mitharwal <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: Rajneesh Mitharwal <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]>

…e (RP Namespace: Microsoft.AgFoodPlatform) (Azure#14201) (Azure#14603) * Added Azure FarmBeats(Public Preview) Event Grid Events for first time (RP Namespace: Microsoft.AgFoodPlatform) * Fixed spelling mistakes * Update specification/eventgrid/data-plane/Microsoft.AgFoodPlatform/stable/2018-01-01/AzureFarmBeats.json Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: Rajneesh Mitharwal <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: Rajneesh Mitharwal <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]>

Added Azure FarmBeats(Public Preview) Event Grid Events for first tim…

5d65102

…e (RP Namespace: Microsoft.AgFoodPlatform)

BlackRider97 requested review from ahamad-MS and Kishp01 as code owners April 30, 2021 07:25

openapi-assignment-bot bot assigned lmazuel Apr 30, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Apr 30, 2021

Fixed spelling mistakes

027a876

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Apr 30, 2021

rakshith91 reviewed May 4, 2021

View reviewed changes

...fication/eventgrid/data-plane/Microsoft.AgFoodPlatform/stable/2018-01-01/AzureFarmBeats.json Outdated Show resolved Hide resolved

Update specification/eventgrid/data-plane/Microsoft.AgFoodPlatform/st…

689331b

…able/2018-01-01/AzureFarmBeats.json Co-authored-by: Rakshith Bhyravabhotla <[email protected]>

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels May 5, 2021

ellismg approved these changes May 17, 2021

View reviewed changes

lmazuel merged commit 66e560e into dev-eventgrid-Microsoft.AgFoodPlatform-preview-firstTimeCreate May 17, 2021

lmazuel deleted the event_grid_events branch May 17, 2021 21:02

BlackRider97 mentioned this pull request May 31, 2021

[Hub Generated] Review request for Microsoft.EventGrid to add version stable/2018-01-01 #14603

Merged

26 tasks

heaths mentioned this pull request Jun 16, 2021

Initial 2021-05-01-preview version #14855

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Azure FarmBeats(Public Preview) Event Grid Events for first time (RP Namespace: Microsoft.AgFoodPlatform) #14201

Added Azure FarmBeats(Public Preview) Event Grid Events for first time (RP Namespace: Microsoft.AgFoodPlatform) #14201

BlackRider97 commented Apr 30, 2021 •

edited

Loading

openapi-workflow-bot bot commented Apr 30, 2021

openapi-pipeline-app bot commented Apr 30, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 30, 2021 •

edited

Loading

openapi-workflow-bot bot commented Apr 30, 2021

openapi-workflow-bot bot commented Apr 30, 2021

BlackRider97 commented Apr 30, 2021 •

edited

Loading

ellismg left a comment

ellismg May 17, 2021

	"description": "Id of the parent(field or seasonalField) it belongs to.",
	"description": "Id of the parent (field or seasonalField) it belongs to.",

Added Azure FarmBeats(Public Preview) Event Grid Events for first time (RP Namespace: Microsoft.AgFoodPlatform) #14201

Added Azure FarmBeats(Public Preview) Event Grid Events for first time (RP Namespace: Microsoft.AgFoodPlatform) #14201

Conversation

BlackRider97 commented Apr 30, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 30, 2021

openapi-pipeline-app bot commented Apr 30, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 30, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Apr 30, 2021

openapi-workflow-bot bot commented Apr 30, 2021

BlackRider97 commented Apr 30, 2021 • edited Loading

ellismg left a comment

Choose a reason for hiding this comment

ellismg May 17, 2021

Choose a reason for hiding this comment

BlackRider97 commented Apr 30, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 30, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 30, 2021 •

edited

Loading

BlackRider97 commented Apr 30, 2021 •

edited

Loading