Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 #12031

Conversation

elabicha
Copy link
Contributor

@elabicha elabicha commented Dec 9, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 9, 2020

Swagger Validation Report

️❌BreakingChange: 37 Errors, 0 Warnings failed [Detail] Only 10 items are listed, please refer to log for more details.

Rule Message
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'dataset' renamed or removed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1265:7
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1265:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'dimension' renamed or removed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L2512:7
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L2511:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tag' renamed or removed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.exports.json#L623:7
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.exports.json#L623:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'not' renamed or removed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1454:7
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1449:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'not' renamed or removed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1454:7
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1449:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'not' renamed or removed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.exports.json#L623:7
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.exports.json#L623:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'dimension' renamed or removed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.exports.json#L623:7
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.exports.json#L623:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tag' renamed or removed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.exports.json#L623:7
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.exports.json#L623:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'not' renamed or removed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1454:7
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1449:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'not' renamed or removed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1454:7
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1449:7
️⚠️LintDiff: 1 Warnings warning [Detail]

Rule Message
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: includeMonetaryCommitment
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1299
️🔄Avocado inProgress [Detail]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 9, 2020

Swagger Generation Artifacts

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from b4ec309. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	python3 -m venv venv
    command	pip install --upgrade setuptools wheel pip
    command	pip install pathlib jinja2 msrestazure
    command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
  • ️✔️azure-mgmt-costmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
    cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-costmanagement
    cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-costmanagement
    cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
    cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.costmanagement
    cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.costmanagement
    cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.costmanagement
    cmderr	[changelogReport] INFO:__main__:Report written to sdk/costmanagement/azure-mgmt-costmanagement/code_reports/latest/report.json
    cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-costmanagement on PyPI
    cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '1.0.0b1']
    cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
    cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.2.0 of azure-mgmt-costmanagement in a venv
    cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
    cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.costmanagement
    cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.costmanagement
    cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.costmanagement
    cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/costmanagement/azure-mgmt-costmanagement/code_reports/0.2.0/report.json
    cmdout	[Changelog] Size of delta 65.127% size of original (original: 34284 chars, delta: 22328 chars)
    cmdout	[Changelog] **Features**
    cmdout	[Changelog]   - Model Export has a new parameter e_tag
    cmdout	[Changelog]   - Model Export has a new parameter next_run_time_estimate
    cmdout	[Changelog]   - Model Export has a new parameter run_history
    cmdout	[Changelog]   - Model ExportExecution has a new parameter e_tag
    cmdout	[Changelog]   - Model ExportExecution has a new parameter error
    cmdout	[Changelog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
    cmdout	[Changelog]   - Model CommonExportProperties has a new parameter run_history
    cmdout	[Changelog]   - Added operation DimensionsOperations.by_external_cloud_provider_type
    cmdout	[Changelog]   - Added operation QueryOperations.usage_by_external_cloud_provider_type
    cmdout	[Changelog]   - Added operation group ForecastOperations
    cmdout	[Changelog]   - Added operation group AlertsOperations
    cmdout	[Changelog]   - Added operation group ViewsOperations
    cmdout	[Changelog] **Breaking changes**
    cmdout	[Changelog]   - Operation ExportsOperations.get has a new signature
    cmdout	[Changelog]   - Operation ExportsOperations.list has a new signature
    cmdout	[Changelog]   - Model Export no longer has parameter tags
    cmdout	[Changelog]   - Model ExportExecution no longer has parameter tags
    warn	Breaking change found in changelog
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from b4ec309. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️costmanagement/mgmt/2019-10-01/costmanagement [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/costmanagement/mgmt/2019-03-01/costmanagement [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️costmanagement/mgmt/2019-01-01/costmanagement [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/costmanagement/mgmt/2018-08-01-preview/costmanagement [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️costmanagement/mgmt/2018-05-31/costmanagement [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from b4ec309. Schema Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	autorest --use=@autorest/[email protected] --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
    cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.CostManagement/reports. Skipping definition with path '/providers/Microsoft.Billing/departments/{departmentId}/providers/Microsoft.CostManagement/reports/{reportName}'.
    cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.CostManagement/reports. Using definition with path '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/Microsoft.CostManagement/reports/{reportName}'.
  • ️✔️cost-management [View full logs]  [Release Schema Changes]
    cmderr	[resource-manager] node-pre-gyp
    cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
    cmderr	[resource-manager] WARN [email protected] No repository field.
    cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
    cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    cmderr	[resource-manager]  ELIFECYCLE
    cmderr	[resource-manager]  9
    cmderr	[resource-manager]  [email protected] test: `mocha -r ts-node/register tests.ts`
    cmderr	[resource-manager]  Exit status 9
    cmderr	[resource-manager]
    cmderr	[resource-manager]  Failed at the [email protected] test script.
    cmderr	[resource-manager]  This is probably not a problem with npm. There is likely additional logging output above.
    cmderr	[resource-manager]  A complete log of this run can be found in:
    cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-01-05T06_30_08_847Z-debug.log
    cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
    cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
    cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
    cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
    cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
    cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
    cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
    cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
    cmderr	[resource-manager]   status: 9,
    cmderr	[resource-manager]   signal: null,
    cmderr	[resource-manager]   output: [ null, null, null ],
    cmderr	[resource-manager]   pid: 3463,
    cmderr	[resource-manager]   stdout: null,
    cmderr	[resource-manager]   stderr: null
    cmderr	[resource-manager] }
️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from b4ec309. Azure CLI Automation 14.0.0
    Only show 120 items here, please refer to log for details.
    cmderr	[Autorest]     - name: /Alerts/get/BillingAccountAlerts
    cmderr	[Autorest]     - name: /Alerts/get/BillingProfileAlerts
    cmderr	[Autorest]     - name: /Alerts/get/DepartmentAlerts
    cmderr	[Autorest]     - name: /Alerts/get/EnrollmentAccountAlerts
    cmderr	[Autorest]     - name: /Alerts/get/ExternalBillingAccountAlerts
    cmderr	[Autorest]     - name: /Alerts/get/ExternalSubscriptionAlerts
    cmderr	[Autorest]     - name: /Alerts/get/InvoiceSectionAlerts
    cmderr	[Autorest]     - name: /Alerts/get/ResourceGroupAlerts
    cmderr	[Autorest]     - name: /Alerts/get/ResourceGroupAlerts
    cmderr	[Autorest]     - name: /Alerts/get/SubscriptionAlerts
    cmderr	[Autorest]     - name: /Alerts/get/SubscriptionAlerts
    cmderr	[Autorest]     - name: /Alerts/patch/ResourceGroupAlerts
    cmderr	[Autorest]     - name: /Alerts/patch/SubscriptionAlerts
    cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsList-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsList-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsList-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsListExpandAndTop-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsListWithFilter-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsList-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsListExpandAndTop-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsListWithFilter-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsList-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsListExpandAndTop-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsListWithFilter-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsList-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListExpandAndTop-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListWithFilter-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/ExternalBillingAccountDimensionList
    cmderr	[Autorest]     - name: /Dimensions/get/ExternalSubscriptionDimensionList
    cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsList-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsListExpandAndTop-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsListWithFilter-Modern
    cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsList-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsListExpandAndTop-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsListWithFilter-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/ResourceGroupDimensionsList-Legacy
    cmderr	[Autorest]     - name: /Dimensions/get/SubscriptionDimensionsList-Legacy
    cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByBillingAccount
    cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByDepartment
    cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByEnrollmentAccount
    cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByManagementGroup
    cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByResourceGroup
    cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateBySubscription
    cmderr	[Autorest]     - name: /Exports/get/ExportGetByBillingAccount
    cmderr	[Autorest]     - name: /Exports/get/ExportGetByDepartment
    cmderr	[Autorest]     - name: /Exports/get/ExportGetByEnrollmentAccount
    cmderr	[Autorest]     - name: /Exports/get/ExportGetByManagementGroup
    cmderr	[Autorest]     - name: /Exports/get/ExportGetByResourceGroup
    cmderr	[Autorest]     - name: /Exports/get/ExportGetBySubscription
    cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByBillingAccount
    cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByDepartment
    cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByEnrollmentAccount
    cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByManagementGroup
    cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByResourceGroup
    cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetBySubscription
    cmderr	[Autorest]     - name: /Exports/get/ExportsGetByBillingAccount
    cmderr	[Autorest]     - name: /Exports/get/ExportsGetByDepartment
    cmderr	[Autorest]     - name: /Exports/get/ExportsGetByEnrollmentAccount
    cmderr	[Autorest]     - name: /Exports/get/ExportsGetByManagementGroup
    cmderr	[Autorest]     - name: /Exports/get/ExportsGetByResourceGroup
    cmderr	[Autorest]     - name: /Exports/get/ExportsGetBySubscription
    cmderr	[Autorest]     - name: /Exports/post/ExportRunByBillingAccount
    cmderr	[Autorest]     - name: /Exports/post/ExportRunByDepartment
    cmderr	[Autorest]     - name: /Exports/post/ExportRunByEnrollmentAccount
    cmderr	[Autorest]     - name: /Exports/post/ExportRunByManagementGroup
    cmderr	[Autorest]     - name: /Exports/post/ExportRunByResourceGroup
    cmderr	[Autorest]     - name: /Exports/post/ExportRunBySubscription
    cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByBillingAccount
    cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByDepartment
    cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByEnrollmentAccount
    cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByManagementGroup
    cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByResourceGroup
    cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteBySubscription
    cmderr	[Autorest]     - name: /Forecast/post/BillingAccountForecast
    cmderr	[Autorest]     - name: /Forecast/post/BillingProfileForecast
    cmderr	[Autorest]     - name: /Forecast/post/DepartmentForecast
    cmderr	[Autorest]     - name: /Forecast/post/EnrollmentAccountForecast
    cmderr	[Autorest]     - name: /Forecast/post/ExternalBillingAccountForecast
    cmderr	[Autorest]     - name: /Forecast/post/ExternalSubscriptionForecast
    cmderr	[Autorest]     - name: /Forecast/post/InvoiceSectionForecast
    cmderr	[Autorest]     - name: /Forecast/post/ResourceGroupForecast
    cmderr	[Autorest]     - name: /Forecast/post/SubscriptionForecast
    cmderr	[Autorest]     - name: /Query/post/BillingAccountQuery-Legacy
    cmderr	[Autorest]     - name: /Query/post/BillingAccountQuery-Modern
    cmderr	[Autorest]     - name: /Query/post/BillingAccountQueryGrouping-Legacy
    cmderr	[Autorest]     - name: /Query/post/BillingAccountQueryGrouping-Modern
    cmderr	[Autorest]     - name: /Query/post/BillingProfileQuery-Modern
    cmderr	[Autorest]     - name: /Query/post/BillingProfileQueryGrouping-Modern
    cmderr	[Autorest]     - name: /Query/post/CustomerQuery-Modern
    cmderr	[Autorest]     - name: /Query/post/CustomerQueryGrouping-Modern
    cmderr	[Autorest]     - name: /Query/post/DepartmentQuery-Legacy
    cmderr	[Autorest]     - name: /Query/post/DepartmentQueryGrouping-Legacy
    cmderr	[Autorest]     - name: /Query/post/EnrollmentAccountQuery-Legacy
    cmderr	[Autorest]     - name: /Query/post/EnrollmentAccountQueryGrouping-Legacy
    cmderr	[Autorest]     - name: /Query/post/ExternalBillingAccountQueryList
    cmderr	[Autorest]     - name: /Query/post/ExternalSubscriptionsQuery
    cmderr	[Autorest]     - name: /Query/post/InvoiceSectionQuery-Modern
    cmderr	[Autorest]     - name: /Query/post/InvoiceSectionQueryGrouping-Modern
    cmderr	[Autorest]     - name: /Query/post/ManagementGroupQuery-Legacy
    cmderr	[Autorest]     - name: /Query/post/ManagementGroupQueryGrouping-Legacy
    cmderr	[Autorest]     - name: /Query/post/ResourceGroupQuery-Legacy
    cmderr	[Autorest]     - name: /Query/post/ResourceGroupQueryGrouping-Legacy
    cmderr	[Autorest]     - name: /Query/post/SubscriptionQuery-Legacy
    cmderr	[Autorest]     - name: /Query/post/SubscriptionQueryGrouping-Legacy
    cmderr	[Autorest]     - name: /Views/put/CreateOrUpdatePrivateView
    cmderr	[Autorest]     - name: /Views/put/ResourceGroupCreateOrUpdateView
    cmderr	[Autorest]     - name: /Views/get/PrivateView
    cmderr	[Autorest]     - name: /Views/get/PrivateViewList
    cmderr	[Autorest]     - name: /Views/get/ResourceGroupView
    cmderr	[Autorest]     - name: /Views/get/ResourceGroupViewList
    cmderr	[Autorest]     - name: /Views/delete/DeletePrivateView
    cmderr	[Autorest]     - name: /Views/delete/ResourceGroupDeleteView
    cmderr	[Autorest] --------------------------------------------------------
    cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs
    cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
    cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
  • ️✔️costmanagement [View full logs]  [Release Azure CLI Changes]
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @elabicha Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    Hi @elabicha, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

    @PhoenixHe-NV
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @PhoenixHe-NV
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @PhoenixHe-NV
    Copy link
    Contributor

    @elabicha Remove/rename property on old stable version is not allowed. Please go through breaking change review https://msazure.visualstudio.com/One/_workitems/create/Scenario?templateId=d1c215ec-5d6a-4cb3-a193-95ddd0a1ba96&ownerId=85bb92fb-21fe-41ca-9309-47f2c5f57515

    @openapi-workflow-bot
    Copy link

    Hi @elabicha, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

    @PhoenixHe-NV PhoenixHe-NV added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Dec 28, 2020
    @PhoenixHe-NV
    Copy link
    Contributor

    @elabicha Any update?

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 4, 2021
    @PhoenixHe-NV PhoenixHe-NV merged commit b4ec309 into Azure:master Jan 5, 2021
    xiangyan99 added a commit that referenced this pull request Jan 5, 2021
    * [Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-06-01 (#11833)
    
    * Changing Swagger file
    
    * Changing examples
    
    * Fixing tags example
    
    * Fixing tags example
    
    * Fixing tags example
    
    * prettier fix for white spaces
    
    * Enable azure-sdk-for-net-track2 (#12169)
    
    * Updating existing CRR APIs with zone restore feature (#12157)
    
    * - Added change for support of cross zone restores.
    
    * - updating example json
    
    * - Fixing prettier
    
    * lastUpdatedDate for templates (#11900)
    
    * lastUpdatedDate for templates
    
    * fix
    
    * [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2020-11-01-preview (#11823)
    
    * Adds base for updating Microsoft.AppPlatform from version stable/2020-07-01 to version 2020-11-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Introduce additional change to 2020-11-01-preview.
    
    * Additional properties to monitoringSettings.
    * Readonly properties to requiredTraffics.
    
    Signed-off-by: Pan Li <[email protected]>
    
    * Make credscan happy.
    
    Signed-off-by: Pan Li <[email protected]>
    
    * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12113)
    
    * Fix linter and swagger warnings
    
    * Fix errors
    
    * Removed unneeded change
    
    * [ASC.Automations] Add new data type "RegulatoryComplianceAssessment" (#12185)
    
    * Add SubAssessment event source type and add more automations examples
    
    * Change Location isReadOnlu to false
    
    * Test
    
    * Add new read/write location and add new type TrackedResourceLocation
    
    * Minor
    
    * minor
    
    * prettier fixes
    
    * Change variable name to TrackedResourceLocation
    
    * Change type name TrackedResourceLocation to AzureTrackedResourceLocation
    
    * Update automations example
    
    * Add SecureScores & SecureScoreControls as new supported datatypes in Automations resource
    
    * [ASC.Automations] add new data type RegulatoryComplianceAssessment
    
    * add datalake store track2 config (#12186)
    
    * cleanup old pipeline dependencies (#11889)
    
    * cleanup pipeline deps
    
    * add rest-api-specs-scripts
    
    * Extending recovery network input in replication intent API to support new network creation (#12191)
    
    * [Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview (#12172)
    
    * Adding operations for Maps Creator resource.
    
    * Fixing typo.
    
    * Adds suppression to readme
    
    * Adds suppression to readme
    
    * Adds suppression to readme
    
    * Adds suppression to readme
    
    * Resolving linter errors.
    
    * Minor update.
    
    * Updating all reference to v2 schema.
    
    * Marked private atlas as deprecated in description.
    
    * add operationsmanagement track2 config (#12141)
    
    * Update comment.yml (#12202)
    
    Add ARM traffic query link. When add breakingChangeReviewRequired
    
    * Adding new properties to response body (#12201)
    
    * adding new properties
    
    * updating examples
    
    * prettier fix
    
    * [Hub Generated] Review request for Microsoft.ContainerService to add version stable/2020-12-01 (#12064)
    
    * Add autorest.az configurations for azure monitor control service (#12090)
    
    * add AMCS config for codegen
    
    * reorganize command group
    
    * rename command group
    
    * Codegen modify try to rename DataCollectionRules create parameters
    
    * hide DataCollectionRules Create & Update commands and DataCollectionRuleAssociations Create command
    
    * use alias instand of rename in code-gen
    
    * use monitor-control-service as the extension name
    
    * Update readme.python.md
    
    * add logic track2 config (#12166)
    
    * add alertsmanagement track2 config (#11759)
    
    * Update comment.yml (#12213)
    
    * add mixedreality track2 confi (#12070)
    
    * add signalr track2 config (#11892)
    
    * add cognitiveservice track2 config (#11498)
    
    * add machinglearningservices track2 config (#12183)
    
    * add apimanagement track2 config (#12187)
    
    * add serialconsole track2 config (#12046)
    
    * Update TransparentDataEncryption Group Name (#12160)
    
    * update TransparentDataEncryption Group name
    
    * update reference of TransparentDataEncryption
    
    * Update readme.python.md (#12216)
    
    * Required changes for Azure HealthBot swagger (#12124)
    
    * Fixes for SDK generation files.
    
    * Fixes for SDK generation files.
    
    * Added GO.
    
    * Change Healthcare bot to Healthbot.
    
    * 1. Remove unused properties of SKU.
    2. Removed unused CheckNameAvailability.json
    3. Remove subgroup.
    
    * Sku is required.
    
    * [Hub Generated] Review request for Microsoft.IoTCentral to add version stable/2018-09-01 (#12224)
    
    * update to name
    
    * update
    
    * add api-version of guest configuration to go SDK (#12217)
    
    * add api-version for templatespecs (#12197)
    
    * Update specificationRepositoryConfiguration.json (#12218)
    
    * Adding new api version to devops RP (#11585)
    
    * Initial commit as per PR review
    
    * Actual changes to api spec for new version
    
    * Switching to multi-api build for python
    
    * Fix python spec to correct namespaces in multiapi mode
    
    * Revert changes to python generation
    
    * Add systemdata
    
    * Fix the path for sys data reference
    
    * Fix path once more
    
    * remove additional properties after including systemdata
    
    * Remove more addtional properties
    
    * Move system data to root
    
    * Fix wrong output-folder (#12229)
    
    * Remove swagger and examples because the controller will be used for private preview. (#12177)
    
    * Update pull_request_assignment.yml (#12230)
    
    * [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01 (#11407)
    
    * Init the next version so diffs can work better.
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Updates to StorageTargetProperties and added examples of cmk, mtu
    
    Add 202 to the storage cache and storage target create/update and update examples
    
    Fix ST no junction example's 202 response.
    
    add properties for nfs extended groups
    
    fix issues with extended groups properties found with autorest
    
    add properties and objects for Active Directory username download
    
    undo unintended change
    
    changes from comments in pull request
    
    AccessPolicy support.
    
    Example fixes for Access Policies.
    
    Fix attribute names to match latest RP.
    
    update to credential properties for LDAP and Active Directory
    
    marking password properties with x-ms-secret tag
    
    minor changes on extended groups and add examples
    
    Added blob NFS and some other validation fixes.
    
    Update required property for domainName from dnsName
    
    Updated blobNfs examples and some kpi fixes.
    
    Correct validation errors in examples.
    
    Added systemdata to resources.
    
    Remove x-ms-secret in keyvault reference due to linter error and common types not using it.
    
    Remove blobNfs from this version.
    
    Remove blobNfs from spec file.
    
    Remove x-ms-secret due to linter errors.
    
    Fix certificate spelling.
    
    Updating prettier and spell check errors.
    
    Used prettier on main spec file.
    
    Readded x-ms-secret that open api hub failed on but the PR pipeline allows.
    
    * Add prettier fix after rebase
    
    * Remove 202 bodies and add systemData to examples.
    
    * Update spec with prettier.
    
    * Address comments on spec for descriptions, readmes, and extendedGroupsEnabled.
    
    * Updating to address addition ldap and pattern comments.
    
    * Update version tag to include 01
    
    * Restore changes that would be considered breaking changes matching 2020-03-01
    
    * Address a few other comments.
    
    * Update netbios field names and some descriptions.
    
    * Fix s360 for missing debugInfo operation.
    
    * Fix credscan error in example file.
    
    * Update required fields, new validator failure on debugInfo return codes, and bindPassword example value.
    
    * Update debug info example with new return codes.
    
    * Update other credscan password errors.
    
    * Update Semantic-and-Model-Violations-Reference.md (#12199)
    
    Adding secret_property code, update some other codes.
    
    * ADP - add system metadata to dataPool (#12179)
    
    * Swagger Linting Fix (#12162)
    
    * Fix Linting Issuing
    
    * no message
    
    * fix description
    
    * add description and object back
    
    * test to resolve model validation test
    
    (cherry picked from commit ab273df)
    
    * [SQL][V20180601] Updating LocationCapabilities spec (#12032)
    
    * [SQL][V20180601] Updating LocationCapabilities spec
    
    * Fill 2020 versions
    
    * Rollback V2018 changes and bump LocationCapabilities in V4 to 2020-08-01-preview
    
    * update order for CI-FixRequiredOnFailure (#12227)
    
    * update rdbms track2 config (#12245)
    
    * ADT: refix path (#12161)
    
    * python track2 configure (#12150)
    
    * Add and remove owner for service principals (#12081)
    
    * [Hub Generated] Review request for Microsoft.MixedReality to add version stable/2020-05-01 (#11810)
    
    * fix spec
    
    * fix prettier
    
    * [Hub Generated] Review request for Microsoft.MixedReality to add version preview/2019-12-02-preview (#11769)
    
    * fix for swagger completeness
    
    * forgot curly brace
    
    * fix example
    
    * Api Management - make /tenant endpoints ARM compliant in 2020-06-01-preview version (#11549)
    
    * Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add support in API Management for Availability Zones (#10284)
    
    * apim in azs
    
    * fix prettier check
    
    * PATCH should return 200 OK (#10328)
    
    * add support for PATCH returning 200 OK
    
    * CI fixes
    
    prettier fix
    
    CI fixes part 2
    
    * Password no longer a mandatory property when uploading Certificates
    
    * add missing x-ms-odata extension for filter support
    
    * +gatewayhostnameconfiguration protocol changes (#10292)
    
    * [2020-06-01-preview] Update Oauth Server secrets Contract (#10602)
    
    * Oauth server secrets contract
    
    * fix azureMonitor enum
    
    * API Management Service Deleted Services Resource (#10607)
    
    * API Management Service Deleted Services Resource
    
    * Path fix
    
    * Lint + custom-words fixes
    
    * Location URI parameter for deletedservices Resource
    
    * GET for deletedservices by service name
    
    * Remove resourceGroupName from resource path
    
    * fixes
    
    * schema for purge operation
    
    * perttier applied
    
    * 204 response code added
    
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    
    * OperationNameFormat property added to Diagnostic contract (#10641)
    
    * OperationNameFormat property added to Diagnostic contract
    
    * add azuremonitor to update contract
    
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    
    * [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (#10331)
    
    * Change Network Status response contract
    
    * Update examples for network status contract
    
    * ApiManagement - tenant/settings endpoints
    
    * ApiManagement - tenant/settings endpoints fix
    
    * ApiManagement - tenant/settings endpoints fix prettier
    
    * ApiManagement - tenant/settings endpoints fix 3
    
    * ApiManagement - tenant/settings endpoints fix 4
    
    * ApiManagement - tenant/settings endpoints fix 5
    
    Co-authored-by: Samir Solanki <[email protected]>
    Co-authored-by: maksimkim <[email protected]>
    Co-authored-by: promoisha <[email protected]>
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    Co-authored-by: RupengLiu <[email protected]>
    Co-authored-by: vfedonkin <[email protected]>
    
    * Add "mail" parameter to UserUpdateParameters in graphrbac (#12127)
    
    This patch adds a single optional field "mail" to UserUpdateParameters
    schema. This makes it possible to update user's e-mail address using
    the (Go) Azure SDK. Currently this is not possible.
    
    I have curled the graphrbac API with the extra body parameter and it
    works as expected.
    
    Addition of the field will make it possible to support the mail property
    on the azuread_user resource in terraform-provider-azuread.
    
    Co-authored-by: David Čepelík <[email protected]>
    
    * [Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 (#12262)
    
    * add resourcegraph track2 config (#12122)
    
    * add reservations track2 config (#12027)
    
    * Removing a readonly tag from a property (#12254)
    
    * Fix swagger correctness errors (#12246)
    
    * Fix swagger correctness issues in Security for Iot service
    
    * changed int format from 32 to 64
    
    * Add systemData to iotSecuritySolutions
    
    Co-authored-by: Liran Chen <[email protected]>
    
    * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12196)
    
    * AAS - Swagger Linting and Correctness Fix (#12176)
    
    * Fix R4013 IntegerTypeMustHaveFormat
    
    * Fix R4010 RequiredDefaultResponse
    
    * Fix R4007 DefaultErrorResponseSchema
    
    * removed extra bracket
    
    * fix semantic issue
    
    * add type error
    
    * Fix linting issue
    
    * test to resolve model validation test
    
    * Revert "test to resolve model validation test"
    
    This reverts commit ab273df.
    
    * Resolve Model Validation Issue
    
    * Resolve Model Validation Issue v2
    
    * test - add missing properties
    
    (cherry picked from commit 48ec27c)
    
    * fix format
    
    * set default value
    
    * add x-ms-enum
    
    * fix nit
    
    * Add missing property
    
    * add missing properties
    
    * add missing bracket
    
    * change GatewayListStatusLive type
    
    * add missing "origin" property
    
    * fix model validation
    
    * Revert "change GatewayListStatusLive type"
    
    This reverts commit 4f3fa74.
    
    * Revert "fix model validation"
    
    This reverts commit 945bc23.
    
    * add redhatopenshift track2 config (#12045)
    
    * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-10-01 (#12194)
    
    * Adding nextLink and previousLink to Tags endpoint properties
    
    * moving properties out
    
    * prettier check fix
    
    Co-authored-by: Jorge Chavez Nieto <[email protected]>
    
    * add relay track2 config (#11495)
    
    * update healthbot t2 config (#12269)
    
    * update healthbot t2 config
    
    * fix readme
    
    * add automation track2 config (#11628)
    
    * add automation track2 config
    
    * update config
    
    * Azure Remote Rendering REST API swagger file - for review (#12015)
    
    * Azure Remote Rendering API specifcation
    
    * fix schema issue
    
    * fix examples
    
    * fix request bodies integer values, :stop path
    
    * pointing readme.md to open api spec for ARR
    
    * fix typo, add custom words
    
    * add msvc to custom words
    
    * fix readme.md
    
    * ran prettifier
    
    * fix reference to json
    
    * reference sts from file as well
    
    * fix readme.md
    
    * changes to readme.md
    
    * remove example from error to fix error
    
    * add 200 OK status for retried PUT for conversions and sessiosn
    
    * ran prettier
    
    * make autorest linter not crash
    
    * fix casing of nextLinkName paramter
    
    * factor out conversion list response
    
    * add examples for conversions
    
    * adding examples for sessions, prettify files
    
    * [Hub Generated] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 (#12175)
    
    * microsoft.imagery 512 not supported
    
    Adding micorosft.imagery to 512 tile not supported list
    
    * Updating Raster Tilesets to Have Max Zoom 22
    
    Certain raster tilesets now support up to zoom level 22.
    
    * minor changes to swagger (#12253)
    
    * minor changes to swagger
    
    * reverting sdk definitions file
    
    * Add addons to AVS 2020-07-17-preview (#12236)
    
    * found missing AVS/privateclouds/addons commit, moving it to 2020-07-17-preview API from PR repo
    
    * fixed prettier errors
    
    * Fixed vladation warnings for x-ms-enum and missing description/title, related to addons
    
    * fixed validation error for missing systemData for addons responses
    
    * fixed prettier errors
    
    * fixed validation error for missing systemData for addons responses
    
    * systemData for any Resource
    
    * make sure systemData is readOnly
    
    * systemData needs to go in a new api version
    
    * suppress systemData error
    
    Co-authored-by: Cameron Taggart <[email protected]>
    
    * Azs api bug fix (#12133)
    
    * Old api version for ComputeOperationResult
    
    * Api Bugfix for Azure Stack Fabric Admin
    
    * Fix for typo in readme
    
    * Add default reponse
    
    * Fix example issue for default error
    
    * Update comment.yml (#12273)
    
    * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#12031)
    
    * fix dataSet typo
    
    * fix dimensions and tags typo
    
    * more dimensions and tags to fix
    
    * one more miss on dimensions and tags
    
    * Add the includeMonetaryCommitment missing field
    
    * fix spell check error
    
    * make property read only
    
    * remove the not operation from query filters
    
    * New backup service api version (#12171)
    
    * Initial commit: adding new api version
    
    * - new api 2020-12-01
    
    * updating the readme.md package reference
    
    * - adding the zone information for new api
    
    * - updating api-version in examples
    - added 'zone' in Get recoverypoint api example json
    
    * Fixing prettier issue
    
    * Revert "- updating api-version in examples"
    
    This reverts commit 80baa9f.
    
    * - adding api-version in examples
    
    * adding new api version in package mds
    
    * [IotHub] Introducing networkRuleSets in IotHubProperties [2020-08-31 : preview and stable ] (#10853)
    
    * Adds base for updating Microsoft.Devices from version preview/2020-07-10-preview to version 2020-08-31-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Adds base for updating Microsoft.Devices from version stable/2020-08-01 to version 2020-08-31
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Adding networkRuleSets support for iothub
    
    * Adding networkRuleSets Support in preview version
    
    * Adding Examples, correcting order in iothub.json
    
    * Updating Readme to have stable and previe versions
    
    * Modifying Tag to package-2020-08-31
    
    * Adding Arm identity properties from 2020-07-010-preview version
    
    * Removing creds
    
    * minor fix
    
    * swagger correctness fix (#12101)
    
    * swagger correctness fix
    
    * update preview version too
    
    * Revert change and add defaults (#12243)
    
    * Remove gallery preview version 2020-09-30 from stable release (#12222)
    
    * add managementpartner track2 config (#12043)
    
    * [Hub Generated] Review request for Microsoft.Insights to add version stable/2019-03-01 (#12232)
    
    * Fixed swagger validations for api version 2019
    
    * reverted error response change and suppress
    
    * removed redundant error details
    
    * renamed suppression rule
    
    * fixed suppression
    
    Co-authored-by: napolish <[email protected]>
    Co-authored-by: Phoenix He <[email protected]>
    Co-authored-by: arpja <[email protected]>
    Co-authored-by: ShaniFelig <[email protected]>
    Co-authored-by: Pan Li <[email protected]>
    Co-authored-by: Zach Rathbun <[email protected]>
    Co-authored-by: surashed <[email protected]>
    Co-authored-by: Kaihui (Kerwin) Sun <[email protected]>
    Co-authored-by: Zhenglai Zhang <[email protected]>
    Co-authored-by: om-nishant <[email protected]>
    Co-authored-by: Ihar Voitka <[email protected]>
    Co-authored-by: Ruoxuan Wang <[email protected]>
    Co-authored-by: Ju Hee Lee <[email protected]>
    Co-authored-by: xiazhan <[email protected]>
    Co-authored-by: kai ru <[email protected]>
    Co-authored-by: Ji Wang <[email protected]>
    Co-authored-by: Andy Zhang <[email protected]>
    Co-authored-by: guy-microsoft <[email protected]>
    Co-authored-by: PoAn (Baron) Chen <[email protected]>
    Co-authored-by: Arcturus <[email protected]>
    Co-authored-by: suyash691 <[email protected]>
    Co-authored-by: nemijato <[email protected]>
    Co-authored-by: brpanask <[email protected]>
    Co-authored-by: Ray Chen <[email protected]>
    Co-authored-by: Eli Arbel <[email protected]>
    Co-authored-by: David Han <[email protected]>
    Co-authored-by: Roman Khotsyn <[email protected]>
    Co-authored-by: David R. Williamson <[email protected]>
    Co-authored-by: msyyc <[email protected]>
    Co-authored-by: Xinyi Joffre <[email protected]>
    Co-authored-by: roytan-microsoft <[email protected]>
    Co-authored-by: Vitaliy Fedonkin <[email protected]>
    Co-authored-by: Samir Solanki <[email protected]>
    Co-authored-by: maksimkim <[email protected]>
    Co-authored-by: promoisha <[email protected]>
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    Co-authored-by: RupengLiu <[email protected]>
    Co-authored-by: vfedonkin <[email protected]>
    Co-authored-by: David Čepelík <[email protected]>
    Co-authored-by: David Čepelík <[email protected]>
    Co-authored-by: mudit794 <[email protected]>
    Co-authored-by: Dhawal Jain <[email protected]>
    Co-authored-by: MichalHel <[email protected]>
    Co-authored-by: Liran Chen <[email protected]>
    Co-authored-by: jochav <[email protected]>
    Co-authored-by: Jorge Chavez Nieto <[email protected]>
    Co-authored-by: rikogeln <[email protected]>
    Co-authored-by: chgennar <[email protected]>
    Co-authored-by: hivyas <[email protected]>
    Co-authored-by: Douglas Lee <[email protected]>
    Co-authored-by: Cameron Taggart <[email protected]>
    Co-authored-by: LingyunSu <[email protected]>
    Co-authored-by: elabicha <[email protected]>
    Co-authored-by: Nikhil Kumar Mengani <[email protected]>
    Co-authored-by: Junbo Wang <[email protected]>
    Co-authored-by: Daniel Orozco <[email protected]>
    Co-authored-by: Adam Sandor <[email protected]>
    Co-authored-by: yashmuel <[email protected]>
    josuhazure pushed a commit to josuhazure/azure-rest-api-specs that referenced this pull request Jan 6, 2021
    …rsion stable/2019-11-01 (Azure#12031)
    
    * fix dataSet typo
    
    * fix dimensions and tags typo
    
    * more dimensions and tags to fix
    
    * one more miss on dimensions and tags
    
    * Add the includeMonetaryCommitment missing field
    
    * fix spell check error
    
    * make property read only
    
    * remove the not operation from query filters
    @mikhailshilkov
    Copy link
    Contributor

    Any hints on why this breaking change is made?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants