Skip to content

Commit

Permalink
Get latest master (#12289)
Browse files Browse the repository at this point in the history
* [Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-06-01 (#11833)

* Changing Swagger file

* Changing examples

* Fixing tags example

* Fixing tags example

* Fixing tags example

* prettier fix for white spaces

* Enable azure-sdk-for-net-track2 (#12169)

* Updating existing CRR APIs with zone restore feature (#12157)

* - Added change for support of cross zone restores.

* - updating example json

* - Fixing prettier

* lastUpdatedDate for templates (#11900)

* lastUpdatedDate for templates

* fix

* [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2020-11-01-preview (#11823)

* Adds base for updating Microsoft.AppPlatform from version stable/2020-07-01 to version 2020-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* Introduce additional change to 2020-11-01-preview.

* Additional properties to monitoringSettings.
* Readonly properties to requiredTraffics.

Signed-off-by: Pan Li <[email protected]>

* Make credscan happy.

Signed-off-by: Pan Li <[email protected]>

* [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12113)

* Fix linter and swagger warnings

* Fix errors

* Removed unneeded change

* [ASC.Automations] Add new data type "RegulatoryComplianceAssessment" (#12185)

* Add SubAssessment event source type and add more automations examples

* Change Location isReadOnlu to false

* Test

* Add new read/write location and add new type TrackedResourceLocation

* Minor

* minor

* prettier fixes

* Change variable name to TrackedResourceLocation

* Change type name TrackedResourceLocation to AzureTrackedResourceLocation

* Update automations example

* Add SecureScores & SecureScoreControls as new supported datatypes in Automations resource

* [ASC.Automations] add new data type RegulatoryComplianceAssessment

* add datalake store track2 config (#12186)

* cleanup old pipeline dependencies (#11889)

* cleanup pipeline deps

* add rest-api-specs-scripts

* Extending recovery network input in replication intent API to support new network creation (#12191)

* [Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview (#12172)

* Adding operations for Maps Creator resource.

* Fixing typo.

* Adds suppression to readme

* Adds suppression to readme

* Adds suppression to readme

* Adds suppression to readme

* Resolving linter errors.

* Minor update.

* Updating all reference to v2 schema.

* Marked private atlas as deprecated in description.

* add operationsmanagement track2 config (#12141)

* Update comment.yml (#12202)

Add ARM traffic query link. When add breakingChangeReviewRequired

* Adding new properties to response body (#12201)

* adding new properties

* updating examples

* prettier fix

* [Hub Generated] Review request for Microsoft.ContainerService to add version stable/2020-12-01 (#12064)

* Add autorest.az configurations for azure monitor control service (#12090)

* add AMCS config for codegen

* reorganize command group

* rename command group

* Codegen modify try to rename DataCollectionRules create parameters

* hide DataCollectionRules Create & Update commands and DataCollectionRuleAssociations Create command

* use alias instand of rename in code-gen

* use monitor-control-service as the extension name

* Update readme.python.md

* add logic track2 config (#12166)

* add alertsmanagement track2 config (#11759)

* Update comment.yml (#12213)

* add mixedreality track2 confi (#12070)

* add signalr track2 config (#11892)

* add cognitiveservice track2 config (#11498)

* add machinglearningservices track2 config (#12183)

* add apimanagement track2 config (#12187)

* add serialconsole track2 config (#12046)

* Update TransparentDataEncryption Group Name (#12160)

* update TransparentDataEncryption Group name

* update reference of TransparentDataEncryption

* Update readme.python.md (#12216)

* Required changes for Azure HealthBot swagger (#12124)

* Fixes for SDK generation files.

* Fixes for SDK generation files.

* Added GO.

* Change Healthcare bot to Healthbot.

* 1. Remove unused properties of SKU.
2. Removed unused CheckNameAvailability.json
3. Remove subgroup.

* Sku is required.

* [Hub Generated] Review request for Microsoft.IoTCentral to add version stable/2018-09-01 (#12224)

* update to name

* update

* add api-version of guest configuration to go SDK (#12217)

* add api-version for templatespecs (#12197)

* Update specificationRepositoryConfiguration.json (#12218)

* Adding new api version to devops RP (#11585)

* Initial commit as per PR review

* Actual changes to api spec for new version

* Switching to multi-api build for python

* Fix python spec to correct namespaces in multiapi mode

* Revert changes to python generation

* Add systemdata

* Fix the path for sys data reference

* Fix path once more

* remove additional properties after including systemdata

* Remove more addtional properties

* Move system data to root

* Fix wrong output-folder (#12229)

* Remove swagger and examples because the controller will be used for private preview. (#12177)

* Update pull_request_assignment.yml (#12230)

* [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01 (#11407)

* Init the next version so diffs can work better.

* Updates readme

* Updates API version in new specs and examples

* Updates to StorageTargetProperties and added examples of cmk, mtu

Add 202 to the storage cache and storage target create/update and update examples

Fix ST no junction example's 202 response.

add properties for nfs extended groups

fix issues with extended groups properties found with autorest

add properties and objects for Active Directory username download

undo unintended change

changes from comments in pull request

AccessPolicy support.

Example fixes for Access Policies.

Fix attribute names to match latest RP.

update to credential properties for LDAP and Active Directory

marking password properties with x-ms-secret tag

minor changes on extended groups and add examples

Added blob NFS and some other validation fixes.

Update required property for domainName from dnsName

Updated blobNfs examples and some kpi fixes.

Correct validation errors in examples.

Added systemdata to resources.

Remove x-ms-secret in keyvault reference due to linter error and common types not using it.

Remove blobNfs from this version.

Remove blobNfs from spec file.

Remove x-ms-secret due to linter errors.

Fix certificate spelling.

Updating prettier and spell check errors.

Used prettier on main spec file.

Readded x-ms-secret that open api hub failed on but the PR pipeline allows.

* Add prettier fix after rebase

* Remove 202 bodies and add systemData to examples.

* Update spec with prettier.

* Address comments on spec for descriptions, readmes, and extendedGroupsEnabled.

* Updating to address addition ldap and pattern comments.

* Update version tag to include 01

* Restore changes that would be considered breaking changes matching 2020-03-01

* Address a few other comments.

* Update netbios field names and some descriptions.

* Fix s360 for missing debugInfo operation.

* Fix credscan error in example file.

* Update required fields, new validator failure on debugInfo return codes, and bindPassword example value.

* Update debug info example with new return codes.

* Update other credscan password errors.

* Update Semantic-and-Model-Violations-Reference.md (#12199)

Adding secret_property code, update some other codes.

* ADP - add system metadata to dataPool (#12179)

* Swagger Linting Fix (#12162)

* Fix Linting Issuing

* no message

* fix description

* add description and object back

* test to resolve model validation test

(cherry picked from commit ab273df)

* [SQL][V20180601] Updating LocationCapabilities spec (#12032)

* [SQL][V20180601] Updating LocationCapabilities spec

* Fill 2020 versions

* Rollback V2018 changes and bump LocationCapabilities in V4 to 2020-08-01-preview

* update order for CI-FixRequiredOnFailure (#12227)

* update rdbms track2 config (#12245)

* ADT: refix path (#12161)

* python track2 configure (#12150)

* Add and remove owner for service principals (#12081)

* [Hub Generated] Review request for Microsoft.MixedReality to add version stable/2020-05-01 (#11810)

* fix spec

* fix prettier

* [Hub Generated] Review request for Microsoft.MixedReality to add version preview/2019-12-02-preview (#11769)

* fix for swagger completeness

* forgot curly brace

* fix example

* Api Management - make /tenant endpoints ARM compliant in 2020-06-01-preview version (#11549)

* Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add support in API Management for Availability Zones (#10284)

* apim in azs

* fix prettier check

* PATCH should return 200 OK (#10328)

* add support for PATCH returning 200 OK

* CI fixes

prettier fix

CI fixes part 2

* Password no longer a mandatory property when uploading Certificates

* add missing x-ms-odata extension for filter support

* +gatewayhostnameconfiguration protocol changes (#10292)

* [2020-06-01-preview] Update Oauth Server secrets Contract (#10602)

* Oauth server secrets contract

* fix azureMonitor enum

* API Management Service Deleted Services Resource (#10607)

* API Management Service Deleted Services Resource

* Path fix

* Lint + custom-words fixes

* Location URI parameter for deletedservices Resource

* GET for deletedservices by service name

* Remove resourceGroupName from resource path

* fixes

* schema for purge operation

* perttier applied

* 204 response code added

Co-authored-by: REDMOND\glfeokti <[email protected]>

* OperationNameFormat property added to Diagnostic contract (#10641)

* OperationNameFormat property added to Diagnostic contract

* add azuremonitor to update contract

Co-authored-by: REDMOND\glfeokti <[email protected]>

* [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (#10331)

* Change Network Status response contract

* Update examples for network status contract

* ApiManagement - tenant/settings endpoints

* ApiManagement - tenant/settings endpoints fix

* ApiManagement - tenant/settings endpoints fix prettier

* ApiManagement - tenant/settings endpoints fix 3

* ApiManagement - tenant/settings endpoints fix 4

* ApiManagement - tenant/settings endpoints fix 5

Co-authored-by: Samir Solanki <[email protected]>
Co-authored-by: maksimkim <[email protected]>
Co-authored-by: promoisha <[email protected]>
Co-authored-by: REDMOND\glfeokti <[email protected]>
Co-authored-by: RupengLiu <[email protected]>
Co-authored-by: vfedonkin <[email protected]>

* Add "mail" parameter to UserUpdateParameters in graphrbac (#12127)

This patch adds a single optional field "mail" to UserUpdateParameters
schema. This makes it possible to update user's e-mail address using
the (Go) Azure SDK. Currently this is not possible.

I have curled the graphrbac API with the extra body parameter and it
works as expected.

Addition of the field will make it possible to support the mail property
on the azuread_user resource in terraform-provider-azuread.

Co-authored-by: David Čepelík <[email protected]>

* [Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 (#12262)

* add resourcegraph track2 config (#12122)

* add reservations track2 config (#12027)

* Removing a readonly tag from a property (#12254)

* Fix swagger correctness errors (#12246)

* Fix swagger correctness issues in Security for Iot service

* changed int format from 32 to 64

* Add systemData to iotSecuritySolutions

Co-authored-by: Liran Chen <[email protected]>

* [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12196)

* AAS - Swagger Linting and Correctness Fix (#12176)

* Fix R4013 IntegerTypeMustHaveFormat

* Fix R4010 RequiredDefaultResponse

* Fix R4007 DefaultErrorResponseSchema

* removed extra bracket

* fix semantic issue

* add type error

* Fix linting issue

* test to resolve model validation test

* Revert "test to resolve model validation test"

This reverts commit ab273df.

* Resolve Model Validation Issue

* Resolve Model Validation Issue v2

* test - add missing properties

(cherry picked from commit 48ec27c)

* fix format

* set default value

* add x-ms-enum

* fix nit

* Add missing property

* add missing properties

* add missing bracket

* change GatewayListStatusLive type

* add missing "origin" property

* fix model validation

* Revert "change GatewayListStatusLive type"

This reverts commit 4f3fa74.

* Revert "fix model validation"

This reverts commit 945bc23.

* add redhatopenshift track2 config (#12045)

* [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-10-01 (#12194)

* Adding nextLink and previousLink to Tags endpoint properties

* moving properties out

* prettier check fix

Co-authored-by: Jorge Chavez Nieto <[email protected]>

* add relay track2 config (#11495)

* update healthbot t2 config (#12269)

* update healthbot t2 config

* fix readme

* add automation track2 config (#11628)

* add automation track2 config

* update config

* Azure Remote Rendering REST API swagger file - for review (#12015)

* Azure Remote Rendering API specifcation

* fix schema issue

* fix examples

* fix request bodies integer values, :stop path

* pointing readme.md to open api spec for ARR

* fix typo, add custom words

* add msvc to custom words

* fix readme.md

* ran prettifier

* fix reference to json

* reference sts from file as well

* fix readme.md

* changes to readme.md

* remove example from error to fix error

* add 200 OK status for retried PUT for conversions and sessiosn

* ran prettier

* make autorest linter not crash

* fix casing of nextLinkName paramter

* factor out conversion list response

* add examples for conversions

* adding examples for sessions, prettify files

* [Hub Generated] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 (#12175)

* microsoft.imagery 512 not supported

Adding micorosft.imagery to 512 tile not supported list

* Updating Raster Tilesets to Have Max Zoom 22

Certain raster tilesets now support up to zoom level 22.

* minor changes to swagger (#12253)

* minor changes to swagger

* reverting sdk definitions file

* Add addons to AVS 2020-07-17-preview (#12236)

* found missing AVS/privateclouds/addons commit, moving it to 2020-07-17-preview API from PR repo

* fixed prettier errors

* Fixed vladation warnings for x-ms-enum and missing description/title, related to addons

* fixed validation error for missing systemData for addons responses

* fixed prettier errors

* fixed validation error for missing systemData for addons responses

* systemData for any Resource

* make sure systemData is readOnly

* systemData needs to go in a new api version

* suppress systemData error

Co-authored-by: Cameron Taggart <[email protected]>

* Azs api bug fix (#12133)

* Old api version for ComputeOperationResult

* Api Bugfix for Azure Stack Fabric Admin

* Fix for typo in readme

* Add default reponse

* Fix example issue for default error

* Update comment.yml (#12273)

* [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#12031)

* fix dataSet typo

* fix dimensions and tags typo

* more dimensions and tags to fix

* one more miss on dimensions and tags

* Add the includeMonetaryCommitment missing field

* fix spell check error

* make property read only

* remove the not operation from query filters

* New backup service api version (#12171)

* Initial commit: adding new api version

* - new api 2020-12-01

* updating the readme.md package reference

* - adding the zone information for new api

* - updating api-version in examples
- added 'zone' in Get recoverypoint api example json

* Fixing prettier issue

* Revert "- updating api-version in examples"

This reverts commit 80baa9f.

* - adding api-version in examples

* adding new api version in package mds

* [IotHub] Introducing networkRuleSets in IotHubProperties [2020-08-31 : preview and stable ] (#10853)

* Adds base for updating Microsoft.Devices from version preview/2020-07-10-preview to version 2020-08-31-preview

* Updates readme

* Updates API version in new specs and examples

* Adds base for updating Microsoft.Devices from version stable/2020-08-01 to version 2020-08-31

* Updates readme

* Updates API version in new specs and examples

* Adding networkRuleSets support for iothub

* Adding networkRuleSets Support in preview version

* Adding Examples, correcting order in iothub.json

* Updating Readme to have stable and previe versions

* Modifying Tag to package-2020-08-31

* Adding Arm identity properties from 2020-07-010-preview version

* Removing creds

* minor fix

* swagger correctness fix (#12101)

* swagger correctness fix

* update preview version too

* Revert change and add defaults (#12243)

* Remove gallery preview version 2020-09-30 from stable release (#12222)

* add managementpartner track2 config (#12043)

* [Hub Generated] Review request for Microsoft.Insights to add version stable/2019-03-01 (#12232)

* Fixed swagger validations for api version 2019

* reverted error response change and suppress

* removed redundant error details

* renamed suppression rule

* fixed suppression

Co-authored-by: napolish <[email protected]>
Co-authored-by: Phoenix He <[email protected]>
Co-authored-by: arpja <[email protected]>
Co-authored-by: ShaniFelig <[email protected]>
Co-authored-by: Pan Li <[email protected]>
Co-authored-by: Zach Rathbun <[email protected]>
Co-authored-by: surashed <[email protected]>
Co-authored-by: Kaihui (Kerwin) Sun <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: om-nishant <[email protected]>
Co-authored-by: Ihar Voitka <[email protected]>
Co-authored-by: Ruoxuan Wang <[email protected]>
Co-authored-by: Ju Hee Lee <[email protected]>
Co-authored-by: xiazhan <[email protected]>
Co-authored-by: kai ru <[email protected]>
Co-authored-by: Ji Wang <[email protected]>
Co-authored-by: Andy Zhang <[email protected]>
Co-authored-by: guy-microsoft <[email protected]>
Co-authored-by: PoAn (Baron) Chen <[email protected]>
Co-authored-by: Arcturus <[email protected]>
Co-authored-by: suyash691 <[email protected]>
Co-authored-by: nemijato <[email protected]>
Co-authored-by: brpanask <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Eli Arbel <[email protected]>
Co-authored-by: David Han <[email protected]>
Co-authored-by: Roman Khotsyn <[email protected]>
Co-authored-by: David R. Williamson <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: Xinyi Joffre <[email protected]>
Co-authored-by: roytan-microsoft <[email protected]>
Co-authored-by: Vitaliy Fedonkin <[email protected]>
Co-authored-by: Samir Solanki <[email protected]>
Co-authored-by: maksimkim <[email protected]>
Co-authored-by: promoisha <[email protected]>
Co-authored-by: REDMOND\glfeokti <[email protected]>
Co-authored-by: RupengLiu <[email protected]>
Co-authored-by: vfedonkin <[email protected]>
Co-authored-by: David Čepelík <[email protected]>
Co-authored-by: David Čepelík <[email protected]>
Co-authored-by: mudit794 <[email protected]>
Co-authored-by: Dhawal Jain <[email protected]>
Co-authored-by: MichalHel <[email protected]>
Co-authored-by: Liran Chen <[email protected]>
Co-authored-by: jochav <[email protected]>
Co-authored-by: Jorge Chavez Nieto <[email protected]>
Co-authored-by: rikogeln <[email protected]>
Co-authored-by: chgennar <[email protected]>
Co-authored-by: hivyas <[email protected]>
Co-authored-by: Douglas Lee <[email protected]>
Co-authored-by: Cameron Taggart <[email protected]>
Co-authored-by: LingyunSu <[email protected]>
Co-authored-by: elabicha <[email protected]>
Co-authored-by: Nikhil Kumar Mengani <[email protected]>
Co-authored-by: Junbo Wang <[email protected]>
Co-authored-by: Daniel Orozco <[email protected]>
Co-authored-by: Adam Sandor <[email protected]>
Co-authored-by: yashmuel <[email protected]>
  • Loading branch information
Show file tree
Hide file tree
Showing 531 changed files with 54,023 additions and 8,993 deletions.
6,015 changes: 0 additions & 6,015 deletions .azure-pipelines-preproduction/package-lock.json

This file was deleted.

47 changes: 0 additions & 47 deletions .azure-pipelines-preproduction/package.json

This file was deleted.

15 changes: 12 additions & 3 deletions .github/comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
- rule:
type: label
label: BreakingChangeReviewRequired
onLabeledComments: "Hi @${PRAuthor}, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review. </br>**Action**: To initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).</br> If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback."
variables:
openapiHub: https://portal.azure-devex-tools.com
onLabeledComments: "Hi @${PRAuthor}, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review. </br>**Action**: To initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).</br> If you want to know the production traffic statistic, please see [ARM Traffic statistic](${openapiHub}/api/pr/query-traffic?pr=${owner}/${repo}/${PRNumber}&days=5). </br> If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback."

- rule:
type: label
Expand All @@ -31,12 +33,19 @@
- rule:
type: label
label: CI-FixRequiredOnFailure
onLabeledComments: "Hi @${PRAuthor}, Your PR has some issues. Please fix the CI sequentially by following the order of `Avocado, semantic validation, model validation, breaking change, lintDiff`. <table><tr><th>Task</th><th>How to fix</th><th>Priority</th><th>Support</th></tr><tr><td>Avocado</td><td>[Fix-Avocado](https://github.com/Azure/avocado)</td><td>High</td><td>[email protected]</td></tr><tr><td>LintDiff</td><td>[Fix-LintDiff](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#linter-validation)</td><td>high</td><td>[email protected], [email protected]</td></tr><tr><td>Semantic validation</td><td>[Fix-SenmanticValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#semantic-validation)</td><td>High</td><td>[email protected], [email protected]</td></tr><tr><td>Model validation</td><td>[Fix-ModelValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#model-validation)</td><td>High</td><td>[email protected],[email protected]</td></tr></table> If you need further help, please feedback via [swagger feedback](https://aka.ms/swaggerfeedback)."
onLabeledComments: >-
Hi @${PRAuthor}, Your PR has some issues. Please fix the CI sequentially by following the order of `Avocado, semantic validation, model validation, breaking change, lintDiff`.
<table><tr><th>Task</th><th>How to fix</th><th>Priority</th><th>Support (Microsoft alias)</th></tr>
<tr><td>Avocado</td><td>[Fix-Avocado](https://github.com/Azure/avocado)</td><td>High</td><td>ruowan</td></tr>
<tr><td>Semantic validation</td><td>[Fix-SemanticValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#semantic-validation)</td><td>High</td><td>raychen, jianyxi</td></tr>
<tr><td>Model validation</td><td>[Fix-ModelValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#model-validation)</td><td>High</td><td>raychen,jianyxi</td></tr>
<tr><td>LintDiff</td><td>[Fix-LintDiff](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#linter-validation)</td><td>high</td><td>jianyxi, ruoxuan</td></tr></table>
If you need further help, please feedback via [swagger feedback](https://aka.ms/swaggerfeedback)."
- rule:
type: PROpen
variables:
openapiHub: https://openapihub.test.azure-devex-tools.com/
openapiHub: https://portal.azure-devex-tools.com
keywords:
- "I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow."
onOpenedComments: "Hi, @${PRAuthor} Thanks for your PR. I am workflow bot for review process. Here are some small tips. </br> <li> Please ensure to do self-check against checklists in first PR comment.</li> <li> PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging. </li> <li> For specs comparison cross API versions, Use [API Specs Comparison Report Generator](${openapiHub}/tools/diff?pr=${owner}/${repo}/${PRNumber})</li> <li> If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. [How to fix?](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md)</li></br> Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]"
Expand Down
6 changes: 6 additions & 0 deletions .github/pull_request_assignment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@
- "specification/testbase/**"
reviewers:
- PhoenixHe-msft

- rule:
paths:
- "specification/servicelinker/**"
reviewers:
- PhoenixHe-msft

- rule:
paths:
Expand Down
7 changes: 7 additions & 0 deletions custom-words.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,7 @@ MSAZR
MSAZRDE
MSAZRUSGO
MSCONCAT
mscv
MSGETACLSTATUS
MSGETFILESTATUS
msix
Expand Down Expand Up @@ -1233,6 +1234,7 @@ paramref
PARAVIRTUAL
partnertopic
Passthrough
passwd
patternanyentities
patternrule
patternrules
Expand All @@ -1259,6 +1261,7 @@ Phonetik
phplogging
phraselist
phraselists
Pids
pipelineruns
PITR
pixelated
Expand Down Expand Up @@ -1415,6 +1418,8 @@ remediate
remediated
Remediations
remoteloginsettings
remoterendering
remoterenderingvm
remoteuser
REMOVEACL
REMOVEACLENTRIES
Expand Down Expand Up @@ -1699,6 +1704,7 @@ subfolders
subinquireditemcount
sublist
sublists
submount
subnames
subnet
subnet's
Expand All @@ -1722,6 +1728,7 @@ subword
subwords
sudoer
suggesters
suid
Superfresh
superset
supportedimages
Expand Down
33 changes: 12 additions & 21 deletions documentation/Semantic-and-Model-Violations-Reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ This document lists the set of automated rules that can be validated against swa
| [INVALID_RESPONSE_CODE](#INVALID_RESPONSE_CODE) | |
| [INVALID_RESPONSE_BODY](#INVALID_RESPONSE_BODY) | |
| [MISSING_REQUIRED_PARAMETER](#MISSING_REQUIRED_PARAMETER) | |
| [KEYWORD_TYPE_EXPECTED](#KEYWORD_TYPE_EXPECTED) | |
| [READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST](#READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST) | |
| [SCHEMA_VALIDATION_FAILED](#SCHEMA_VALIDATION_FAILED) | |
| [SECRET_PROPERTY](#SECRET_PROPERTY) | |
| [DISCRIMINATOR_VALUE_NOT_FOUND](#DISCRIMINATOR_VALUE_NOT_FOUND) | |
| [DISCRIMINATOR_NOT_REQUIRED](#DISCRIMINATOR_NOT_REQUIRED) | [OAV131](#DISCRIMINATOR_NOT_REQUIRED) |
| [RESPONSE_BODY_NOT_IN_EXAMPLE](#RESPONSE_BODY_NOT_IN_EXAMPLE) | [OAV130](#RESPONSE_BODY_NOT_IN_EXAMPLE) |
Expand Down Expand Up @@ -359,14 +359,6 @@ This document lists the set of automated rules that can be validated against swa

**How to fix the violation**: The error info has the position of swagger, look for the position in swagger and fix the value type of keyword.

### <a name="KEYWORD_TYPE_EXPECTED" />KEYWORD_TYPE_EXPECTED

**Output Message**: Keyword '{0}' is expected to be of type '{1}'.

**Description**: The value of the keyword in swagger should be the specific type.

**How to fix the violation**: Fix the value type of keyword.

### <a name="PATTERN" />PATTERN

**Output Message**: String does not match pattern {0}: {1}.
Expand Down Expand Up @@ -547,9 +539,9 @@ This document lists the set of automated rules that can be validated against swa

**Output Message**: This operation does not have a defined {0} response code.

**Description**: There's extra response code defined in example file.
**Description**: The specified response code is not defined in example file.

**How to fix the violation**: Remove extra response code definition in example or correct it.
**How to fix the violation**: Add response code to default, or add response code definition in the swagger.

### <a name="INVALID_RESPONSE_BODY" />INVALID_RESPONSE_BODY

Expand All @@ -559,15 +551,6 @@ This document lists the set of automated rules that can be validated against swa

**How to fix the violation**: Add response body.


### <a name="KEYWORD_TYPE_EXPECTED" />KEYWORD_TYPE_EXPECTED

**Output Message**: Keyword 'type' is expected to be of type 'array,boolean,integer,number,null,object,string'.

**Description**: According to Json schema spec, the allowed value for [type](http://json-schema.org/latest/json-schema-validation.html#rfc.section.6.1.1) is 'array,boolean,integer,number,null,object,string'.

**How to fix the violation**: Set the value of type to one of the values above.

### <a name="OBJECT_ADDITIONAL_PROPERTIES" />OBJECT_ADDITIONAL_PROPERTIES

**Output Message**: Additional properties not allowed:{0}.
Expand Down Expand Up @@ -801,6 +784,14 @@ This document lists the set of automated rules that can be validated against swa

**How to fix the violation**: Remove this definition if it's not used.

### <a name="SECRET_PROPERTY" />SECRET_PROPERTY

**Output Message**: Secret property {0} cannot be sent in the response.

**Description**: The secret is not allowed to return in response when it's annotated with x-ms-secret:true.

**How to fix the violation**: Remove this secret value from the response.


### <a name="ROUNDTRIP_INCONSISTENT_PROPERTY" />ROUNDTRIP_INCONSISTENT_PROPERTY

Expand All @@ -826,4 +817,4 @@ This document lists the set of automated rules that can be validated against swa

**Description**: The property was not in the PUT request, but it is returned in the subsequent GET response. This implies that the property is read-only or has a default value.

**How to fix the violation**: If the property is a read-only, update the swagger definition for this property to mark it as "readOnly": true. Alternatively, keep the property in the GET schema but remove it from the PUT schema. If the property has a default value, update the Swagger definition for this property to mark it with "default": <default value> annotation.
**How to fix the violation**: If the property is a read-only, update the swagger definition for this property to mark it as "readOnly": true. Alternatively, keep the property in the GET schema but remove it from the PUT schema. If the property has a default value, update the Swagger definition for this property to mark it with "default": <default value> annotation.
Loading

0 comments on commit d3023cc

Please sign in to comment.