Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #12020

Merged
merged 16 commits into from
Dec 15, 2020
Merged

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #12020

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
84af87b
Update advisor.json
yenchunchang Dec 8, 2020
4e96a34
Update advisor.json
yenchunchang Dec 8, 2020
a1f6a9e
Update CreateSuppression.json
yenchunchang Dec 8, 2020
f130808
Update CreateSuppression.json
yenchunchang Dec 9, 2020
6cf7c36
Update GetSuppressionDetail.json
yenchunchang Dec 9, 2020
a7bc3e0
Update advisor.json
yenchunchang Dec 9, 2020
1733058
Update advisor.json
yenchunchang Dec 9, 2020
8db67d8
Update advisor.json
yenchunchang Dec 9, 2020
30db949
Adds suppression to readme
yenchunchang Dec 9, 2020
c5dc398
Adds suppression to readme
yenchunchang Dec 9, 2020
a068299
Update readme.md
yenchunchang Dec 10, 2020
ec9d8d6
Update readme.md
yenchunchang Dec 10, 2020
34b8ec8
Update readme.md
yenchunchang Dec 10, 2020
9d86c08
Update readme.md
yenchunchang Dec 10, 2020
de87258
Add body to GetSuppressionDetail.json
yenchunchang Dec 10, 2020
72c25a7
Update response body for CreateSuppression.json
yenchunchang Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@
"404": {
"description": "Suppression name is not specified or Suppression Id not found.",
"schema": {
"$ref": "#/definitions/ARMErrorResponseBody"
"$ref": "#/definitions/ARMErrorResponse"
}
}
},
Expand Down Expand Up @@ -603,6 +603,12 @@
"schema": {
"$ref": "#/definitions/SuppressionContract"
}
},
"404": {
"description": "Recommendation to be suppressed is not found.",
"schema": {
"$ref": "#/definitions/ARMErrorResponse"
}
}
},
"deprecated": false,
Expand Down
6 changes: 6 additions & 0 deletions ...isor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/CreateSuppression.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
"ttl": "07:00:00:00"
}
}
},
"404": {
"body": {
"code": "NotFound",
"message": "Recommendation to be suppressed is not found. Subscription Id:{0} Recommendation Id:{1}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incorrect. Needs to have error as key.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may need to fix example in other suppression .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! I've updated both of them.

Copy link
Contributor

@mudit794 mudit794 Dec 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why model and semantic validation is failing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realize that should be lowercase for A"rm"ErrorResponse for the model validation it is complaining no response body for CreateSuppression.json and GetSuppressionDetail.json which is weird because we are using ArmErrorResponse it should be "error" and not "body" like your comment has mentioned I will check how others are using it if that is identical with others' cases I will file for exception for false positive case.

}
}
}
}