[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #12020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version adds a response code '404'. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L607:11 |
|
The new version is missing a property found in the old version. Was 'message' renamed or removed? New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L928:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L931:7 |
|
The new version is missing a property found in the old version. Was 'code' renamed or removed? New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L928:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L931:7 |
|
The new version has a new property 'error' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L928:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L931:7 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
Swagger Generation Artifacts
|
|
Hi, @rebiex Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
Hi @rebiex, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
mudit794
reviewed
Dec 9, 2020
| "404": { | ||
| "body": { | ||
| "code": "NotFound", | ||
| "message": "Recommendation to be suppressed is not found. Subscription Id:{0} Recommendation Id:{1}" |
There was a problem hiding this comment.
this is incorrect. Needs to have error as key.
There was a problem hiding this comment.
you may need to fix example in other suppression .
There was a problem hiding this comment.
Thanks for the catch! I've updated both of them.
There was a problem hiding this comment.
Any reason why model and semantic validation is failing?
There was a problem hiding this comment.
Just realize that should be lowercase for A"rm"ErrorResponse for the model validation it is complaining no response body for CreateSuppression.json and GetSuppressionDetail.json which is weird because we are using ArmErrorResponse it should be "error" and not "body" like your comment has mentioned I will check how others are using it if that is identical with others' cases I will file for exception for false positive case.
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
This was referenced Dec 9, 2020
This was referenced Dec 9, 2020
mudit794
approved these changes
Dec 10, 2020
|
Breaking change review is pending https://msazure.visualstudio.com/One/_workitems/edit/8956607 |
JeffreyRichter
added
the
Approved-BreakingChange
JeffreyRichter
approved these changes
Dec 14, 2020
ChenTanyi
approved these changes
Dec 15, 2020
This was referenced Dec 15, 2020
Closed
[ReleasePR azure-mgmt-advisor] add error response flag for 400 code
Azure/azure-sdk-for-python#15523
Closed
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…table/2020-01-01 (Azure#12020) * Update advisor.json * Update advisor.json * Update CreateSuppression.json * Update CreateSuppression.json * Update GetSuppressionDetail.json * Update advisor.json * Update advisor.json * Update advisor.json * Adds suppression to readme * Adds suppression to readme * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Add body to GetSuppressionDetail.json * Update response body for CreateSuppression.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.