[Hub Generated] Review request for Microsoft.Insights to add version stable/2020-10-01 #11579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-01 to version 2020-10-01
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response of operation:'ActivityLogAlerts_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L41 |
|
The response of operation:'ActivityLogAlerts_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L99 |
|
The response of operation:'ActivityLogAlerts_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L173 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 16 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/activityLogAlerts/{activityLogAlertName}' removed or restructured? Old: Microsoft.Insights/preview/2017-03-01-preview/activityLogAlerts_API.json#L39:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/microsoft.insights/activityLogAlerts' removed or restructured? Old: Microsoft.Insights/preview/2017-03-01-preview/activityLogAlerts_API.json#L217:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/activityLogAlerts' removed or restructured? Old: Microsoft.Insights/preview/2017-03-01-preview/activityLogAlerts_API.json#L254:5 |
|
| The new version is missing a definition that was found in the old version. Was 'ActivityLogAlert' removed or renamed? New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L296:3 Old: Microsoft.Insights/preview/2017-03-01-preview/activityLogAlerts_API.json#L295:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActivityLogAlertAllOfCondition' removed or renamed? New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L296:3 Old: Microsoft.Insights/preview/2017-03-01-preview/activityLogAlerts_API.json#L295:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActivityLogAlertActionList' removed or renamed? New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L296:3 Old: Microsoft.Insights/preview/2017-03-01-preview/activityLogAlerts_API.json#L295:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActivityLogAlertResourcePatch' removed or renamed? New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L296:3 Old: Microsoft.Insights/preview/2017-03-01-preview/activityLogAlerts_API.json#L295:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActivityLogAlertPatch' removed or renamed? New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L296:3 Old: Microsoft.Insights/preview/2017-03-01-preview/activityLogAlerts_API.json#L295:3 |
|
| The new version has a different type 'object' than the previous one ''. New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L343:9 Old: Microsoft.Insights/preview/2017-03-01-preview/activityLogAlerts_API.json#L342:9 |
|
| The new version has a different type 'object' than the previous one ''. New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L377:9 Old: Microsoft.Insights/preview/2017-03-01-preview/activityLogAlerts_API.json#L375:9 |
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 16 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2017-04-01/activityLogAlerts_API.json <---> new: stable/2020-10-01/activityLogAlerts_API.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/activityLogAlerts/{activityLogAlertName}' removed or restructured? Old: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L39:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/microsoft.insights/activityLogAlerts' removed or restructured? Old: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L213:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/activityLogAlerts' removed or restructured? Old: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L249:5 |
|
| The new version is missing a definition that was found in the old version. Was 'ActivityLogAlert' removed or renamed? New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L296:3 Old: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L289:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActivityLogAlertAllOfCondition' removed or renamed? New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L296:3 Old: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L289:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActivityLogAlertActionList' removed or renamed? New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L296:3 Old: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L289:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActivityLogAlertPatchBody' removed or renamed? New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L296:3 Old: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L289:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActivityLogAlertPatch' removed or renamed? New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L296:3 Old: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L289:3 |
|
| The new version has a different type 'object' than the previous one ''. New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L343:9 Old: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L336:9 |
|
| The new version has a different type 'object' than the previous one ''. New: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L377:9 Old: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L374:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄[Staging] SDK Track2 Validation inProgress [Detail]
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-java
|
azure-sdk-for-go
|
azure-resource-manager-schemas
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Nov 8, 2020
This was referenced Nov 8, 2020
|
Hi, @InbalZim Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi @InbalZim, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
Hi @InbalZim, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
Hi @InbalZim, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 10, 2021
Closed
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Feb 10, 2021
…into fix_resource_multiapi_submodule * 'master' of https://github.com/Azure/azure-rest-api-specs: (452 commits) Dev cost management microsoft.cost management 2020 12 01 preview new (Azure#12259) Edit securityContact swagger for 2020-01-01 (Azure#12265) [Hub Generated] Review request for Microsoft.Insights to add version stable/2020-10-01 (Azure#11579) [Hub Generated] Review request for Microsoft.Media to add version stable/2020-05-01 (Azure#12681) Fix TimeSeriesInsights swagger issues (Azure#12204) Fixing error in lastModifiedAt description (Azure#12854) Update comment.yml (Azure#12910) Fixing RI s360 Flagged corrections in 2019-10-01 version (Azure#12777) [Hub Generated] Review request for Microsoft.Web to add version stable/2020-10-01 (Azure#11636) [Ready For Review] New version 20210101 (Azure#12111) Update scheduledQueryRule_API.json (Azure#12895) Remove UserAssigned MSI (Azure#12900) Update library.json (Azure#12922) KeyVault: Feature/update security domain spec (Azure#12863) Fixes ExampleId type and incorrect ArmTokenParameter name (Azure#12896) Update contract for anomaly detector (Azure#12487) [NetAppFiles] Urgent bug fix, backup response, remove systemData(not in response yet) (Azure#12852) [AML] Add PipelineEndpoint with version and DataPathAssignments fields in AzureMLExecutePipeline (Azure#12744) remove duplicated schema (Azure#12779) [Web] Add Swagger for Service Principal (Azure#12780) ...
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…stable/2020-10-01 (Azure#11579) * Adds base for updating Microsoft.Insights from version stable/2017-04-01 to version 2020-10-01 * Updates readme * Updates API version in new specs and examples * Removed API related to ActionGroup from the new api-version * Implemented new api-version * Added more exmamples and renamed them * Adds suppression to readme * Adds suppression to readme * Adds suppression to readme * Ran prettier * Reverted error response to match previous one, to not intoduce breaking change * Added suppression for error response * Fixed error response suppression * Ran prettier + improved error response suppression * Reverted ALA API operationIds so it won't be a breaking change for Python * Reverted parameter + definition names to no be breaking change * Fixed examples according to parameters and defs revert * Checking push * Reverting Inbal's merge today * Fixing "The example JSON file is not referenced from the swagger file." * Adding to readme.azureresourceschema.md * fixing python package * Reverting last commit * Fixing python readme Co-authored-by: Natalie Polishuk 🦝 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.