Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready For Review] New version 20210101 #12111

Merged
merged 70 commits into from
Feb 10, 2021
Merged

[Ready For Review] New version 20210101 #12111

merged 70 commits into from
Feb 10, 2021

Conversation

zhaomuzhi
Copy link
Contributor

@zhaomuzhi zhaomuzhi commented Dec 14, 2020 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

zhaomuzhi and others added 30 commits April 3, 2020 15:32
@zhaomuzhi
Add Identity to createWorkpace example
8dbb48b
@zhaomuzhi
Merge branch 'master' of https://github.com/zhaomuzhi/azure-rest-api-…
9cba54d 
…specs
@zhaomuzhi
Merge remote-tracking branch 'upstream/master'
b5e4863
@zhaomuzhi
Merge remote-tracking branch 'upstream/master'
02a2401
@zhaomuzhi
Merge remote-tracking branch 'upstream/master'
f2ceaf1
@zhaomuzhi
Merge remote-tracking branch 'upstream/master'
a6591d5
@zhaomuzhi
Merge remote-tracking branch 'upstream/master'
84ec88f
@zhaomuzhi
change for getTransitivePEUsages
ac5afcb
@zhaomuzhi
update
bf923f0
@zhaomuzhi
prettier code
2ab304a
@zhaomuzhi
add another new endpoint
e4a5d19
@zhaomuzhi
address comments
8f20ad7
@zhaomuzhi
change for getTransitivePEUsages
5eee086
@zhaomuzhi
update
a34a194
@zhaomuzhi
prettier code
0a23a85
@zhaomuzhi
add another new endpoint
b87f8e9
@zhaomuzhi
address comments
7c91175
@zhaomuzhi
revert change on transitivePE and notebookKeys
0696b9e
@zhaomuzhi
Merge branch 'master' of https://github.com/zhaomuzhi/azure-rest-api-…
2981eb3 
…specs
@zhaomuzhi
revert change on transitivePE and notebookKeys
072a51f
@zhaomuzhi
Merge remote-tracking branch 'upstream/master'
3b010c7
@zhaomuzhi
Merge remote-tracking branch 'upstream/master'
c40a15e
@zhaomuzhi
add new stable version 2021-01-01
1d693a7
@zhaomuzhi
add ListNotebookAccessToken
0bc494b
@zhaomuzhi
add primaryUserAssignedIdentity
a85c418
@zhaomuzhi
fix missing properties and apis
e13ea29
@zhaomuzhi
fix one more missing property
8e6ddf9
@zhaomuzhi
Merge remote-tracking branch 'upstream/master'
1df7b8e
@DeMale
support for cmk uai
24dcc26
@DeMale
addressed comments
292a5c0
@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 21, 2021
ArcturusZhang
ArcturusZhang reviewed Jan 25, 2021
View reviewed changes
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR LGTM.
Since we are adding this new api-version to Java, could we also add this new api-version to go SDK (we do not need to update other language's SDK because those are using the default tag)?

@zhaomuzhi zhaomuzhi changed the title [DO NOT MERGE][Ready For Review] New version 20210101 [Ready For Review] New version 20210101 Feb 4, 2021
@jianyexi
Copy link
Contributor

jianyexi commented Feb 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ArcturusZhang ArcturusZhang merged commit aac1986 into Azure:master Feb 10, 2021
This was referenced Feb 10, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Feb 10, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
453041d 
…into fix_resource_multiapi_submodule

* 'master' of https://github.com/Azure/azure-rest-api-specs: (452 commits)
  Dev cost management microsoft.cost management 2020 12 01 preview new (Azure#12259)
  Edit securityContact swagger for 2020-01-01 (Azure#12265)
  [Hub Generated] Review request for Microsoft.Insights to add version stable/2020-10-01 (Azure#11579)
  [Hub Generated] Review request for Microsoft.Media to add version stable/2020-05-01 (Azure#12681)
  Fix TimeSeriesInsights swagger issues (Azure#12204)
  Fixing error in lastModifiedAt description (Azure#12854)
  Update comment.yml (Azure#12910)
  Fixing RI s360 Flagged corrections in 2019-10-01 version (Azure#12777)
  [Hub Generated] Review request for Microsoft.Web to add version stable/2020-10-01 (Azure#11636)
  [Ready For Review] New version 20210101 (Azure#12111)
  Update scheduledQueryRule_API.json (Azure#12895)
  Remove UserAssigned MSI (Azure#12900)
  Update library.json (Azure#12922)
  KeyVault: Feature/update security domain spec (Azure#12863)
  Fixes ExampleId type and incorrect ArmTokenParameter name (Azure#12896)
  Update contract for anomaly detector (Azure#12487)
  [NetAppFiles] Urgent bug fix, backup response, remove systemData(not in response yet) (Azure#12852)
  [AML] Add PipelineEndpoint with version and DataPathAssignments fields in AzureMLExecutePipeline (Azure#12744)
  remove duplicated schema (Azure#12779)
  [Web] Add Swagger for Service Principal (Azure#12780)
  ...
mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
@zhaomuzhi @DeMale
@forteddyt @VinayRSoni @mkarmark
[Ready For Review] New version 20210101 (Azure#12111)
9152f3d 
* Add Identity to createWorkpace example

* change for getTransitivePEUsages

* update

* prettier code

* add another new endpoint

* address comments

* change for getTransitivePEUsages

* update

* prettier code

* add another new endpoint

* address comments

* revert change on transitivePE and notebookKeys

* revert change on transitivePE and notebookKeys

* add new stable version 2021-01-01

* add ListNotebookAccessToken

* add primaryUserAssignedIdentity

* fix missing properties and apis

* fix one more missing property

* support for cmk uai

* addressed comments

* fix ref error

* fix linterror

* fix pipeline errors

* fix more properties

* fix lintdiff error and prettier error

* ListNodes should be marked as pageable

* Default value for IsolatedNetwork should be false not null

* update aksProperties for agentVmSize and clusterPurpose

* Add "auto" enum to SslConfiguration.status

* add setupScripts property to computeInstance

* add workspaceUrl to databricks

* mark osType readonly

* set default of ostype. dont make readonly

* dont capitalize setupscripts

* fix property clusterPurpose

* define SetupScripts

* description should not be capitalized

* AmlComputeNodesInformation update for nextLink

* remove linked service

* add systemData

* add IdentityType reference

* fix systemData

* add itemName to pagable on listNodes

* fix prettier

* add cpuLimit and memoryInGBLimit, update desc

* add new property

* address comments

* fix pipeline

* fix pipeline errors

* 202 status for start and stop CI

Co-authored-by: Deepthi Male <[email protected]>
Co-authored-by: Joshua Peterson <[email protected]>
Co-authored-by: thtodoro <[email protected]>
Co-authored-by: Vinay Rajmal Soni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mentat9 mentat9 mentat9 left review comments

@joshanator joshanator joshanator left review comments

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

@lirenhe lirenhe Awaiting requested review from lirenhe

Assignees

@ArcturusZhang ArcturusZhang

Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python DoNotMerge <valid label in PR review process> use to hold merge after approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@zhaomuzhi @ArcturusZhang @mentat9 @jorgecotillo @jianyexi @JeffreyRichter @joshanator @DeMale @forteddyt @VinayRSoni