Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isTransitioned to billing account and billing profile properties. #11077

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6365,6 +6365,11 @@
"$ref": "#/definitions/EnrollmentAccount"
}
},
"isTransitioned": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, api changes like this will need to go in a new api-version. See the breaking change policy, and api guidelines referenced from the PR checklist

"description": "Specifies if the billing account has transitioned from agreement type Microsoft Online Service Program to agreement type Microsoft Customer Agreement.",
"type": "boolean",
"readOnly": true
},
"organizationId": {
"description": "Organization id.",
"type": "string",
Expand Down Expand Up @@ -6868,6 +6873,11 @@
"type": "integer",
"readOnly": true
},
"isTransitioned": {
"description": "Specifies if the billing profile was created during transition of the billing account from agreement type Microsoft Online Service Program to agreement type Microsoft Customer Agreement.",
"type": "boolean",
"readOnly": true
},
"currency": {
"description": "The currency in which the charges for the billing profile are billed.",
"type": "string",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"agreementType": "MicrosoftCustomerAgreement",
"customerType": "Enterprise",
"accountType": "Enterprise",
"organizationId": "00000000-0000-0000-0000-000000000000"
"organizationId": "00000000-0000-0000-0000-000000000000",
"isTransitioned": false
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
],
"invoiceDay": 5,
"invoiceEmailOptIn": true,
"isTransitioned": false,
"poNumber": "ABC12345",
"status": "Warned",
"statusReasonCode": "PastDue",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3852,6 +3852,11 @@
"description": "Indicates whether user has read access to the billing account.",
"type": "boolean",
"readOnly": true
},
"isTransitioned": {
"description": "Specifies if the billing account has transitioned from agreement type Microsoft Online Service Program to agreement type Microsoft Customer Agreement.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to version guidelines this is considered a breaking change, so I doubt we can add it to the stable version.
See: https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#versioning

"type": "boolean",
"readOnly": true
}
}
},
Expand Down Expand Up @@ -4369,6 +4374,11 @@
"type": "boolean",
"readOnly": true
},
"isTransitioned": {
"description": "Specifies if the billing profile was created during transition of the billing account from agreement type Microsoft Online Service Program to agreement type Microsoft Customer Agreement.",
"type": "boolean",
"readOnly": true
},
"systemId": {
"description": "The system generated unique identifier for a billing profile.",
"type": "string",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"agreementType": "MicrosoftCustomerAgreement",
"accountStatus": "Active",
"accountType": "Enterprise",
"hasReadAccess": true
"hasReadAccess": true,
"isTransitioned": false
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"invoiceEmailOptIn": true,
"poNumber": "ABC12345",
"hasReadAccess": true,
"isTransitioned": false,
"systemId": "1XXX-11XX-XX1-XXXX-XXX",
"status": "Warned",
"statusReasonCode": "PastDue",
Expand Down