Added isTransitioned to billing account and billing profile properties. #11077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
No pipelines are associated with this pull request. |
wilcobmsft
approved these changes
Oct 8, 2020
| @@ -3852,6 +3852,11 @@ | |||
| "description": "Indicates whether user has read access to the billing account.", | |||
| "type": "boolean", | |||
| "readOnly": true | |||
| }, | |||
| "isTransitioned": { | |||
| "description": "Specifies if the billing account has transitioned from agreement type Microsoft Online Service Program to agreement type Microsoft Customer Agreement.", | |||
There was a problem hiding this comment.
According to version guidelines this is considered a breaking change, so I doubt we can add it to the stable version.
See: https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#versioning
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-go
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
This was referenced Oct 9, 2020
This was referenced Oct 9, 2020
markcowl
requested changes
Oct 9, 2020
| @@ -6365,6 +6365,11 @@ | |||
| "$ref": "#/definitions/EnrollmentAccount" | |||
| } | |||
| }, | |||
| "isTransitioned": { | |||
There was a problem hiding this comment.
Unfortunately, api changes like this will need to go in a new api-version. See the breaking change policy, and api guidelines referenced from the PR checklist
|
@jbuls unfortunately, api changes require an api-version increment, except for security and compliance changes. See: https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#api-changes-that-require-a-version-change If you think you have a good case for an exception, the process is here: https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/43942/Policy-for-Breaking-Changes |
|
Hi, @jbuls. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @jbuls. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee @jbuls, @akning-ms. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.