Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synapse] - Update Operations.json #10214

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

idear1203
Copy link
Contributor

@idear1203 idear1203 commented Jul 21, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

A PR to follow up #10171

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 21, 2020

[Staging] Swagger Validation Report

BreakingChange: 7 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'Operations_List' to 'SqlV3Operations_List'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L25:7
Old: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L25:7
1008 - ModifiedOperationId The operation id has been changed from 'Operations_GetLocationHeaderResult' to 'SqlV3Operations_GetLocationHeaderResult'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L62:7
Old: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L56:7
1008 - ModifiedOperationId The operation id has been changed from 'Operations_GetAzureAsyncHeaderResult' to 'SqlV3Operations_GetAzureAsyncHeaderResult'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L117:7
Old: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L111:7
1011 - AddingResponseCode The new version adds a response code 'default'.
New: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L47:11
1011 - AddingResponseCode The new version adds a response code 'default'.
New: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L157:11
1012 - RemovedResponseCode The new version removes the response code '404'
Old: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L151:11
1012 - RemovedResponseCode The new version removes the response code '500'
Old: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L154:11
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@idear1203 idear1203 requested a review from leniatgh July 21, 2020 08:47
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from fff80e2 with merge commit 2916791. SDK Automation 13.0.17.20200619.4
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from fff80e2 with merge commit 2916791. SDK Automation 13.0.17.20200619.4
  • ⚠️sdk/synapse/mgmt-v2019_06_01_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/BigDataPoolsInner.java:[17,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/OperationsInner.java:[15,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IpFirewallRulesInner.java:[16,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolsInner.java:[16,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolMetadataSyncConfigsInner.java:[13,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspacesInner.java:[19,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceAadAdminsInner.java:[15,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceManagedIdentitySqlControlSettingsInner.java:[13,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateEndpointConnectionsInner.java:[15,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateLinkHubsInner.java:[19,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[42,119] cannot find symbol
      [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
      [mvn]   symbol: class ManagedIntegrationRuntime
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
      [mvn]   symbol: class SelfHostedIntegrationRuntime
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-synapse: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/BigDataPoolsInner.java:[17,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/OperationsInner.java:[15,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IpFirewallRulesInner.java:[16,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolsInner.java:[16,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolMetadataSyncConfigsInner.java:[13,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspacesInner.java:[19,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceAadAdminsInner.java:[15,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceManagedIdentitySqlControlSettingsInner.java:[13,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateEndpointConnectionsInner.java:[15,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateLinkHubsInner.java:[19,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[42,119] cannot find symbol
      [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn] [ERROR]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
      [mvn] [ERROR]   symbol: class ManagedIntegrationRuntime
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
      [mvn] [ERROR]   symbol: class SelfHostedIntegrationRuntime
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 21, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 21, 2020

    azure-sdk-for-js - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from fff80e2 with merge commit 2916791. SDK Automation 13.0.17.20200619.4
      Failed to find any diff after autorest so no changed packages was found.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 21, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @idear1203 idear1203 force-pushed the synapse_update_operations_json branch from 2d6337c to fff80e2 Compare July 21, 2020 09:06
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @leniatgh leniatgh added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 21, 2020
    @leniatgh leniatgh merged commit 2916791 into Azure:master Jul 21, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    * [Synapse] - Update Operations.json
    
    * Update default response
    
    * Update Example to fix validation error
    
    Co-authored-by: Dongwei Wang <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants