Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synapse] - Update swagger spec for Synapse Sql Gen3 resources #10171

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

idear1203
Copy link
Contributor

@idear1203 idear1203 commented Jul 16, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 16, 2020

[Staging] Swagger Validation Report

BreakingChange: 6 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SqlPool' removed or renamed?
New: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L275:3
Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L275:3
1008 - ModifiedOperationId The operation id has been changed from 'SqlPools_Get' to 'SqlPoolsV3_Get'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L20:7
Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L20:7
1008 - ModifiedOperationId The operation id has been changed from 'SqlPools_CreateOrUpdate' to 'SqlPoolsV3_CreateOrUpdate'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L63:7
Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L63:7
1008 - ModifiedOperationId The operation id has been changed from 'SqlPools_Delete' to 'SqlPoolsV3_Delete'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L125:7
Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L125:7
1008 - ModifiedOperationId The operation id has been changed from 'SqlPools_Update' to 'SqlPoolsV3_Update'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L172:7
Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L172:7
1008 - ModifiedOperationId The operation id has been changed from 'SqlPools_ListByWorkspace' to 'SqlPoolsV3_ListByWorkspace'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L230:7
Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L230:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@idear1203 idear1203 requested a review from phkanekal July 16, 2020 11:28
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 5db19b2 with merge commit 9323a7f. SDK Automation 13.0.17.20200619.4
  • ⚠️sdk/synapse/mgmt-v2019_06_01_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/BigDataPoolsInner.java:[17,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/OperationsInner.java:[15,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IpFirewallRulesInner.java:[16,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolsInner.java:[16,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolMetadataSyncConfigsInner.java:[13,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspacesInner.java:[19,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceAadAdminsInner.java:[15,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceManagedIdentitySqlControlSettingsInner.java:[13,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateEndpointConnectionsInner.java:[15,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateLinkHubsInner.java:[19,66] cannot find symbol
      [mvn]   symbol:   class ErrorContractInnerException
      [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[42,119] cannot find symbol
      [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
      [mvn]   symbol: class ManagedIntegrationRuntime
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
      [mvn]   symbol: class SelfHostedIntegrationRuntime
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-synapse: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/BigDataPoolsInner.java:[17,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/OperationsInner.java:[15,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IpFirewallRulesInner.java:[16,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolsInner.java:[16,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolMetadataSyncConfigsInner.java:[13,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspacesInner.java:[19,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceAadAdminsInner.java:[15,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceManagedIdentitySqlControlSettingsInner.java:[13,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateEndpointConnectionsInner.java:[15,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateLinkHubsInner.java:[19,66] cannot find symbol
      [mvn] [ERROR]   symbol:   class ErrorContractInnerException
      [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[42,119] cannot find symbol
      [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn] [ERROR]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
      [mvn] [ERROR]   symbol: class ManagedIntegrationRuntime
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
      [mvn] [ERROR]   symbol: class SelfHostedIntegrationRuntime
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 16, 2020

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 16, 2020

    azure-sdk-for-python - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 5db19b2 with merge commit 9323a7f. SDK Automation 13.0.17.20200619.4
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 16, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 16, 2020

    azure-sdk-for-python

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from b1776f0 with merge commit 28d5a2b472a87b0a8279030bd52fc58970a8b8b1. SDK Automation 13.0.17.20200619.4
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 16, 2020

    azure-sdk-for-js - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 5db19b2 with merge commit 9323a7f. SDK Automation 13.0.17.20200619.4
      Failed to find any diff after autorest so no changed packages was found.

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @leni-msft
    Copy link
    Contributor

    @idear1203 there're breaking changes error. Please clarify if there would be customer impact? and have you released any sdk for this api version?

    @leni-msft leni-msft added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Jul 20, 2020
    @idear1203
    Copy link
    Contributor Author

    @leni-msft we haven't published any SDK for this Swagger specs so there is no customer impact at all.

    @leni-msft leni-msft added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Jul 21, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 21, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @idear1203 idear1203 force-pushed the synapse_add_sql_dw_gen3 branch from 6ff89af to 5db19b2 Compare July 21, 2020 05:17
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @leni-msft leni-msft self-requested a review July 21, 2020 06:03
    @leni-msft leni-msft merged commit 9323a7f into Azure:master Jul 21, 2020
    leni-msft added a commit that referenced this pull request Jul 21, 2020
    @idear1203 idear1203 mentioned this pull request Jul 21, 2020
    10 tasks
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    …#10171)
    
    * Add SQL DW Gen3
    
    * Add suppression rule for false alert
    
    Co-authored-by: Dongwei Wang <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants