Password fields changes for November breaking change release #4664

darshanhs90 · 2017-09-26T22:58:11Z

Related to #4359

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

markcowl · 2017-09-28T00:47:32Z

Do not merge until the branch is open for November breakign change release #Resolved

markcowl · 2017-10-03T21:53:41Z

@darshanhs90 Please hold off on this PR until next week. Closing for now #Resolved

maddieclayton · 2017-10-26T17:57:33Z

...sourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADAppCredentialCommand.cs

@@ -72,8 +74,9 @@ public override void ExecuteCmdlet()
                    ObjectId = ActiveDirectoryClient.GetObjectIdFromApplicationId(ApplicationId);
                }

+                string decodedPassword = Utilities.SecureStringToString(Password);
 #pragma warning disable 0618


You can remove the #pragma warnings because they were to suppress the obsolete warning. This also applies to all other files. #Resolved

maddieclayton · 2017-10-26T17:59:47Z

...sourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADAppCredentialCommand.cs

@@ -12,10 +12,13 @@
 // limitations under the License.
 // ----------------------------------------------------------------------------------

+using Microsoft.Azure.Commands.Resources;


Are all three of these added dependencies being used? If not please delete all unnecessary usings from all files. #Resolved

maddieclayton · 2017-10-26T18:03:49Z

...sourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADAppCredentialCommand.cs

@@ -72,8 +74,9 @@ public override void ExecuteCmdlet()
                    ObjectId = ActiveDirectoryClient.GetObjectIdFromApplicationId(ApplicationId);
                }

+                string decodedPassword = Utilities.SecureStringToString(Password);


Please use this conversion method instead (and change in other files). #Resolved

maddieclayton · 2017-10-26T18:08:37Z

src/ResourceManager/Resources/Commands.Resources/Commands.Resources.csproj

@@ -135,6 +135,7 @@
    <Compile Include="Models.ResourceGroups\ResourceClient.ResourceManager.cs" />
    <Compile Include="Properties\AssemblyInfo.cs" />
    <Compile Include="Models.ResourceGroups\ResourceClient.cs" />
+    <Compile Include="Utilities\Utility.cs" />


Remove this (don't need when you change to common conversion method). #Resolved

maddieclayton · 2017-10-26T18:08:40Z

src/ResourceManager/Resources/Commands.Resources/Utilities/Utility.cs

@@ -0,0 +1,34 @@
+// ----------------------------------------------------------------------------------


Remove this (don't need when you change to common conversion method). #Resolved

maddieclayton · 2017-10-26T18:17:43Z

To fix your build issues, add your breaking changes errors here to the breaking changes file here. Let me know if this does not fix your build or if you have any questions. #Resolved

…nto passwordfix

maddieclayton · 2017-10-31T19:34:08Z

@darshanhs90 I think your recent changes broke these tests:
TestNewADServicePrincipal
TestNewADServicePrincipalWithoutApp
TestNewADApplication

Can you rerecord these tests? #Resolved

Build failed

darshanhs90 · 2017-10-31T19:42:28Z

rerecorded and pushed the changes

In reply to: 340882176 [](ancestors = 340882176)

maddieclayton · 2017-10-31T20:50:35Z

...sourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADAppCredentialCommand.cs

-#pragma warning disable 0618
-                if (!string.IsNullOrEmpty(Password))
-#pragma warning restore 0618
+                string decodedPassword = SecureStringExtensions.ConvertToString(Password);


This will throw an error if Password is null, please decode once you've checked if Password is null or empty. #Resolved

maddieclayton · 2017-10-31T20:51:13Z

src/ResourceManager/Resources/Commands.Resources/ActiveDirectory/SetAzureADUserCommand.cs

-#pragma warning disable 0618
-            if (!string.IsNullOrEmpty(Password))
-#pragma warning restore 0618
+            string decodedPassword = SecureStringExtensions.ConvertToString(Password);


Same #Resolved

maddieclayton · 2017-10-31T20:51:42Z

...esourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADSpCredentialCommand.cs

-#pragma warning disable 0618
-                if (!string.IsNullOrEmpty(Password))
-#pragma warning restore 0618
+                string decodedPassword = SecureStringExtensions.ConvertToString(Password);


Same #Resolved

darshanhs90 · 2017-10-31T23:02:59Z

Made the changes as per the comments #Resolved

maddieclayton

Two very small changes.

maddieclayton · 2017-10-31T23:45:55Z

...sourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADAppCredentialCommand.cs

-#pragma warning disable 0618
-                if (!string.IsNullOrEmpty(Password))
-#pragma warning restore 0618
+                if (Password != null && Password.Length > 0)


Nit: use if (!string.IsNullOrEmpty(Password)) as used previously

Apply to the other uses in this PR as well. #WontFix

since Password is a type of securestring,we cant use string.IsNullOrEmpty on that

In reply to: 148155448 [](ancestors = 148155448)

Ah right, good catch.

maddieclayton · 2017-10-31T23:46:27Z

...esourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADSpCredentialCommand.cs

-                if (!string.IsNullOrEmpty(Password))
-#pragma warning restore 0618
-                {
+                if (Password != null && Password.Length > 0) {


All beginning brackets should be on a new line. Please apply across this whole file. #Resolved

cormacpayne · 2017-11-01T18:02:58Z

On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/108/

maddieclayton · 2017-11-01T20:07:37Z

@azuresdkci test this please

darshanhs90 added 2 commits September 26, 2017 15:24

pwdfix changes

bec2f0f

merge branch

2f6c2f6

azuresdkci assigned markcowl Sep 26, 2017

azuresdkci added the needs-review label Sep 27, 2017

markcowl added the Do Not Merge 🚫 label Sep 28, 2017

markcowl added needs-revision and removed needs-review labels Sep 28, 2017

markcowl assigned darshanhs90 and unassigned markcowl Sep 28, 2017

markcowl removed the needs-revision label Sep 28, 2017

darshanhs90 added 2 commits September 28, 2017 12:04

fix merge conflicts

bf5abf5

remove obsolete tag changes

4c0e769

markcowl closed this Oct 3, 2017

darshanhs90 reopened this Oct 26, 2017

maddieclayton suggested changes Oct 26, 2017

View reviewed changes

maddieclayton mentioned this pull request Oct 26, 2017

Password parameter and other password-like parameters expect a plain-text string #4359

Closed

maddieclayton added needs-revision and removed Do Not Merge 🚫 labels Oct 26, 2017

darshanhs90 added 2 commits October 31, 2017 10:52

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

887b979

…nto passwordfix

update the pr as per the comments

5ec2da7

maddieclayton assigned maddieclayton and unassigned darshanhs90 Oct 31, 2017

maddieclayton added needs-review and removed needs-revision labels Oct 31, 2017

maddieclayton previously approved these changes Oct 31, 2017

View reviewed changes

maddieclayton assigned darshanhs90 Oct 31, 2017

maddieclayton added needs-revision and removed needs-review labels Oct 31, 2017

fix the null pwd bug and rerecord tests

8b1b901

maddieclayton assigned maddieclayton and unassigned darshanhs90 Oct 31, 2017

maddieclayton added needs-review and removed needs-revision labels Oct 31, 2017

maddieclayton suggested changes Oct 31, 2017

View reviewed changes

maddieclayton added needs-revision and removed needs-review labels Oct 31, 2017

maddieclayton assigned darshanhs90 and unassigned maddieclayton Oct 31, 2017

update null handling for securestring password

57ec32e

darshanhs90 added needs-review and removed needs-revision labels Oct 31, 2017

darshanhs90 assigned maddieclayton Oct 31, 2017

maddieclayton reviewed Oct 31, 2017

View reviewed changes

maddieclayton added needs-revision and removed needs-review labels Oct 31, 2017

maddieclayton removed their assignment Oct 31, 2017

update braces

b0b07b6

cormacpayne added the Waiting for On Demand label Nov 1, 2017

maddieclayton approved these changes Nov 1, 2017

View reviewed changes

maddieclayton removed the needs-revision label Nov 1, 2017

maddieclayton merged commit f2a2278 into Azure:preview Nov 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Password fields changes for November breaking change release #4664

Password fields changes for November breaking change release #4664

darshanhs90 commented Sep 26, 2017 •

edited by azuresdkci

Loading

markcowl commented Sep 28, 2017 •

edited by darshanhs90

Loading

markcowl commented Oct 3, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton commented Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton commented Oct 31, 2017 •

edited by darshanhs90

Loading

darshanhs90 commented Oct 31, 2017

maddieclayton Oct 31, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 31, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 31, 2017 •

edited by darshanhs90

Loading

darshanhs90 commented Oct 31, 2017 •

edited

Loading

maddieclayton left a comment

maddieclayton Oct 31, 2017 •

edited by darshanhs90

Loading

darshanhs90 Nov 1, 2017

maddieclayton Nov 1, 2017

maddieclayton Oct 31, 2017 •

edited by darshanhs90

Loading

cormacpayne commented Nov 1, 2017

maddieclayton commented Nov 1, 2017

		@@ -0,0 +1,34 @@
		// ----------------------------------------------------------------------------------

Password fields changes for November breaking change release #4664

Password fields changes for November breaking change release #4664

Conversation

darshanhs90 commented Sep 26, 2017 • edited by azuresdkci Loading

Description

General Guidelines

Testing Guidelines

Cmdlet Signature Guidelines

Cmdlet Parameter Guidelines

markcowl commented Sep 28, 2017 • edited by darshanhs90 Loading

markcowl commented Oct 3, 2017 • edited by darshanhs90 Loading

maddieclayton Oct 26, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

maddieclayton Oct 26, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

maddieclayton Oct 26, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

maddieclayton Oct 26, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

maddieclayton Oct 26, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

maddieclayton commented Oct 26, 2017 • edited by darshanhs90 Loading

maddieclayton commented Oct 31, 2017 • edited by darshanhs90 Loading

darshanhs90 commented Oct 31, 2017

maddieclayton Oct 31, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

maddieclayton Oct 31, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

maddieclayton Oct 31, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

darshanhs90 commented Oct 31, 2017 • edited Loading

maddieclayton left a comment

Choose a reason for hiding this comment

maddieclayton Oct 31, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

darshanhs90 Nov 1, 2017

Choose a reason for hiding this comment

maddieclayton Nov 1, 2017

Choose a reason for hiding this comment

maddieclayton Oct 31, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

cormacpayne commented Nov 1, 2017

maddieclayton commented Nov 1, 2017

darshanhs90 commented Sep 26, 2017 •

edited by azuresdkci

Loading

markcowl commented Sep 28, 2017 •

edited by darshanhs90

Loading

markcowl commented Oct 3, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton commented Oct 26, 2017 •

edited by darshanhs90

Loading

maddieclayton commented Oct 31, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 31, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 31, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 31, 2017 •

edited by darshanhs90

Loading

darshanhs90 commented Oct 31, 2017 •

edited

Loading

maddieclayton Oct 31, 2017 •

edited by darshanhs90

Loading

maddieclayton Oct 31, 2017 •

edited by darshanhs90

Loading