Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password parameter and other password-like parameters expect a plain-text string #4359

Closed
alexandair opened this issue Jul 25, 2017 · 3 comments
Assignees
Milestone

Comments

@alexandair
Copy link
Contributor

alexandair commented Jul 25, 2017

A bunch of AzureRM cmdlets that deal with secrets using -Password, -CertificatePassword and other password-like parameters (for example, for working with "keys") expect a string value instead of a SecureString value or PSCredential.

For example:

PS C:\> gcm -Module azurerm.* -ParameterName password -ParameterType string

CommandType Name Version Source
----------- ---- ------- ------
Cmdlet Add-AzureRmApplicationGatewaySslCertificate 3.6.0 AzureRM.Network
Cmdlet New-AzureBatchCertificate 2.7.0 AzureRM.Batch
Cmdlet New-AzureBatchComputeNodeUser 2.7.0 AzureRM.Batch
Cmdlet New-AzureRmADAppCredential 3.7.0 AzureRM.Resources
Cmdlet New-AzureRmADApplication 3.7.0 AzureRM.Resources
Cmdlet New-AzureRmADServicePrincipal 3.7.0 AzureRM.Resources
Cmdlet New-AzureRmADSpCredential 3.7.0 AzureRM.Resources
Cmdlet New-AzureRmADUser 3.7.0 AzureRM.Resources
Cmdlet New-AzureRmApiManagementBackendProxy 3.5.0 AzureRM.ApiManagement
Cmdlet New-AzureRmApiManagementUser 3.5.0 AzureRM.ApiManagement
Cmdlet New-AzureRmApplicationGatewaySslCertificate 3.6.0 AzureRM.Network
Cmdlet Set-AzureBatchComputeNodeUser 2.7.0 AzureRM.Batch
Cmdlet Set-AzureRmADUser 3.7.0 AzureRM.Resources
Cmdlet Set-AzureRmApiManagementUser 3.5.0 AzureRM.ApiManagement
Cmdlet Set-AzureRmApplicationGatewaySslCertificate 3.6.0 AzureRM.Network
Cmdlet Set-AzureRmVMAccessExtension 2.8.0 AzureRM.Compute
@markcowl
Copy link
Member

markcowl commented Aug 10, 2017

Description

Per PowerShell team advice, single-value secrets (e.g. certificate passwords) whould be represented as SecureString parameters.

For each of the obove cmdlets:

  • Reach out to feature team wit a recommendation to add a new secure parameter, or change the parameter type in November
    • New parameter types should be SecureString for single value secrets, or PSCredential for credentials (username/pw; SPN/secret, etc.)
  • Add an obsolete message to each of these parameters in the September release to indicate the name or name/type change
  • Add to the upcoming breaking change doc

Cost: 2

@maddieclayton
Copy link
Contributor

maddieclayton commented Sep 29, 2017

@maddieclayton
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants