Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preannouncement of DesktopVirtualization Upcoming Breaking Changes #26269

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

msJinLei
Copy link
Contributor

@msJinLei msJinLei commented Oct 10, 2024

Description

Pick the upcoming breaking change from #26249 and do some revisions.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Oct 10, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@msJinLei msJinLei force-pushed the desktopvirtualization_preannouncement branch from d625e22 to ff9a24e Compare October 10, 2024 21:29
@msJinLei
Copy link
Contributor Author

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

- SystemDataLastModifiedBy
- SystemDataCreatedBy
### Array replaced by List due to the generated tool (autorest.powershell) upgrading
- Details can be found [Breaking Changes in Generated Modules Due to AutoRest.PowerShell Upgrade from v3 to v4](https://github.com/Azure/azure-powershell/blob/main/documentation/breaking-changes/breaking-changes-in-generated-modules-due-to-codegen-tool-upgrade-from-v3-to-v4.md#list-replaces-array-in-generated-c-classes)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msJinLei msJinLei added the Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change label Oct 21, 2024
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I directly committed on top of your branch. The main changes include:

  1. Title
  2. links - when pasting links from learn, remove the locale (en-us) and the version (azps-12.4.0)
  3. Reduced level of cascading

@msJinLei msJinLei merged commit 5e39fe2 into Azure:main Oct 23, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
…26269)

* Preannouncement of DesktopVirtualization Upcoming Breaking Changes

* Address review comments

* polish expression

* Update upcoming-breaking-changes-desktopvirtualization.md

---------

Co-authored-by: alecbaird <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>
VeryEarly added a commit that referenced this pull request Oct 24, 2024
…26269) (#26456)

* Preannouncement of DesktopVirtualization Upcoming Breaking Changes

* Address review comments

* polish expression

* Update upcoming-breaking-changes-desktopvirtualization.md

---------

Co-authored-by: Jin Lei <[email protected]>
Co-authored-by: alecbaird <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants