-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preannouncement of DesktopVirtualization Upcoming Breaking Changes #26269
Merged
msJinLei
merged 4 commits into
Azure:main
from
msJinLei:desktopvirtualization_preannouncement
Oct 23, 2024
Merged
Preannouncement of DesktopVirtualization Upcoming Breaking Changes #26269
msJinLei
merged 4 commits into
Azure:main
from
msJinLei:desktopvirtualization_preannouncement
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
msJinLei
force-pushed
the
desktopvirtualization_preannouncement
branch
from
October 10, 2024 21:29
d625e22
to
ff9a24e
Compare
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
alec-baird
approved these changes
Oct 10, 2024
msJinLei
commented
Oct 12, 2024
- SystemDataLastModifiedBy | ||
- SystemDataCreatedBy | ||
### Array replaced by List due to the generated tool (autorest.powershell) upgrading | ||
- Details can be found [Breaking Changes in Generated Modules Due to AutoRest.PowerShell Upgrade from v3 to v4](https://github.com/Azure/azure-powershell/blob/main/documentation/breaking-changes/breaking-changes-in-generated-modules-due-to-codegen-tool-upgrade-from-v3-to-v4.md#list-replaces-array-in-generated-c-classes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isra-fel
reviewed
Oct 17, 2024
documentation/breaking-changes/upcoming-breaking-changes-desktopvirtualization.md
Outdated
Show resolved
Hide resolved
isra-fel
reviewed
Oct 17, 2024
documentation/breaking-changes/upcoming-breaking-changes-desktopvirtualization.md
Outdated
Show resolved
Hide resolved
6 tasks
msJinLei
added
the
Breaking Change Preannounce
This PR adds preannouncement about upcoming breaking change
label
Oct 21, 2024
isra-fel
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I directly committed on top of your branch. The main changes include:
- Title
- links - when pasting links from learn, remove the locale (en-us) and the version (azps-12.4.0)
- Reduced level of cascading
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
…26269) * Preannouncement of DesktopVirtualization Upcoming Breaking Changes * Address review comments * polish expression * Update upcoming-breaking-changes-desktopvirtualization.md --------- Co-authored-by: alecbaird <[email protected]> Co-authored-by: Yeming Liu <[email protected]>
VeryEarly
added a commit
that referenced
this pull request
Oct 24, 2024
…26269) (#26456) * Preannouncement of DesktopVirtualization Upcoming Breaking Changes * Address review comments * polish expression * Update upcoming-breaking-changes-desktopvirtualization.md --------- Co-authored-by: Jin Lei <[email protected]> Co-authored-by: alecbaird <[email protected]> Co-authored-by: Yeming Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pick the upcoming breaking change from #26249 and do some revisions.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.